Commit graph

524 commits

Author SHA1 Message Date
Andy Munro
50caba8e2e KEYCLOAK-15771 Updates based on peer editing agreements on clients topics and making corrections to roles and groups chapter. 2021-09-21 08:58:46 +02:00
Brian Dooley
dee2877e17 INcorporates feedback (#40) 2021-09-21 08:58:46 +02:00
Andy Munro
bbc00004fc Applying bold and other changes to merge roles and groups topics. 2021-09-21 08:58:46 +02:00
Brian Dooley
83a8648b74 KEYCLOAK-16186-2 modularizes files (#39) 2021-09-21 08:58:46 +02:00
Andy Munro
19ec0eeb7b applying bold to clients chapter 2021-09-21 08:58:46 +02:00
Andy Munro
f458928e1f KEYCLOAK-16069 minor changes 2021-09-21 08:58:46 +02:00
Andy Munro
f0c68e15b8 KEYCLOAK-16069 minor changes for reuse 2021-09-21 08:58:46 +02:00
Brian Dooley
b3aa9c98d0 KEYCLOAK-16186 Initial rewording (#38)
* KEYCLOAK-16186 Initial rewording

* Post workding feedback

* post visual review changes

* more post feedback changes

* Update default-roles.adoc

Minor correction where you include my incorrect suggestion.

Co-authored-by: andymunro <48995441+andymunro@users.noreply.github.com>
2021-09-21 08:58:46 +02:00
Joan Edwards
640b8737bc Clean Managing Users section (#37)
* Clean Managing Users section

* Update user.adoc

* Update text

* Update text
2021-09-21 08:58:46 +02:00
Andy Munro
d6e172a74a KEYCLOAK-16069 applied conditional text for all modules required by RHOAM 2021-09-21 08:58:46 +02:00
Andy Munro
5e050782be KEYCLOAK-16117 applying minor updates to wording and other changes for consistency with CCS standards 2021-09-21 08:58:46 +02:00
Andy Munro
f84b7fd0ed https://issues.redhat.com/browse/KEYCLOAK-16069 updating create a realm topic and create an oidc client to work in RHOAM 2021-09-21 08:58:46 +02:00
Brian Dooley
34af5ab7c2 Keycloak 16024 (#36)
* rearranges all client modules into assembly

* Adds [role=_abstract] to modules
2021-09-21 08:58:46 +02:00
Andy Munro
7f4bd1e915 KEYCLOAK-16069 improvements for creating a realm 2021-09-21 08:58:46 +02:00
Brian Dooley
e27ec2bd85 Keycloak 16054 (#35)
* KEYCLOAK-16054 main changes

* renaming

* fixes renaming errors
2021-09-21 08:58:46 +02:00
Andy Munro
ac518b7b26 KEYCLOAK-16069 tested use of standalone attribute on create a realm procedure 2021-09-21 08:58:46 +02:00
Andy Munro
820a10fae1 changing audience.doc to con-audience.adoc 2021-09-21 08:58:46 +02:00
Brian Dooley
d75252ff3f rearranges assembly (#34)
Co-authored-by: andymunro <48995441+andymunro@users.noreply.github.com>
2021-09-21 08:58:46 +02:00
Brian Dooley
27b557facd Keycloak 16053 (#33)
* post renaming

* post changes
2021-09-21 08:58:46 +02:00
Brian Dooley
793740f324 Post feedback changes (#30) 2021-09-21 08:58:46 +02:00
Andy Munro
c95cb2a284 Fix cross-references and filenames 2021-09-21 08:58:46 +02:00
Brian Dooley
fc5d95b86f KEYCLOAK-15616 initial commit (#25)
* KEYCLOAK-15527 Adding context to master.adoc and index.adoc to allow reuse

* KEYCLOAK-15614 modularisation of 'Creating an Open ID Connect Client' (#14)

* More changes based on feedback

* Puts back 2 out of 3 screens

* KEYCLOAK-15614 updates to anchors

* Minor spelling correction in Getting Started

* Keycloak 15786 (#16)

* rebase corrections

* post feedback changes

* post review changes (#18)

* KEYCLOAK-15616 initial commit

Co-authored-by: Andy Munro <amunro@redhat.com>
2021-09-21 08:58:46 +02:00
Brian Dooley
2d843ba868 Keycloak 16052 (#32)
* KEYCLOAK-16052 post rewrite

* KEYCLOAK-16052 post loal review changes
2021-09-21 08:58:46 +02:00
Joan Edwards
650e42f943 KEYCLOAK-15643: Update User Registration (#20)
* Update user registration

* Update modules

* Update and rename proc-completing-registration-form.adoc to proc-registering-new-user.adoc

* Update user-registration.adoc

* Update proc-enabling-user-registration.adoc

* Update proc-enabling-user-registration.adoc

* Update proc-registering-new-user.adoc

* Update proc-enabling-user-registration.adoc

* Update proc-registering-new-user.adoc

* Update user-registration.adoc

* Update proc-registering-new-user.adoc

* Update user-registration.adoc

* Update proc-registering-new-user.adoc

* Update user-registration.adoc

* Update user-registration.adoc
2021-09-21 08:58:46 +02:00
Andy Munro
28343a4b0b minor formatting and text changes 2021-09-21 08:58:46 +02:00
Andy Munro
839ff2420a Minor changes 2021-09-21 08:58:46 +02:00
Joan Edwards
b3fbac011c KEYCLOAK-15897: Update Credentials (#23)
* Update Credentials

* Update Credentials module

* Update credentials.adoc

* Update proc-creating-otp.adoc

* Update proc-setting-password-user.adoc

* Update proc-setting-password-user.adoc

* Update proc-creating-otp.adoc

* Update credentials.adoc

* Update proc-setting-password-user.adoc

* Update credentials.adoc

* Update credentials.adoc

* Update proc-creating-otp.adoc

Just corrected on type (Configue) so I can merge this one.

Co-authored-by: andymunro <48995441+andymunro@users.noreply.github.com>
2021-09-21 08:58:46 +02:00
Andy Munro
1e51a8d902 Fix Users TOC 2021-09-21 08:58:46 +02:00
Andy Munro
f270109bb2 removing client-saml.adoc 2021-09-21 08:58:46 +02:00
Andy Munro
692f145d5f Adding indentation in TOc for users chapter 2021-09-21 08:58:46 +02:00
Andy Munro
3076ab2f2f moving content from master to admin-reuse 2021-09-21 08:58:46 +02:00
Brian Dooley
59f8d09294 post review changes (#18) 2021-09-21 08:58:46 +02:00
Brian Dooley
06b791e17e Keycloak 15786 (#16)
* rebase corrections

* post feedback changes
2021-09-21 08:58:46 +02:00
Andy Munro
a04a2a28fd KEYCLOAK-15614 updates to anchors 2021-09-21 08:58:46 +02:00
Brian Dooley
f0d4fdd920 KEYCLOAK-15614 modularisation of 'Creating an Open ID Connect Client' (#14)
* More changes based on feedback

* Puts back 2 out of 3 screens
2021-09-21 08:58:46 +02:00
Andy Munro
09af683afb KEYCLOAK-15527 Adding context to master.adoc and index.adoc to allow reuse 2021-09-21 08:58:46 +02:00
Luca Leonardo Scorcia
43821b3145 KEYCLOAK-16462 X509 Auth: add option to revalidate certificate trust 2021-09-13 12:13:12 +02:00
Yoshiyuki Tabata
f56b7b8eb9 KEYCLOAK-16916 - Adding WebAuthn sign-in options from Marek 2021-09-01 08:36:46 +02:00
Marek Posolda
5ccf8699a2 KEYCLOAK-16916 Adding WebAuthn to the account console (#61) 2021-09-01 08:36:46 +02:00
Andrew Munro
28157a1cd3 KEYCLOAK-16916 Documenting the new Account Console
(cherry picked from commit 04534dabb32dc448b175bb102ed7b57d0fe8e28e)
2021-09-01 08:36:46 +02:00
Andrew Munro
30a20a49d9 KEYCLOAK-16916 Documenting the new Account Console
(cherry picked from commit 44ddb212d981c84046dff272f26647d20fe79268)
2021-09-01 08:36:46 +02:00
Yoshiyuki Tabata
7dc0fc46b0 KEYCLOAK-18341 Support JWKS OAuth2 Client Metadata in the "by value" key
loading method
2021-08-05 16:54:30 +02:00
AndyMunro
52e1fde120 CIAM-538 Correcting error that hides roles chapter 2021-08-02 14:44:06 +02:00
stianst
a66f2ac600 Some minor fixes to user-profile 2021-07-30 12:29:32 +02:00
stianst
d06a0cfb07 Move user profile images to shared directory 2021-07-30 12:29:32 +02:00
Pedro Igor
a1ac618f47 [KEYCLOAK-18816] - Updates to User Profile 2021-07-30 12:29:32 +02:00
mposolda
34fcfb80a8 KEYCLOAK-18883 KEYCLOAK-18864 FAPI CIBA and OpenBanking Brasil updates 2021-07-29 23:41:06 +02:00
Martin Kanis
84e5203174 KEYCLOAK-18738 Improve RootAuthenticationSession description 2021-07-29 21:17:15 +02:00
AndyMunro
c88ece8b5c KEYCLOAK-15932 Addressed review comments from Stefan 2021-07-28 08:53:28 +02:00
Luca Leonardo Scorcia
e1ccbacacb KEYCLOAK-17290 Description for the Attribute Consuming Service related parameters 2021-07-22 21:59:30 +02:00
Takashi Norimatsu
1069495b18 KEYCLOAK-18353 Implement Pushed Authorization Request inside the Keycloak 2021-07-03 08:49:33 +02:00
Pedro Igor
0dd8544ea4 [KEYCLOAK-17399] - Declarative User Profile 2021-06-14 11:28:38 +02:00
AndyMunro
e40ed2d7c4 KEYCLOAK-18360 adding missing file: client-oidc-keys.png 2021-06-10 16:08:53 -03:00
Martin Kanis
cbe50e046b KEYCLOAK-16616 authenticationSessions map in RootAuthenticationSessionEntity grows unboundedly 2021-06-10 09:00:53 +02:00
Martin Kanis
485e802ad8 KEYCLOAK-11019 Offline sessions preloading docs 2021-06-10 08:54:53 +02:00
mposolda
817eb73093 KEYCLOAK-17940 Client policies documentation
Co-authored-by: Václav Muzikář <vaclav@muzikari.cz>
2021-06-09 08:47:47 +02:00
stianst
d152d07378 Fix missing image in RH-SSO docs 2021-06-07 14:18:23 +02:00
Benjamin Weimer
6431e3a0f7 KEYCLOAK-2940 Adding documentation for backchannel logout 2021-06-07 12:52:26 +02:00
Hynek Mlnarik
b572fcff07 KEYCLOAK-18301 Fix broken links 2021-05-31 08:59:58 +02:00
Yoshiyuki Tabata
fde7cdeb70 KEYCLOAK-17491 Move the key settings to the new Keys tab 2021-05-27 15:27:18 +02:00
Takashi Norimatsu
d163139add KEYCLOAK-18272 CIBA Documentation : Authentication Delegation Response status is 201, not 204 2021-05-26 07:51:35 +02:00
Daniel Fesenmeyer
6649fcc2f4 KEYCLOAK-17284 document the new tabs of the client scopes evaluate screen: "Generated ID Token" and "Generated User Info" 2021-04-29 16:46:33 +02:00
Takashi Norimatsu
75a1e89d58 avoid writing specific product name 2021-04-29 15:59:35 +02:00
Takashi Norimatsu
9f06816cda fix regression error 2021-04-29 15:59:35 +02:00
Takashi Norimatsu
f571e01fd0 revise sentences 2021-04-29 15:59:35 +02:00
Takashi Norimatsu
f62cec55f7 KEYCLOAK-12137 OpenID Connect Client Initiated Backchannel Authentication (CIBA) 2021-04-29 15:59:35 +02:00
Jan Lieskovsky
8883ba5d38 [KEYCLOAK-14894] Update versions of (various) URN namespaces
to match their respective Wildfly 22 counterparts

[KEYCLOAK-16760] Update Keycloak documentation for the
upgrade to Wildfly 22

Signed-off-by: Jan Lieskovsky <jlieskov@redhat.com>
2021-04-29 12:36:48 +02:00
Michal Hajas
686e2ce99c KEYCLOAK-17824 Fix ReleaseNotes test failure 2021-04-21 08:26:39 +02:00
i7a7467
b7574b6f53 KEYCLOAK-16918 Set custom user attribute to Name ID Format for a SAML client 2021-04-20 13:35:46 +02:00
Michal Hajas
79ec3f37a5 KEYCLOAK-831 Modification to documentation for SAML artifact-binding 2021-04-16 12:16:01 +02:00
Alec Henninger
1d4d351611 Correct OIDC endpoint descriptions 2021-04-13 16:56:15 +02:00
Martin Bartoš
b7437e3cd3 KEYCLOAK-16401 Deny/Allow access in a conditional context 2021-04-09 12:05:25 +02:00
Konstantinos Georgilakis
ee43080330 KEYCLOAK-5657 transient NameIDPolicy and AllowCreate 2021-03-31 14:46:21 +02:00
mposolda
7c1f5b05cc KEYCLOAK-17614 Add troubleshooting section to the LDAP documentation 2021-03-31 08:58:29 +02:00
Andy Munro
b32f5b9bf7 KEYCLOAK-16851 revised overview chapter to create more findable titles 2021-03-19 09:38:20 +01:00
mposolda
987ea0ba1c KEYCLOAK-16425 Cleanup documentation regarding the logic for selecting locale. Use inter-links instead of duplicating logic description 2021-03-16 09:17:08 +01:00
mposolda
0f4affd1e9 KEYCLOAK-15484 Document that client certificate trust should be validated by reverse proxy 2021-03-15 16:59:15 +01:00
Michito Okai
68dcd06748 KEYCLOAK-7675 Support for Device Authorization Grant 2021-03-15 14:45:05 +01:00
Andy Munro
e18ea48b26 KEYCLOAK-16929 Adding conscious language preface of the release notes 2021-03-02 09:34:57 +01:00
i7a7467
6b16d408ee KEYCLOAK-16679 Add algorithm settings for client assertion signature in OIDC identity broker
- fix about reviewer's comments
2021-03-01 18:11:51 +01:00
i7a7467
ecc3176455 KEYCLOAK-16679 Add algorithm settings for client assertion signature in OIDC identity broker 2021-03-01 18:11:51 +01:00
dxmann73
105828a6c6 Add jwks_uri to list of endpoints (Spring OAuth2)
Improved wording
2021-02-17 13:29:47 +01:00
dxmann73
5955d2d48a Add jwks_uri to list of endpoints (Spring OAuth2)
When configuring Spring OAuth2, we need the jwk-set-uri for the provider. Needed some digging to find it, so I thought I'd add this information here.
2021-02-17 13:29:47 +01:00
stianst
6ec77f9a9b Fix images for delete account 2021-02-17 10:17:55 +01:00
Paul Roth
f1bf774ecc Correct minor typo
change 'lowercased' to 'lowercase'
2021-02-17 09:15:14 +01:00
albertmolinermrf
152541255d Fix typo (missing space between words) 2021-02-17 09:01:41 +01:00
Diod FR
a30a2b3039 KEYCLOAK-4544 Detect existing user before granting user autolink 2021-02-11 11:07:07 +01:00
Marek Posolda
b34fb17029
KEYCLOAK-16468 Read-only user attributes (#1081)
(cherry picked from commit 4e505128a5b8d7f916a330bc0fef883da04a441b)
(cherry picked from commit 511b127bb36baed787da7cf2d88549bd14e5d0a9)

Co-authored-by: Stian Thorgersen <stianst@gmail.com>
2021-01-18 13:18:04 +01:00
Stefan Guilhen
9a21c9cb05 [KEYCLOAK-16788] Fix broken links 2021-01-15 10:47:01 +01:00
vramik
7ad57a47ca KEYCLOAK-14846 default roles processing 2021-01-08 13:56:05 +01:00
Martin Bartoš
4b0e30c9bc KEYCLOAK-15856 Conditions in Conditional flow 2020-12-14 16:45:31 +01:00
zak905
3c3131b9ab adjustements and update images to match latest changes 2020-11-24 15:50:50 +01:00
zak905
73d449f2da KEYCLOAK-953: add docs about enabling user to delete account functionality 2020-11-24 15:50:50 +01:00
mposolda
af454cbd94 KEYCLOAK-9551 Client Credentials Grant should not generate refresh token 2020-11-06 09:16:36 +01:00
Christoph Leistert
e3cba1af29 KEYCLOAK-14855 Add hints to realm-specific localization texts 2020-10-30 12:30:26 +01:00
Martin Bartoš
bb70a59a5a KEYCLOAK-14139 Upgrade login screen to PF4 docs 2020-10-27 20:20:32 +01:00
Luca Leonardo Scorcia
792deeb786 KEYCLOAK-15697 Make the Service Provider Entity ID user configurable 2020-10-09 22:04:09 +02:00
mposolda
bce56fe5c0 KEYCLOAK-15770 Skip creating session for docker protocol authentication 2020-10-09 07:52:49 +02:00
Luca Leonardo Scorcia
d4302c0b88 KEYCLOAK-15485 Add option to enable SAML SP metadata signature 2020-09-16 16:40:49 +02:00
Heikki Simperi
4500dcbbc6 KEYCLOAK-13837 Admin cli command has alias parameter should be keyAlias 2020-09-10 10:58:52 -03:00
PoojaChandak
1fd8a6e28e Update fine-grain.adoc
review comment update
2020-09-07 06:09:50 -07:00
PoojaChandak
43dbad7cfc Update fine-grain.adoc
Observed a few changes, suggesting the same. Kindly check.
2020-09-07 06:09:50 -07:00
Luca Leonardo Scorcia
865dd55f04 KEYCLOAK-14961 SAML Client: Add ability to request specific AuthnContexts to remote IdPs 2020-09-03 21:25:30 +02:00
Luca Leonardo Scorcia
cc2150dd90 KEYCLOAK-14902 Replace SAML SP metadata export with link to descriptor 2020-08-31 22:27:06 +02:00
Thomas Darimont
695457d46a KEYCLOAK-12729 Document Not-Email Password-Policy
Introduced via PR: https://github.com/keycloak/keycloak/pull/7103
2020-08-21 14:55:43 +02:00
Alex Szczuczko
c3830b1f64 KEYCLOAK-14862 Fix redirect links previously shadowed by a test bug 2020-08-05 10:57:16 -03:00
Dillon Sellars
727b8963a3 KEYCLOAK-14529 Signed and Encrypted ID Token Support : RSA-OAEP-256 Key Management Algorithm 2020-07-30 15:21:19 +02:00
Lorent Lempereur
1b37a849bc
KEYCLOAK-13950 SAML2 Identity Provider - Send Subject in SAML requests 2020-07-24 21:42:12 +02:00
vmuzikar
4b016d7c08 KEYCLOAK-14023 Instagram User Endpoint change 2020-07-10 17:37:08 -03:00
Renann Prado
8256641ecd There's no Google+ anymore 2020-07-10 09:21:41 +02:00
Sean McCormick
7139636c0e Updated section on the Credentials tab
Previously, the process for viewing the credentials tab left out an important step. Namely, that the Credentials tab does not show up until you've saved the client with the Access Type set to confidential. 

This patch adds a sentence to help guide readers to get to the Credentials tab.
2020-07-10 07:26:20 +02:00
mposolda
6715676529 KEYCLOAK-14467 Improve the brute force docs about the error message for temporarily disabled user 2020-07-10 07:24:12 +02:00
Arvid Karlsson
daefab2fba Update configuration.adoc
Changed from Google to Facebook to match the images
2020-07-01 19:30:30 -03:00
Fritz Oscar
112a31b10c add word to complete the sentence 2020-07-01 19:13:30 -03:00
Fritz Oscar
d9bc99962e link current best practice for OAuth
It could also be considered to link the oauth.net website (https://oauth.net/2/oauth-best-practice/) instead to always point to the most recent document.
2020-07-01 19:12:49 -03:00
Bartosz Siemieńczuk
17d1819101 KEYCLOAK-14006 Allow administrator to add additional fields to be fetched with Facebook profile request 2020-07-01 19:10:48 -03:00
mposolda
20ce29c830 KEYCLOAK-14417 Clarify the export/import documentation for the keycloak.import mechanism 2020-06-19 11:00:20 +02:00
mposolda
141c092ab7 KEYCLOAK-14383 keycloak-documentation tests are failing due the link to ha-proxy 2020-06-18 08:45:54 +02:00
Yoshiyuki Tabata
ad2f010976 KEYCLOAK-14145 OIDC support for Client "offline" session lifespan 2020-06-04 14:27:04 +02:00
Takashi Norimatsu
067ff33d26 KEYCLOAK-13104 Signed and Encrypted ID Token Support : AES 192bit and 256bit key support 2020-05-29 08:44:03 +02:00
Lars Uffmann
941daa4e0f KEYCLOAK-10927 change parenthetical comments to "such as..." 2020-05-29 08:41:59 +02:00
Lars Uffmann
86f9e12e8e KEYCLOAK-10927 update documentation 2020-05-29 08:41:59 +02:00
mposolda
7f8c4c89d3 KEYCLOAK-14270 Improve documentation for fullName LDAP mapper about fallback to username 2020-05-28 21:37:51 +02:00
Thomas Darimont
ac2bf88e5a KEYCLOAK-13958 Document updating and regenerating a client secret with kcadm.sh 2020-05-28 20:36:32 +02:00
Denis
fd59bff36d KEYCLOAK-14265 Typos in Authentication part of Keycloak Documentation 2020-05-20 16:34:42 +02:00
mposolda
a891a567a5 KEYCLOAK-13047 LDAP no-import fixes. Avoid lost updates - dont allow update attributes, which are not mapped to LDAP 2020-05-19 16:57:43 +02:00
stianst
4afc01e7c8 Fix links 2020-04-29 08:54:22 +02:00
Yoshiyuki Tabata
8d4e1a434b KEYCLOAK-12406 Add "Client Session Max" and "Client Session Idle" 2020-04-28 15:34:20 +02:00
Yoshiyuki Tabata
d3e18744a8 KEYCLOAK-5325 Provide OAuth token revocation capability 2020-04-28 15:26:37 +02:00
Martin Idel
73339b2c0f Applied suggestions 2020-04-24 15:54:37 +02:00
Martin Idel
eb3e2d468f Update documentation including Sync Mode 2020-04-24 15:54:37 +02:00
Kohei Tamura
88c9d0d516 Fix typos 2020-04-21 11:48:35 +02:00
Andy Munro
06608be0fe KEYCLOAK-13759 Upgrading guide 2020-04-08 20:59:19 +02:00
Andy Munro
6408ddb2c8 KEYCLOAK-9341 Updating screens to match 7.4 and Red Hat standards 2020-04-08 16:54:48 +02:00
Ejez
c1419bf56d fix typo 2020-03-31 08:53:43 +02:00
stianst
ee167f8f81 Fix links 2020-03-26 08:41:55 +01:00
Andy Munro
c026893bc4 KEYCLOAK-13308 adding steps to set the IPA user password 2020-03-20 08:16:20 +01:00
Dmitry Telegin
d0c60f4527 KEYCLOAK-12870 - Allow to pick arbitrary user for IdP linking 2020-03-20 07:41:44 +01:00
stianst
8805c8b7f6 KEYCLOAK-10967 Update instructions on testing LDAP connection with kcadm 2020-03-05 10:07:45 +01:00
stianst
1318b3ccc7 KEYCLOAK-12016 Remove note from keys section of admin console that only RSA is supported£ 2020-03-03 07:22:54 +01:00
foliengriller
91a34c2611 Add missing dot in Group vs. Roles
Add missing dot to the end of the sentence.
2020-02-27 14:05:52 +01:00
mabartos
8410937f2a KEYCLOAK-12958 Preview feature profile for WebAuthn 2020-02-26 08:46:47 +01:00
Andy Munro
b285784448 Clarified "activity" refers to "user activity." 2020-02-21 10:39:02 +01:00
Jaap Roes
c2287afcd7 Fixup 2020-02-20 08:33:49 +01:00
Jaap Roes
ea248b5601 KEYCLOAK-11700 Passwords in the blacklist must be lowercase 2020-02-20 08:33:49 +01:00
stianst
3ce3620a5a KEYCLOAK-9632 Release notes for improvements to locale handling 2020-02-14 10:31:35 +01:00
stianst
d4cba7a6e5 KEYCLOAK-12490 Add missing details for jboss-logging event listener 2020-02-14 09:52:59 +01:00
Yoshiyuki Tabata
a14ba80938 Fix the default value of Hashing Iterations 2020-02-14 09:43:37 +01:00
Andy Munro
a11f708e1f KEYCLOAK-9391 Correcting grammatical problems. 2020-02-14 09:37:50 +01:00
mposolda
c2da0a2fd8 KEYCLOAK-12753 Apply feedback 2020-02-07 13:53:19 +01:00