public client = false when clientAuthentication (#505)

fixing: #392

src/clients/ClientDetails.tsx

@@ -191,7 +191,7 @@ export const ClientDetails = () => {
   ) => {
     if (await form.trigger()) {
       if (
-        client?.publicClient &&
+        !client?.publicClient &&
         client?.clientAuthenticatorType !==
           form.getValues("clientAuthenticatorType") &&
         !confirmed
@@ -285,7 +285,7 @@ export const ClientDetails = () => {
                 reset={() => setupForm(client)}
               />
             </Tab>
-            {client.publicClient && (
+            {!client.publicClient && (
               <Tab
                 id="credentials"
                 eventKey="credentials"

src/clients/add/CapabilityConfig.tsx

@@ -40,7 +40,7 @@ export const CapabilityConfig = ({
             >
               <Controller
                 name="publicClient"
-                defaultValue={false}
+                defaultValue={true}
                 control={control}
                 render={({ onChange, value }) => (
                   <Switch
@@ -49,8 +49,8 @@ export const CapabilityConfig = ({
                     name="publicClient"
                     label={t("common:on")}
                     labelOff={t("common:off")}
-                    isChecked={value}
-                    onChange={onChange}
+                    isChecked={!value}
+                    onChange={(value) => onChange(!value)}
                   />
                 )}
               />
@@ -78,7 +78,7 @@ export const CapabilityConfig = ({
                         setValue("serviceAccountsEnabled", true);
                       }
                     }}
-                    isDisabled={!clientAuthentication}
+                    isDisabled={clientAuthentication}
                   />
                 )}
               />

src/clients/add/NewClientForm.tsx

@@ -31,7 +31,7 @@ export const NewClientForm = () => {
     clientId: "",
     name: "",
     description: "",
-    publicClient: false,
+    publicClient: true,
     authorizationServicesEnabled: false,
     serviceAccountsEnabled: false,
     implicitFlowEnabled: false,