From dd1961355793f3f37ccafb93963a9d61b802167d Mon Sep 17 00:00:00 2001
From: Erik Jan de Wit <erikjan.dewit@gmail.com>
Date: Tue, 6 Apr 2021 20:14:56 +0200
Subject: [PATCH] public client = false when clientAuthentication (#505)

fixing: #392
---
 src/clients/ClientDetails.tsx        | 4 ++--
 src/clients/add/CapabilityConfig.tsx | 8 ++++----
 src/clients/add/NewClientForm.tsx    | 2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/clients/ClientDetails.tsx b/src/clients/ClientDetails.tsx
index 2081102152..4a3866abd2 100644
--- a/src/clients/ClientDetails.tsx
+++ b/src/clients/ClientDetails.tsx
@@ -191,7 +191,7 @@ export const ClientDetails = () => {
   ) => {
     if (await form.trigger()) {
       if (
-        client?.publicClient &&
+        !client?.publicClient &&
         client?.clientAuthenticatorType !==
           form.getValues("clientAuthenticatorType") &&
         !confirmed
@@ -285,7 +285,7 @@ export const ClientDetails = () => {
                 reset={() => setupForm(client)}
               />
             </Tab>
-            {client.publicClient && (
+            {!client.publicClient && (
               <Tab
                 id="credentials"
                 eventKey="credentials"
diff --git a/src/clients/add/CapabilityConfig.tsx b/src/clients/add/CapabilityConfig.tsx
index 6275d0a748..df46404bcd 100644
--- a/src/clients/add/CapabilityConfig.tsx
+++ b/src/clients/add/CapabilityConfig.tsx
@@ -40,7 +40,7 @@ export const CapabilityConfig = ({
             >
               <Controller
                 name="publicClient"
-                defaultValue={false}
+                defaultValue={true}
                 control={control}
                 render={({ onChange, value }) => (
                   <Switch
@@ -49,8 +49,8 @@ export const CapabilityConfig = ({
                     name="publicClient"
                     label={t("common:on")}
                     labelOff={t("common:off")}
-                    isChecked={value}
-                    onChange={onChange}
+                    isChecked={!value}
+                    onChange={(value) => onChange(!value)}
                   />
                 )}
               />
@@ -78,7 +78,7 @@ export const CapabilityConfig = ({
                         setValue("serviceAccountsEnabled", true);
                       }
                     }}
-                    isDisabled={!clientAuthentication}
+                    isDisabled={clientAuthentication}
                   />
                 )}
               />
diff --git a/src/clients/add/NewClientForm.tsx b/src/clients/add/NewClientForm.tsx
index f1b9072409..b4a6b7e486 100644
--- a/src/clients/add/NewClientForm.tsx
+++ b/src/clients/add/NewClientForm.tsx
@@ -31,7 +31,7 @@ export const NewClientForm = () => {
     clientId: "",
     name: "",
     description: "",
-    publicClient: false,
+    publicClient: true,
     authorizationServicesEnabled: false,
     serviceAccountsEnabled: false,
     implicitFlowEnabled: false,