Fixed minor accessibility violations for Users (#21353)

* fixed a11y violations for Users

* fixed a11y violation on User Consents tab

* fixed a11y violation on User Consents tab

---------

Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>
This commit is contained in:
agagancarczyk 2023-06-30 18:24:35 +01:00 committed by GitHub
parent 83d043e7a8
commit 0fc4d6120b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 17 additions and 26 deletions

View file

@ -142,7 +142,7 @@ export const ResourcesTab = () => {
<TableComposable aria-label={t("resources")}>
<Thead>
<Tr>
<Th />
<Th aria-hidden="true" />
<Th>{t("resourceName")}</Th>
<Th>{t("application")}</Th>
<Th>{t("permissionRequests")}</Th>

View file

@ -197,7 +197,7 @@ export function DraggableTable<T>({
>
<Thead>
<Tr>
<Th />
<Th aria-hidden="true" />
{columns.map((column) => (
<Th key={column.name} info={thInfo(column)}>
{t(column.displayKey || column.name)}

View file

@ -62,13 +62,13 @@ export const AuthorizationEvaluateResource = ({
<TableComposable aria-label={t("evaluationResults")}>
<Thead>
<Tr>
<Th />
<Th aria-hidden="true" />
<Th>{t("permission")}</Th>
<Th>{t("results")}</Th>
<Th>{t("decisionStrategy")}</Th>
<Th>{t("grantedScopes")}</Th>
<Th>{t("deniedScopes")}</Th>
<Th />
<Th aria-hidden="true" />
</Tr>
</Thead>
{Object.values(evaluateResults[rowIndex].policies).map(

View file

@ -212,12 +212,12 @@ export const AuthorizationPolicies = ({ clientId }: PoliciesProps) => {
<TableComposable aria-label={t("resources")} variant="compact">
<Thead>
<Tr>
<Th />
<Th aria-hidden="true" />
<Th>{t("common:name")}</Th>
<Th>{t("common:type")}</Th>
<Th>{t("dependentPermission")}</Th>
<Th>{t("common:description")}</Th>
<Th />
<Th aria-hidden="true" />
</Tr>
</Thead>
{policies.map((policy, rowIndex) => (

View file

@ -148,11 +148,11 @@ export const Results = ({ evaluateResult, refresh, back }: ResultProps) => {
<TableComposable aria-label={t("evaluationResults")}>
<Thead>
<Tr>
<Th />
<Th aria-hidden="true" />
<Th>{t("resource")}</Th>
<Th>{t("overallResults")}</Th>
<Th>{t("scopes")}</Th>
<Th />
<Th aria-hidden="true" />
</Tr>
</Thead>
{filteredResources.map((resource, rowIndex) => (

View file

@ -121,7 +121,7 @@ export const ClientScope = () => {
<Tr>
<Th>{t("clientScope")}</Th>
<Th>{t("required")}</Th>
<Th />
<Th aria-hidden="true" />
</Tr>
</Thead>
<Tbody>

View file

@ -141,7 +141,7 @@ export const Group = () => {
<Tr>
<Th>{t("groups")}</Th>
<Th>{t("extendToChildren")}</Th>
<Th />
<Th aria-hidden="true" />
</Tr>
</Thead>
<Tbody>

View file

@ -117,7 +117,7 @@ export const Role = () => {
<Tr>
<Th>{t("roles")}</Th>
<Th>{t("required")}</Th>
<Th />
<Th aria-hidden="true" />
</Tr>
</Thead>
<Tbody>

View file

@ -101,7 +101,7 @@ export const AttributeValidations = () => {
<Tr>
<Th>{t("validatorColNames.colName")}</Th>
<Th>{t("validatorColNames.colConfig")}</Th>
<Th />
<Th aria-hidden="true" />
</Tr>
</Thead>
<Tbody>

View file

@ -50,12 +50,7 @@ export const UserConsents = () => {
return (
<ChipGroup className="kc-consents-chip-group">
{grantedClientScopes!.map((currentChip) => (
<Chip
key={currentChip}
isReadOnly
className="kc-consents-chip"
id="consents-chip-text"
>
<Chip key={currentChip} isReadOnly className="kc-consents-chip">
{currentChip}
</Chip>
))}

View file

@ -405,12 +405,12 @@ export const UserCredentials = ({ user }: UserCredentialsProps) => {
fieldLabelId="users:userCredentialsHelpTextLabel"
/>
</Th>
<Th />
<Th aria-hidden="true" />
<Th>{t("type")}</Th>
<Th>{t("userLabel")}</Th>
<Th>{t("data")}</Th>
<Th />
<Th />
<Th aria-hidden="true" />
<Th aria-hidden="true" />
</Tr>
</Thead>
<Tbody
@ -514,7 +514,7 @@ export const UserCredentials = ({ user }: UserCredentialsProps) => {
<Tr>
<Th>{t("type")}</Th>
<Th>{t("providedBy")}</Th>
<Th />
<Th aria-hidden="true" />
</Tr>
</Thead>
<Tbody>

View file

@ -46,10 +46,6 @@ button#kc-join-groups-button {
margin-right: 0px;
}
#consents-chip-text.pf-c-chip-text {
font-size: var(--pf-c-table--cell--FontSize);
}
.kc-consents-chip > .pf-c-chip__text {
font-size: var(--pf-c-table--cell--FontSize);
max-width: 100%;