From 0fc4d6120bee90504bea588ad85c3d04774bf9c6 Mon Sep 17 00:00:00 2001 From: agagancarczyk <4890675+agagancarczyk@users.noreply.github.com> Date: Fri, 30 Jun 2023 18:24:35 +0100 Subject: [PATCH] Fixed minor accessibility violations for Users (#21353) * fixed a11y violations for Users * fixed a11y violation on User Consents tab * fixed a11y violation on User Consents tab --------- Co-authored-by: Agnieszka Gancarczyk --- js/apps/account-ui/src/resources/ResourcesTab.tsx | 2 +- .../src/authentication/components/DraggableTable.tsx | 2 +- .../authorization/AuthorizationEvaluateResource.tsx | 4 ++-- js/apps/admin-ui/src/clients/authorization/Policies.tsx | 4 ++-- .../src/clients/authorization/evaluate/Results.tsx | 4 ++-- .../src/clients/authorization/policy/ClientScope.tsx | 2 +- .../admin-ui/src/clients/authorization/policy/Group.tsx | 2 +- .../admin-ui/src/clients/authorization/policy/Role.tsx | 2 +- .../user-profile/attribute/AttributeValidations.tsx | 2 +- js/apps/admin-ui/src/user/UserConsents.tsx | 7 +------ js/apps/admin-ui/src/user/UserCredentials.tsx | 8 ++++---- js/apps/admin-ui/src/user/user-section.css | 4 ---- 12 files changed, 17 insertions(+), 26 deletions(-) diff --git a/js/apps/account-ui/src/resources/ResourcesTab.tsx b/js/apps/account-ui/src/resources/ResourcesTab.tsx index 3a7811e6c3..46e807f98f 100644 --- a/js/apps/account-ui/src/resources/ResourcesTab.tsx +++ b/js/apps/account-ui/src/resources/ResourcesTab.tsx @@ -142,7 +142,7 @@ export const ResourcesTab = () => { - + {t("resourceName")} {t("application")} {t("permissionRequests")} diff --git a/js/apps/admin-ui/src/authentication/components/DraggableTable.tsx b/js/apps/admin-ui/src/authentication/components/DraggableTable.tsx index bec2333181..bc39d7df24 100644 --- a/js/apps/admin-ui/src/authentication/components/DraggableTable.tsx +++ b/js/apps/admin-ui/src/authentication/components/DraggableTable.tsx @@ -197,7 +197,7 @@ export function DraggableTable({ > - + {columns.map((column) => ( {t(column.displayKey || column.name)} diff --git a/js/apps/admin-ui/src/clients/authorization/AuthorizationEvaluateResource.tsx b/js/apps/admin-ui/src/clients/authorization/AuthorizationEvaluateResource.tsx index a22ac41527..603d90e705 100644 --- a/js/apps/admin-ui/src/clients/authorization/AuthorizationEvaluateResource.tsx +++ b/js/apps/admin-ui/src/clients/authorization/AuthorizationEvaluateResource.tsx @@ -62,13 +62,13 @@ export const AuthorizationEvaluateResource = ({ - + {t("permission")} {t("results")} {t("decisionStrategy")} {t("grantedScopes")} {t("deniedScopes")} - + {Object.values(evaluateResults[rowIndex].policies).map( diff --git a/js/apps/admin-ui/src/clients/authorization/Policies.tsx b/js/apps/admin-ui/src/clients/authorization/Policies.tsx index 5d61496da4..71a649c489 100644 --- a/js/apps/admin-ui/src/clients/authorization/Policies.tsx +++ b/js/apps/admin-ui/src/clients/authorization/Policies.tsx @@ -212,12 +212,12 @@ export const AuthorizationPolicies = ({ clientId }: PoliciesProps) => { - + {t("common:name")} {t("common:type")} {t("dependentPermission")} {t("common:description")} - + {policies.map((policy, rowIndex) => ( diff --git a/js/apps/admin-ui/src/clients/authorization/evaluate/Results.tsx b/js/apps/admin-ui/src/clients/authorization/evaluate/Results.tsx index e97fe19a77..dd5150aedc 100644 --- a/js/apps/admin-ui/src/clients/authorization/evaluate/Results.tsx +++ b/js/apps/admin-ui/src/clients/authorization/evaluate/Results.tsx @@ -148,11 +148,11 @@ export const Results = ({ evaluateResult, refresh, back }: ResultProps) => { - + {t("resource")} {t("overallResults")} {t("scopes")} - + {filteredResources.map((resource, rowIndex) => ( diff --git a/js/apps/admin-ui/src/clients/authorization/policy/ClientScope.tsx b/js/apps/admin-ui/src/clients/authorization/policy/ClientScope.tsx index e86923b7b2..3beb164b44 100644 --- a/js/apps/admin-ui/src/clients/authorization/policy/ClientScope.tsx +++ b/js/apps/admin-ui/src/clients/authorization/policy/ClientScope.tsx @@ -121,7 +121,7 @@ export const ClientScope = () => { {t("clientScope")} {t("required")} - + diff --git a/js/apps/admin-ui/src/clients/authorization/policy/Group.tsx b/js/apps/admin-ui/src/clients/authorization/policy/Group.tsx index faa26e3193..8369b34ab0 100644 --- a/js/apps/admin-ui/src/clients/authorization/policy/Group.tsx +++ b/js/apps/admin-ui/src/clients/authorization/policy/Group.tsx @@ -141,7 +141,7 @@ export const Group = () => { {t("groups")} {t("extendToChildren")} - + diff --git a/js/apps/admin-ui/src/clients/authorization/policy/Role.tsx b/js/apps/admin-ui/src/clients/authorization/policy/Role.tsx index d6bf28ae2c..61dcd0783c 100644 --- a/js/apps/admin-ui/src/clients/authorization/policy/Role.tsx +++ b/js/apps/admin-ui/src/clients/authorization/policy/Role.tsx @@ -117,7 +117,7 @@ export const Role = () => { {t("roles")} {t("required")} - + diff --git a/js/apps/admin-ui/src/realm-settings/user-profile/attribute/AttributeValidations.tsx b/js/apps/admin-ui/src/realm-settings/user-profile/attribute/AttributeValidations.tsx index da85326a0c..fb5edf69d3 100644 --- a/js/apps/admin-ui/src/realm-settings/user-profile/attribute/AttributeValidations.tsx +++ b/js/apps/admin-ui/src/realm-settings/user-profile/attribute/AttributeValidations.tsx @@ -101,7 +101,7 @@ export const AttributeValidations = () => { {t("validatorColNames.colName")} {t("validatorColNames.colConfig")} - + diff --git a/js/apps/admin-ui/src/user/UserConsents.tsx b/js/apps/admin-ui/src/user/UserConsents.tsx index 5e474fe82e..9f3891e30d 100644 --- a/js/apps/admin-ui/src/user/UserConsents.tsx +++ b/js/apps/admin-ui/src/user/UserConsents.tsx @@ -50,12 +50,7 @@ export const UserConsents = () => { return ( {grantedClientScopes!.map((currentChip) => ( - + {currentChip} ))} diff --git a/js/apps/admin-ui/src/user/UserCredentials.tsx b/js/apps/admin-ui/src/user/UserCredentials.tsx index fa03c52334..355688e5b4 100644 --- a/js/apps/admin-ui/src/user/UserCredentials.tsx +++ b/js/apps/admin-ui/src/user/UserCredentials.tsx @@ -405,12 +405,12 @@ export const UserCredentials = ({ user }: UserCredentialsProps) => { fieldLabelId="users:userCredentialsHelpTextLabel" /> - + {t("type")} {t("userLabel")} {t("data")} - - + + { {t("type")} {t("providedBy")} - + diff --git a/js/apps/admin-ui/src/user/user-section.css b/js/apps/admin-ui/src/user/user-section.css index 4996c8cd8b..e071655125 100644 --- a/js/apps/admin-ui/src/user/user-section.css +++ b/js/apps/admin-ui/src/user/user-section.css @@ -46,10 +46,6 @@ button#kc-join-groups-button { margin-right: 0px; } -#consents-chip-text.pf-c-chip-text { - font-size: var(--pf-c-table--cell--FontSize); -} - .kc-consents-chip > .pf-c-chip__text { font-size: var(--pf-c-table--cell--FontSize); max-width: 100%;