libre.sh/scimserviceprovider
2
0
Fork 0
Code Issues 10 Pull requests Projects Releases Packages Wiki Activity Actions

Move auth_type and jwt.secret out of config file #9

New issue
Open
opened 2023-03-03 10:46:01 +00:00 by rawtaz · 0 comments
rawtaz commented 2023-03-03 10:46:01 +00:00 (Migrated from lab.libreho.st)
Copy link

Currently there is a lib/Config/config.php file in which one configures the settings auth_type and optionally also jwt with a subsetting of secret.

Having this in a version controlled config file like this is messy to deal with, in particular during development. I propose that we move these (and other settings) into a simple form in the additional section (no need for our own custom Section, as it is just two small form fields) of the Settings view in Nextcloud, and then also store these settings in the app's configuration.

Currently there is a `lib/Config/config.php` file in which one configures the settings `auth_type` and optionally also `jwt` with a subsetting of `secret`. Having this in a version controlled config file like this is messy to deal with, in particular during development. I propose that we move these (and other settings) into [a simple form](https://docs.nextcloud.com/server/24/developer_manual/digging_deeper/settings.html#settings-form) in [the `additional` section](https://docs.nextcloud.com/server/24/developer_manual/digging_deeper/settings.html#section) (no need for our own custom Section, as it is just two small form fields) of the Settings view in Nextcloud, and then also store these settings in the [app's configuration](https://nextcloud-server.netlify.app/classes/ocp-iconfig#method_setAppValue).
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/ci
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: libre.sh/scimserviceprovider#9
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?