* Initial version of the create and edit resouce screen
* refactored and fixed the attributes form
introduced a new component that can be used more easily
* Update src/components/json-file-upload/FileUploadForm.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* Update src/components/attribute-form/attribute-convert.ts
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* Update src/clients/authorization/ResourceDetails.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* Update src/clients/authorization/ResourceDetails.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* Update src/clients/authorization/ResourceDetails.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* PR review
* fixed tests
* PR review comments
* resourceId is optional
* Update src/components/attribute-form/attribute-convert.ts
Co-authored-by: Jon Koops <jonkoops@gmail.com>
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* wip client roles select field
WIP multivalued roles component
wip client roles select: multivalued rows component
wip client roles select
role multi select is working :)
update client roles select to use multivalued select as per new design
delete comments
remove unused css
update cypress tests
revert to original
remove duplicates
add isCreateable
* PR feedback
* small refactor
* change to use orderBy
* use localeCompare
* fix tests
Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
add client policy tests
checkout realm settings test from master
RealmSettingsPage.ts master
remove comment and add missing translation
fix tests
PR feedback from Jon and Erik
rebase
editClientPolicy
edit client policy
add client policy conditions form
fix bug in create form
remove comment
update help text
fixes
breadcrumbs
add support for adding multiple conditions, deleting conditions, and list conditions in data table
clean up names
add delete functionality to conditions form
PR feedback from Jon
useMemo for conditions
remove comments and logs
remove unused hook
PR feedback from Jon
messages
rename message
rebase
remove duplicate value
fixed multi select bug
conditionConfigs wip
add all config fields, labels, and help text for condition types
wip config POST
config post is working
fix bug in multiline string POST
fix any client empty config
client scopes config wip
fix config settings for client-updater-context
fix client access type config
clean up configuration conditionals
add aria label to resolve critical axe issue
Apply suggestions from code review
Co-authored-by: Jon Koops <jonkoops@gmail.com>
address PR feedback from Jon
fix undef error
wip edit condition configs
fix import
wip edit configs
wip edit condition configs
populate all multiline input fields with data from server
update functionality
condition configs done
update route and delete comment
fix client updater context
add tests
add test for editing condition
remove comment
fix test
unskip tests
need optional chain for cypress test
fix breadcrumb
* moved to component folder
* replaced iteration with component
* fixed merge error
* renamed file
* tried to improve the test
* made field label lower case
add client policy tests
checkout realm settings test from master
RealmSettingsPage.ts master
remove comment and add missing translation
fix tests
PR feedback from Jon and Erik
rebase
editClientPolicy
edit client policy
add client policy conditions form
fix bug in create form
remove comment
update help text
fixes
breadcrumbs
add support for adding multiple conditions, deleting conditions, and list conditions in data table
clean up names
add delete functionality to conditions form
PR feedback from Jon
useMemo for conditions
remove comments and logs
remove unused hook
add profiles modal wip
addprofiles wip
profiles wip
help text wip
add help text
remove comments
remove duplicate message
update data test id
PR feedback from Jon 1
Apply suggestions from code review
Co-authored-by: Jon Koops <jonkoops@gmail.com>
remove fragment
create policy detail attribute type
PR feedback from Jon 2
support editing profile name and description
add edit functionality and restore tests
Delete EditCondition.ts
Apply suggestions from code review
Co-authored-by: Jon Koops <jonkoops@gmail.com>
format
fix path
use route fn
* add create client policy form; WIP
add client policy tests
checkout realm settings test from master
RealmSettingsPage.ts master
remove comment and add missing translation
fix tests
PR feedback from Jon and Erik
rebase
editClientPolicy
edit client policy
add client policy conditions form
fix bug in create form
remove comment
update help text
fixes
breadcrumbs
add support for adding multiple conditions, deleting conditions, and list conditions in data table
clean up names
add delete functionality to conditions form
PR feedback from Jon
useMemo for conditions
remove comments and logs
remove unused hook
PR feedback from Jon
messages
rename message
rebase
remove duplicate value
fixed multi select bug
conditionConfigs wip
add all config fields, labels, and help text for condition types
wip config POST
config post is working
fix bug in multiline string POST
fix any client empty config
client scopes config wip
fix config settings for client-updater-context
fix client access type config
clean up configuration conditionals
add aria label to resolve critical axe issue
Apply suggestions from code review
Co-authored-by: Jon Koops <jonkoops@gmail.com>
address PR feedback from Jon
fix undef error
PR feedback from Stan
add util function
* fix import stmt
* revert change to route
* fix profile create values
* fix paths
* add create client policy form; WIP
add client policy tests
checkout realm settings test from master
RealmSettingsPage.ts master
remove comment and add missing translation
fix tests
PR feedback from Jon and Erik
rebase
editClientPolicy
edit client policy
add client policy conditions form
fix bug in create form
remove comment
update help text
fixes
breadcrumbs
add support for adding multiple conditions, deleting conditions, and list conditions in data table
clean up names
add delete functionality to conditions form
PR feedback from Jon
useMemo for conditions
remove comments and logs
remove unused hook
add profiles modal wip
addprofiles wip
profiles wip
help text wip
add help text
remove comments
remove duplicate message
update data test id
PR feedback from Jon 1
Apply suggestions from code review
Co-authored-by: Jon Koops <jonkoops@gmail.com>
remove fragment
create policy detail attribute type
* PR feedback from Jon 1
* PR feedback from Jon 2
* add spinner to prevent loader from being called
* remove duplicate identifier
* fix and rename route
* rename route
* add create client policy form; WIP
add client policy tests
checkout realm settings test from master
RealmSettingsPage.ts master
remove comment and add missing translation
fix tests
PR feedback from Jon and Erik
rebase
editClientPolicy
edit client policy
add client policy conditions form
fix bug in create form
remove comment
update help text
fixes
breadcrumbs
add support for adding multiple conditions, deleting conditions, and list conditions in data table
clean up names
add delete functionality to conditions form
PR feedback from Jon
useMemo for conditions
remove comments and logs
remove unused hook
PR feedback from Jon
messages
rename message
rebase
* remove duplicate value
* fixed multi select bug
add client policy tests
checkout realm settings test from master
RealmSettingsPage.ts master
remove comment and add missing translation
fix tests
PR feedback from Jon and Erik
rebase
update test file
replace hardcoded URL with path
fix tests
correct tab name
fix duplicates test
add create client policy form; WIP
add client policy tests
tests
createClientPolicyFormTests
lint
tests
remove comments
comment out json test
add empty state test
check reloading json policies
client policy tests are passing
all client policy tests passing locally
* add create client policy form; WIP
add client policy tests
checkout realm settings test from master
RealmSettingsPage.ts master
remove comment and add missing translation
fix tests
PR feedback from Jon and Erik
* rebase
* replace hardcoded URL with path
* fix tests
* editClientPolicy
* edit client policy
* rename test
* feedback from jon
* add create client policy form; WIP
add client policy tests
checkout realm settings test from master
RealmSettingsPage.ts master
remove comment and add missing translation
fix tests
PR feedback from Jon and Erik
* rebase
* update test file
* replace hardcoded URL with path
* fix tests
* correct tab name
* fix duplicates test
* client-add-executors: wip
* client-add-executors: added logic for deleting client from dropdown
* client-add-executors: wip
* client-add-executors: added edit profiles
* client-add-executors: added refesh client profiles
* client-add-executors: added cypress tests
* commented out test failing only in CI
* Update cypress/integration/realm_settings_test.spec.ts
Co-authored-by: Erik Jan de Wit <edewit@redhat.com>
* changed to arrow functions
* feedback fixes
* feedback fixes
* uncommented failing test to see if still failing and why
* test possible fix
* test fix
* test fix
* test fix
* client-add-executors: reused normaliseProfile func for delete dialog
Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Co-authored-by: Erik Jan de Wit <edewit@redhat.com>
* fix login tab
update cypress test
cypress test
rebase
test updates
cypress test fix
get correct ids
fix get call
fix tests
try refetching realm
add useEffect to fix server GET call
uncomment test
revert to original useFetch
prettier
create new function
set timeout to 10 ms
set to 100 ms
* add comment to useEffect per Jon feedback
* added user role mapping tab to user details
* fix imports to admin client
* Update src/user/UserRoleMapping.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* Update src/user/UserRoleMapping.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* added await
* fixed merge error
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* fix conflict
* pr feedback from jon
* add key provider type to separate component
* remove log stmt
* remove spread syntax
* add default priority to all provider types
* remove sort by priority from providers tab
* add instruction tooltip
* correct list sorting order
* feedback from Jon wip
* more feedback from Jon
* update aria-describedby
* data list header and draggable button spacing
* Update src/realm-settings/RealmSettingsSection.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* add localization dropdown
uncomment isDisabled
clean up names
comment out localization tab again
disable actions menu if form not submitted
uncomment tab
use currentRealm for tableLoader
fix axe issues labeled as serious
PR feedback from Erik
use isSearching instead of keepToolbar
* fix node build
* use object entries
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* initial version of create authentication screen
* initial version of authentication details
* added flow details labels to view header
* not in use fix
* create execution tree
* fixed collapsable row layout
* fix drag and drop expand
* fix merge error
* move to modal
* diff and post drag and drop changes
* fixed locating the parent row
* move "live text" for d&d to common messages
* firefox fix
* initial version of the diagram
* use dagre to layout automatically
* moved to sperate file
* conditional node
* now renders subflows sequential
* changed to render sequential or parallel flows
* fixed render of sub flows
* added button edge, drawer and selectable nodes
* add requirement dropdown
* also do move so we can merge
* also do move so we can merge
* fixed merge
* added refresh
* change requirement
* fixed merge error
* now uses the new routes
* Split out routes into multiple files
* Update src/authentication/AuthenticationSection.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* Update src/authentication/FlowDetails.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* Update src/authentication/FlowDetails.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* Update src/authentication/FlowDetails.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* Update src/authentication/FlowDetails.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* fixed labels
* merge fix
* make execution of these parrallel
* added some tests
* Update src/authentication/components/FlowRequirementDropdown.tsx
Co-authored-by: Jon Koops <jonkoops@gmail.com>
* more review changes
* fixed merge error
Co-authored-by: Jon Koops <jonkoops@gmail.com>
author jenny-s51 <jshandel@redhat.com> 1624022352 -0400
committer jenny-s51 <jshandel@redhat.com> 1625159705 -0400
wip provider details
provider details wip
move files wip
wip
wip all provider details
remove controllers
save and update working
address console warnings
remove log stmt
update test
keep aes only
remove comments
remove unused hook and function
remove unused props
revert ldap logs
fix conflict and remove duplicate function
format and cypress test
Partial import phase 2 (#702)
* Process the JSON and present user options
* Finish checkboxes. Refactor.
* Add tests
* Refactor after rebase
* Add more test data for manual testing.
* Fix linting errors
* Put JsonFileUpload back the way it was.
* Clean up comments
* Update src/realm-settings/PartialImport.tsx
Remove comment
Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
Localization tab (#685)
* localization wip
wip localization
return key value data as array
localization table
css
lint
lint
clean up log stmts
clean up log stmts
* PR feedback from Erik
* fix logic for supported locales
* update empty state text
* set default value
* fix cypress test
* Update src/realm-settings/RealmSettingsSection.tsx
Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
* fix rsa-generated delete bug; PR feedback frog Erik
* revert locale abbreviation
* remove log stmts
* PR feedback from Erik, fix undefined
* fix loader w Erik
Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
add divider on section
Prepare for first alpha release (#711)
use typeahead for mapper list
fix test
Default roles: UI Changes from KEYCLOAK-14846 (#693)
* defaultRoles wip
default role changes done
clean up log stmts
update snapshot
fix masthead test
* fix cypress test
* fix tabs
Comment out Realm role CRUD test (#712)
* Bogus change
* Bogus change
* Comment out Realm role CRUD test
Bump postcss-cli from 7.1.1 to 8.3.1 (#718)
Bumps [postcss-cli](https://github.com/postcss/postcss-cli) from 7.1.1 to 8.3.1.
- [Release notes](https://github.com/postcss/postcss-cli/releases)
- [Changelog](https://github.com/postcss/postcss-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss-cli/compare/7.1.1...8.3.1)
---
updated-dependencies:
- dependency-name: postcss-cli
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bump @testing-library/jest-dom from 5.12.0 to 5.14.1 (#717)
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.12.0 to 5.14.1.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/jest-dom/compare/v5.12.0...v5.14.1)
---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fixing issue (#709)
* fixing issue
fixing: #680
* added kebab on row
* added more clear group seperation
Bump cypress from 7.4.0 to 7.5.0 (#715)
Bump @babel/preset-typescript from 7.13.0 to 7.14.5 (#714)
Bumps [@babel/preset-typescript](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript) from 7.13.0 to 7.14.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.5/packages/babel-preset-typescript)
---
updated-dependencies:
- dependency-name: "@babel/preset-typescript"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bump @testing-library/react from 10.4.6 to 11.2.7 (#716)
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.6 to 11.2.7.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/react-testing-library/compare/v10.4.6...v11.2.7)
---
updated-dependencies:
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
inherited roles disabled instead of non selectable
more style fixes
fixed size
change title of tab
add unassign kebab on row
added help item on enable switch
test email working, modal wip
email connection done
remove comment
fix cypress test
revert test file
fdisable email prompting when user email entered
prettier
update cypress tests
fix lint
try fix cypress test
try longer wait
save and test connection
make wait longer
increase wait
fix test
disable test connection button if form fields not entered
lint
afix username/password fields
fix test
mark suggested change
add modal button and input functions
fixed default value warning
fixing issue
fixing: #650
remove provider form
add delete cleanup function
AESproviderDetails extend wait for video
update test
test wait after
rebase
remove comments
remove log
format
format
PR feedback from Jon
Apply suggestions from Jon's code review
Co-authored-by: Jon Koops <jonkoops@gmail.com>
remove duplicate form
form
use array desctructuring
Apply suggestions from code review
Co-authored-by: Jon Koops <jonkoops@gmail.com>
update useroutematch
format
format
back to async
pretty
cypress test
remove email verification switch toggle
fix add provider on non-master realm
cleaning up
fix save
fix save for other providers
fix fetch
fix runtime error
remove unused import
Apply suggestions from code review
suggested changes for non-null assertions
Co-authored-by: Jon Koops <jonkoops@gmail.com>
make props required
make provider type required
use realm-settings file for translation
format and roll back route changes
* wip provider details
provider details wip
move files wip
wip
wip all provider details
remove controllers
save and update working
address console warnings
remove log stmt
update test
keep aes only
remove comments
remove unused hook and function
remove unused props
revert ldap logs
fix conflict and remove duplicate function
Partial import phase 2 (#702)
* Process the JSON and present user options
* Finish checkboxes. Refactor.
* Add tests
* Refactor after rebase
* Add more test data for manual testing.
* Fix linting errors
* Put JsonFileUpload back the way it was.
* Clean up comments
* Update src/realm-settings/PartialImport.tsx
Remove comment
Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
Fixing UXD review for user (#648)
* Introduced new GroupPicker.
Can be used for move group or join group
* Moved help texts to help.json
* don't set state when there was no request
* add pagination
* remove "Groups" link on root level
* use path in chip instread of name
* fixes filtering to show search not found
and removes `+1` logic from pager
* fix breadcrumb and layout
* fixed all the tests
Localization tab (#685)
* localization wip
wip localization
return key value data as array
localization table
css
lint
lint
clean up log stmts
clean up log stmts
* PR feedback from Erik
* fix logic for supported locales
* update empty state text
* set default value
* fix cypress test
* Update src/realm-settings/RealmSettingsSection.tsx
Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
* fix rsa-generated delete bug; PR feedback frog Erik
* revert locale abbreviation
* remove log stmts
* PR feedback from Erik, fix undefined
* fix loader w Erik
Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
add divider on section
Prepare for first alpha release (#711)
use typeahead for mapper list
fix test
Default roles: UI Changes from KEYCLOAK-14846 (#693)
* defaultRoles wip
default role changes done
clean up log stmts
update snapshot
fix masthead test
* fix cypress test
* fix tabs
Comment out Realm role CRUD test (#712)
* Bogus change
* Bogus change
* Comment out Realm role CRUD test
Bump postcss-cli from 7.1.1 to 8.3.1 (#718)
Bumps [postcss-cli](https://github.com/postcss/postcss-cli) from 7.1.1 to 8.3.1.
- [Release notes](https://github.com/postcss/postcss-cli/releases)
- [Changelog](https://github.com/postcss/postcss-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss-cli/compare/7.1.1...8.3.1)
---
updated-dependencies:
- dependency-name: postcss-cli
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bump @testing-library/jest-dom from 5.12.0 to 5.14.1 (#717)
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.12.0 to 5.14.1.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/jest-dom/compare/v5.12.0...v5.14.1)
---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fixing issue (#709)
* fixing issue
fixing: #680
* added kebab on row
* added more clear group seperation
Bump cypress from 7.4.0 to 7.5.0 (#715)
Bump @babel/preset-typescript from 7.13.0 to 7.14.5 (#714)
Bumps [@babel/preset-typescript](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript) from 7.13.0 to 7.14.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.5/packages/babel-preset-typescript)
---
updated-dependencies:
- dependency-name: "@babel/preset-typescript"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bump @testing-library/react from 10.4.6 to 11.2.7 (#716)
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.6 to 11.2.7.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/react-testing-library/compare/v10.4.6...v11.2.7)
---
updated-dependencies:
- dependency-name: "@testing-library/react"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
inherited roles disabled instead of non selectable
more style fixes
fixed size
change title of tab
add unassign kebab on row
added help item on enable switch
test email working, modal wip
email connection done
remove comment
fix cypress test
revert test file
fdisable email prompting when user email entered
prettier
update cypress tests
fix lint
try fix cypress test
try longer wait
save and test connection
make wait longer
increase wait
fix test
disable test connection button if form fields not entered
lint
afix username/password fields
fix test
mark suggested change
add modal button and input functions
fixed default value warning
fixing issue
fixing: #650
updated admin client with new endpoints (#725)
fix add function and add test
remove aes provider changes
remove comments
format
update cypress test
update add bundle function
fix test
remove comment
* remove merge conflict markers
* more markers
* format
* localization wip
wip localization
return key value data as array
localization table
css
lint
lint
clean up log stmts
clean up log stmts
* PR feedback from Erik
* fix logic for supported locales
* update empty state text
* set default value
* fix cypress test
* Update src/realm-settings/RealmSettingsSection.tsx
Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
* fix rsa-generated delete bug; PR feedback frog Erik
* revert locale abbreviation
* remove log stmts
* PR feedback from Erik, fix undefined
* fix loader w Erik
Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
* Introduced new GroupPicker.
Can be used for move group or join group
* Moved help texts to help.json
* don't set state when there was no request
* add pagination
* remove "Groups" link on root level
* use path in chip instread of name
* fixes filtering to show search not found
and removes `+1` logic from pager
* fix breadcrumb and layout
* fixed all the tests
