libre.sh/keycloak-scim
2
0
Fork 0
Code Issues 14 Pull requests Releases Packages Activity Actions 6

small refactor (#484)

Browse source
This commit is contained in:
Erik Jan de Wit 2021-03-31 21:08:56 +02:00 committed by GitHub
parent 6102770fbf
commit f1a658da01
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/realm-roles/AssociatedRolesTab.tsx
View file

@ -89,16 +89,9 @@ export const AssociatedRolesTab = ({
return _.sortBy(rolesList, (role) => role.name?.toUpperCase());
};
const loader = async (first?: number, max?: number, search?: string) => {
const loader = async () => {
if (isInheritedHidden) {
const filteredRoles = additionalRoles.filter(
(role) =>
!search ||
role.name?.toLowerCase().includes(search) ||
role.description?.toLowerCase().includes(search)
);
const roles = alphabetize(filteredRoles);
return roles;
return alphabetize(additionalRoles);
}
const fetchedRoles: Promise<RoleRepresentation[]> = additionalRoles.reduce(
@ -113,14 +106,7 @@ export const AssociatedRolesTab = ({
);
return fetchedRoles.then((results: RoleRepresentation[]) => {
const filteredRoles = results.filter(
(role) =>
!search ||
role.name?.toLowerCase().includes(search) ||
role.description?.toLowerCase().includes(search)
);
const roles = alphabetize(filteredRoles);
return roles;
return alphabetize(results);
});
};
@ -205,7 +191,6 @@ export const AssociatedRolesTab = ({
<KeycloakDataTable
key={key}
loader={loader}
isPaginated
ariaLabelKey="roles:roleList"
searchPlaceholderKey="roles:searchFor"
canSelectAll
@ -280,8 +265,8 @@ export const AssociatedRolesTab = ({
emptyState={
<ListEmptyState
hasIcon={true}
message={t("noRolesInThisRealm")}
instructions={t("noRolesInThisRealmInstructions")}
message={t("noRoles")}
instructions={t("noRolesInstructions")}
primaryActionText={t("createRole")}
onPrimaryAction={goToCreate}
/>