From ef4d973a678541690f2702611f5f6ae26cb2e25b Mon Sep 17 00:00:00 2001
From: Jon Koops <jonkoops@gmail.com>
Date: Wed, 13 Oct 2021 00:15:19 +0200
Subject: [PATCH] Add missing artifact fields to SAML endpoint configuration
 (#1328)

---
 .../advanced/FineGrainSamlEndpointConfig.tsx  | 54 +++++++++++++++++++
 src/clients/help.ts                           |  6 +++
 src/clients/messages.ts                       |  3 ++
 3 files changed, 63 insertions(+)

diff --git a/src/clients/advanced/FineGrainSamlEndpointConfig.tsx b/src/clients/advanced/FineGrainSamlEndpointConfig.tsx
index a585bf81b5..589253d883 100644
--- a/src/clients/advanced/FineGrainSamlEndpointConfig.tsx
+++ b/src/clients/advanced/FineGrainSamlEndpointConfig.tsx
@@ -97,6 +97,60 @@ export const FineGrainSamlEndpointConfig = ({
           name="attributes.saml_single_logout_service_url_redirect"
         />
       </FormGroup>
+      <FormGroup
+        label={t("logoutServiceArtifactBindingUrl")}
+        fieldId="logoutServiceArtifactBindingUrl"
+        labelIcon={
+          <HelpItem
+            helpText="clients-help:logoutServiceArtifactBindingUrl"
+            forLabel={t("logoutServiceArtifactBindingUrl")}
+            forID="logoutServiceArtifactBindingUrl"
+          />
+        }
+      >
+        <TextInput
+          ref={register()}
+          type="text"
+          id="logoutServiceArtifactBindingUrl"
+          name="attributes.saml_single_logout_service_url_redirect"
+        />
+      </FormGroup>
+      <FormGroup
+        label={t("artifactBindingUrl")}
+        fieldId="artifactBindingUrl"
+        labelIcon={
+          <HelpItem
+            helpText="clients-help:artifactBindingUrl"
+            forLabel={t("artifactBindingUrl")}
+            forID="artifactBindingUrl"
+          />
+        }
+      >
+        <TextInput
+          ref={register()}
+          type="text"
+          id="artifactBindingUrl"
+          name="attributes.saml_artifact_binding_url"
+        />
+      </FormGroup>
+      <FormGroup
+        label={t("artifactResolutionService")}
+        fieldId="artifactResolutionService"
+        labelIcon={
+          <HelpItem
+            helpText="clients-help:artifactResolutionService"
+            forLabel={t("artifactResolutionService")}
+            forID="artifactResolutionService"
+          />
+        }
+      >
+        <TextInput
+          ref={register()}
+          type="text"
+          id="artifactResolutionService"
+          name="attributes.saml_artifact_resolution_service_url"
+        />
+      </FormGroup>
 
       <ActionGroup>
         <Button variant="tertiary" onClick={save}>
diff --git a/src/clients/help.ts b/src/clients/help.ts
index 33f488d629..88ac4bc800 100644
--- a/src/clients/help.ts
+++ b/src/clients/help.ts
@@ -127,6 +127,12 @@ export default {
       "SAML POST Binding URL for the client's single logout service. You can leave this blank if you are using a different binding",
     logoutServiceRedirectBindingURL:
       "SAML Redirect Binding URL for the client's single logout service. You can leave this blank if you are using a different binding.",
+    logoutServiceArtifactBindingUrl:
+      "SAML ARTIFACT Binding URL for the client's single logout service. You can leave this blank if you are using a different binding.",
+    artifactBindingUrl:
+      "URL to send the HTTP ARTIFACT messages to. You can leave this blank if you are using a different binding. This value should be set when forcing ARTIFACT binding together with IdP initiated login.",
+    artifactResolutionService:
+      "SAML Artifact resolution service for the client. This is the endpoint to which Keycloak will send a SOAP ArtifactResolve message. You can leave this blank if you do not have a URL for this binding.",
     authenticationOverrides: "Override realm authentication flow bindings.",
     browserFlow: "Select the flow you want to use for browser authentication.",
     directGrant:
diff --git a/src/clients/messages.ts b/src/clients/messages.ts
index 7b43e82464..6e2d6a62e9 100644
--- a/src/clients/messages.ts
+++ b/src/clients/messages.ts
@@ -259,6 +259,9 @@ export default {
       "Assertion Consumer Service Redirect Binding URL",
     logoutServicePostBindingURL: "Logout Service POST Binding URL",
     logoutServiceRedirectBindingURL: "Logout Service Redirect Binding URL",
+    logoutServiceArtifactBindingUrl: "Logout Service ARTIFACT Binding URL",
+    artifactBindingUrl: "Artifact Binding URL",
+    artifactResolutionService: "Artifact Resolution Service",
     advancedSettings: "Advanced Settings",
     assertionLifespan: "Assertion Lifespan",
     accessTokenLifespan: "Access Token Lifespan",