address PR feedback from Erik, remove user ID per Haley feedback

cypress/integration/realm_roles_test.spec.ts

@@ -107,8 +107,8 @@ describe("Realm roles test", function () {
 
       cy.contains("Users in role")
         .click()
-        .get("#users-empty-state > div > h4")
+        .get('[data-test-id="users-page"]')
-        .contains("No direct users");
+        .should('exist')
     });
   });
 });

src/components/list-empty-state/ListEmptyState.tsx

@@ -18,7 +18,6 @@ export type Action = {
 };
 
 export type ListEmptyStateProps = {
-  id?: string;
   message: string;
   instructions: string;
   primaryActionText?: string;
@@ -29,7 +28,6 @@ export type ListEmptyStateProps = {
 };
 
 export const ListEmptyState = ({
-  id,
   message,
   instructions,
   onPrimaryAction,
@@ -40,7 +38,7 @@ export const ListEmptyState = ({
 }: ListEmptyStateProps) => {
   return (
     <>
-      <EmptyState id={id} variant="large">
+      <EmptyState variant="large">
         {hasIcon && isSearchVariant ? (
           <EmptyStateIcon icon={SearchIcon} />
         ) : (

src/realm-roles/UsersInRoleTab.tsx

@@ -32,13 +32,12 @@ export const UsersInRoleTab = () => {
 
   return (
     <>
-      <PageSection variant="light">
+      <PageSection data-test-id="users-page" variant="light">
         {users.length == 0 ? (
           <ListEmptyState
             hasIcon={true}
             message={t("noDirectUsers")}
             instructions={t("noUsersEmptyStateDescription")}
-            id="users-empty-state"
           />
         ) : (
           <KeycloakDataTable