Enabled more tests (#2399)

This commit is contained in:
Erik Jan de Wit 2022-04-08 10:56:20 +02:00 committed by GitHub
parent 2d1baed0e9
commit e681dbae4a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 3 deletions

View file

@ -7,7 +7,7 @@ import SidebarPage from "../support/pages/admin_console/SidebarPage";
import AuthorizationTab from "../support/pages/admin_console/manage/clients/AuthorizationTab"; import AuthorizationTab from "../support/pages/admin_console/manage/clients/AuthorizationTab";
import ModalUtils from "../support/util/ModalUtils"; import ModalUtils from "../support/util/ModalUtils";
describe.skip("Client authentication subtab", () => { describe("Client authentication subtab", () => {
const loginPage = new LoginPage(); const loginPage = new LoginPage();
const listingPage = new ListingPage(); const listingPage = new ListingPage();
const masthead = new Masthead(); const masthead = new Masthead();
@ -56,6 +56,7 @@ describe.skip("Client authentication subtab", () => {
.save(); .save();
masthead.checkNotificationMessage("Resource created successfully", true); masthead.checkNotificationMessage("Resource created successfully", true);
sidebarPage.waitForPageLoad();
authenticationTab.cancel(); authenticationTab.cancel();
}); });
@ -96,6 +97,7 @@ describe.skip("Client authentication subtab", () => {
cy.wait(["@get"]); cy.wait(["@get"]);
masthead.checkNotificationMessage("Successfully created the policy", true); masthead.checkNotificationMessage("Successfully created the policy", true);
sidebarPage.waitForPageLoad();
authenticationTab.cancel(); authenticationTab.cancel();
}); });
@ -124,6 +126,7 @@ describe.skip("Client authentication subtab", () => {
cy.wait(["@get"]); cy.wait(["@get"]);
masthead.checkNotificationMessage("Successfully created the policy", true); masthead.checkNotificationMessage("Successfully created the policy", true);
sidebarPage.waitForPageLoad();
authenticationTab.cancel(); authenticationTab.cancel();
}); });
@ -146,17 +149,20 @@ describe.skip("Client authentication subtab", () => {
true true
); );
cy.wait(["@load"]); cy.wait(["@load"]);
sidebarPage.waitForPageLoad();
authenticationTab.cancel(); authenticationTab.cancel();
}); });
it("Should copy auth details", () => { it.skip("Should copy auth details", () => {
authenticationTab.goToExportSubTab(); authenticationTab.goToExportSubTab();
sidebarPage.waitForPageLoad();
authenticationTab.copy(); authenticationTab.copy();
masthead.checkNotificationMessage("Authorization details copied.", true); masthead.checkNotificationMessage("Authorization details copied.", true);
}); });
it("Should export auth details", () => { it("Should export auth details", () => {
authenticationTab.goToExportSubTab(); authenticationTab.goToExportSubTab();
sidebarPage.waitForPageLoad();
authenticationTab.export(); authenticationTab.export();
masthead.checkNotificationMessage( masthead.checkNotificationMessage(

View file

@ -33,6 +33,7 @@ import { ResourcesPolicySelect } from "./ResourcesPolicySelect";
import { toAuthorizationTab } from "../routes/AuthenticationTab"; import { toAuthorizationTab } from "../routes/AuthenticationTab";
import { ScopeSelect } from "./ScopeSelect"; import { ScopeSelect } from "./ScopeSelect";
import { toUpperCase } from "../../util"; import { toUpperCase } from "../../util";
import { KeycloakSpinner } from "../../components/keycloak-spinner/KeycloakSpinner";
const DECISION_STRATEGIES = ["UNANIMOUS", "AFFIRMATIVE", "CONSENSUS"] as const; const DECISION_STRATEGIES = ["UNANIMOUS", "AFFIRMATIVE", "CONSENSUS"] as const;
@ -163,13 +164,17 @@ export default function PermissionDetails() {
defaultValue: [], defaultValue: [],
}); });
if (!permission) {
return <KeycloakSpinner />;
}
return ( return (
<> <>
<DeleteConfirm /> <DeleteConfirm />
<ViewHeader <ViewHeader
titleKey={ titleKey={
permissionId permissionId
? permission?.name! ? permission.name!
: `clients:create${toUpperCase(permissionType)}BasedPermission` : `clients:create${toUpperCase(permissionType)}BasedPermission`
} }
dropdownItems={ dropdownItems={