From e2d7a94459481016624d72aea3cf39bcaffb4521 Mon Sep 17 00:00:00 2001 From: Erik Jan de Wit Date: Wed, 21 Aug 2024 08:05:12 +0200 Subject: [PATCH] Hynek's notes Signed-off-by: Erik Jan de Wit --- .../org/keycloak/testsuite/error/UncaughtErrorPageTest.java | 4 +--- .../java/org/keycloak/testsuite/forms/ThemeSelectorTest.java | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/error/UncaughtErrorPageTest.java b/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/error/UncaughtErrorPageTest.java index 2b03c2f0e3..ae21990e1c 100644 --- a/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/error/UncaughtErrorPageTest.java +++ b/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/error/UncaughtErrorPageTest.java @@ -223,9 +223,7 @@ public class UncaughtErrorPageTest extends AbstractKeycloakTest { try { checkPageNotFound("/auth/realms/master/nosuch"); - // Once keycloak.v2 would be the default login theme, uncomment the following line and remove the one below: - // String url = driver.findElement(By.xpath("//option[text()[contains(.,'Deutsch')]]")).getAttribute("value"); - String url = driver.findElement(By.xpath("//a[text()[contains(.,'Deutsch')]]")).getAttribute("href"); + String url = driver.findElement(By.xpath("//option[text()[contains(.,'Deutsch')]]")).getAttribute("value"); driver.navigate().to(url); errorPage.assertCurrent(); } finally { diff --git a/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/forms/ThemeSelectorTest.java b/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/forms/ThemeSelectorTest.java index 3c8ba4023d..8994a96812 100644 --- a/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/forms/ThemeSelectorTest.java +++ b/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/forms/ThemeSelectorTest.java @@ -12,9 +12,7 @@ import static org.junit.Assert.assertEquals; public class ThemeSelectorTest extends AbstractTestRealmKeycloakTest { - // At this moment, the default login theme as defined in ThemeSelectorProvider is "keycloak". - // Once the ThemeSelectorProvider.DEFAULT_V2 becomes default, this needs to be reflected in this constant. - private static final String SYSTEM_DEFAULT_LOGIN_THEME = ThemeSelectorProvider.DEFAULT; + private static final String SYSTEM_DEFAULT_LOGIN_THEME = ThemeSelectorProvider.DEFAULT_V2; @Page protected LoginPage loginPage;