Add template for PRs (#173)

* add PR template

* fixed poor english copy paste

* add type checking rm todo

* rm storybook and verify checks
This commit is contained in:
mfrances17 2020-10-20 15:30:02 -04:00 committed by GitHub
parent b5aa560dcc
commit d4f2f5cd44
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

34
.github/pull_request_template.md vendored Normal file
View file

@ -0,0 +1,34 @@
## Motivation
<!-- Add references to relevant tickets, issues, design specs and/or a short description of what motivated you to do it. -->
## Brief Description
<!-- Add a short answer for:
What was done in this PR? (e.g Fix to prevent users from accessing feature X.)
Why it was done? (e.g Feature X was deprecated.)
-->
## Verification Steps
<!--
Add the steps required to verify this change. Keep in mind that these steps should be written so groups unfamiliar with the
new functionality can follow them, such as QE or documentation.
1. Go to `XX >> YY >> SS`.
2. Create a new item `N` with info `X`.
3. Right-click the item and select Delete.
4. Verify that the item is no longer present in the left navigation menu.
-->
## Checklist:
- [ ] Code has been tested locally by PR requester
- [ ] User-visible strings are using the react-i18next framework (useTranslation)
- [ ] Help has been implemented
- [ ] axe report has been run and resulting a11y issues have been resolved
- [ ] Unit tests have been created/updated
- [ ] Formatting has been performed via prettier/eslint
- [ ] Type checking has been performed via 'yarn check-types'
## Additional Notes
<!--
Add images and/or screen caps to illustrate what was changed if this pull request adds to or modifies existing user-visible appearance/output.
-->