From cfe83c769b60ed7690397bdca02309713713f036 Mon Sep 17 00:00:00 2001
From: Jon Koops <jonkoops@gmail.com>
Date: Tue, 28 Sep 2021 14:09:27 +0200
Subject: [PATCH] Show a tooltip to explain bearer-only clients (#1244)

---
 src/clients/ClientDetails.tsx | 29 ++++++++++++++++++++++++++---
 src/clients/messages.ts       |  2 ++
 2 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/src/clients/ClientDetails.tsx b/src/clients/ClientDetails.tsx
index 274905ee18..abafb183e4 100644
--- a/src/clients/ClientDetails.tsx
+++ b/src/clients/ClientDetails.tsx
@@ -4,15 +4,18 @@ import {
   ButtonVariant,
   Divider,
   DropdownItem,
+  Label,
   PageSection,
   Spinner,
   Tab,
   Tabs,
   TabTitleText,
+  Tooltip,
 } from "@patternfly/react-core";
+import { InfoCircleIcon } from "@patternfly/react-icons";
 import type ClientRepresentation from "@keycloak/keycloak-admin-client/lib/defs/clientRepresentation";
 import _ from "lodash";
-import React, { useState } from "react";
+import React, { useMemo, useState } from "react";
 import { Controller, FormProvider, useForm, useWatch } from "react-hook-form";
 import { useTranslation } from "react-i18next";
 import { useHistory, useParams } from "react-router-dom";
@@ -28,7 +31,10 @@ import {
   MultiLine,
   toValue,
 } from "../components/multi-line-input/MultiLineInput";
-import { ViewHeader } from "../components/view-header/ViewHeader";
+import {
+  ViewHeader,
+  ViewHeaderBadge,
+} from "../components/view-header/ViewHeader";
 import { useAdminClient, useFetch } from "../context/auth/AdminClient";
 import { useRealm } from "../context/realm-context/RealmContext";
 import { RolesList } from "../realm-roles/RolesList";
@@ -74,13 +80,30 @@ const ClientDetailHeader = ({
       save();
     },
   });
+
+  const badges = useMemo<ViewHeaderBadge[]>(() => {
+    if (!client.protocol) {
+      return [];
+    }
+
+    const text = client.bearerOnly ? (
+      <Tooltip content={t("explainBearerOnly")}>
+        <Label icon={<InfoCircleIcon />}>{client.protocol}</Label>
+      </Tooltip>
+    ) : (
+      <Label>{client.protocol}</Label>
+    );
+
+    return [{ text }];
+  }, [client]);
+
   return (
     <>
       <DisableConfirm />
       <ViewHeader
         titleKey={client ? client.clientId! : ""}
         subKey="clients:clientsExplain"
-        badges={[{ text: client.protocol }]}
+        badges={badges}
         divider={false}
         helpTextKey="clients-help:enableDisable"
         dropdownItems={[
diff --git a/src/clients/messages.ts b/src/clients/messages.ts
index 86f87ec7b5..fe38b80269 100644
--- a/src/clients/messages.ts
+++ b/src/clients/messages.ts
@@ -71,6 +71,8 @@ export default {
     capabilityConfig: "Capability config",
     clientsExplain:
       "Clients are applications and services that can request authentication of a user",
+    explainBearerOnly:
+      "This is a special OIDC type. This client only allows bearer token requests and cannot participate in browser logins.",
     createSuccess: "Client created successfully",
     createError: "Could not create client: '{{error}}'",
     clientImportError: "Could not import client: {{error}}",