libre.sh/keycloak-scim
4
0
Fork 0
Code Issues 15 Pull requests Releases 1 Activity Actions

Merge pull request #1777 from girirajsharma/keycloak-1993

Browse source 
[KEYCLOAK-1993] It's possible to create new authentication flow with empty name within another flow
This commit is contained in:
Stian Thorgersen 2015-11-09 09:54:07 +01:00
commit cd01ea49b4
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
forms/common-themes/src/main/resources/theme/base/admin/resources/partials/create-flow-execution.html
View file

@ -7,7 +7,7 @@
<div class="form-group"> <div class="form-group">
<label class="col-md-2 control-label" for="alias">Alias </label> <label class="col-md-2 control-label" for="alias">Alias </label>
<div class="col-sm-6"> <div class="col-sm-6">
<input class="form-control" type="text" id="alias" name="alias" data-ng-model="flow.alias" autofocus> <input class="form-control" type="text" id="alias" name="alias" data-ng-model="flow.alias" autofocus required>
</div> </div>
<kc-tooltip>Specifies display name for the flow.</kc-tooltip> <kc-tooltip>Specifies display name for the flow.</kc-tooltip>
</div> </div>

4
services/src/main/java/org/keycloak/services/resources/admin/AuthenticationManagementResource.java
View file

@ -277,6 +277,10 @@ public class AuthenticationManagementResource {
public Response createFlow(AuthenticationFlowModel model) { public Response createFlow(AuthenticationFlowModel model) {
this.auth.requireManage(); this.auth.requireManage();
if (model.getAlias() == null || model.getAlias().isEmpty()) {
return ErrorResponse.exists("Failed to create flow with empty alias name");
}
if (realm.getFlowByAlias(model.getAlias()) != null) { if (realm.getFlowByAlias(model.getAlias()) != null) {
return ErrorResponse.exists("Flow " + model.getAlias() + " already exists"); return ErrorResponse.exists("Flow " + model.getAlias() + " already exists");
} }