KEYCLOAK-2713 Fix error at startup

This commit is contained in:
mposolda 2016-03-24 15:29:55 +01:00
parent 0f5caffbab
commit c9545e16f7
10 changed files with 26 additions and 14 deletions

View file

@ -40,7 +40,6 @@ import org.keycloak.connections.jpa.util.JpaUtils;
import org.keycloak.models.KeycloakSession; import org.keycloak.models.KeycloakSession;
import org.keycloak.models.KeycloakSessionFactory; import org.keycloak.models.KeycloakSessionFactory;
import org.keycloak.provider.ServerInfoAwareProviderFactory; import org.keycloak.provider.ServerInfoAwareProviderFactory;
import org.keycloak.services.scheduled.ScheduledTaskRunner;
import org.keycloak.timer.TimerProvider; import org.keycloak.timer.TimerProvider;
/** /**
@ -274,7 +273,7 @@ public class DefaultJpaConnectionProviderFactory implements JpaConnectionProvide
protected void startGlobalStats(KeycloakSession session, int globalStatsIntervalSecs) { protected void startGlobalStats(KeycloakSession session, int globalStatsIntervalSecs) {
logger.debugf("Started Hibernate statistics with the interval %s seconds", globalStatsIntervalSecs); logger.debugf("Started Hibernate statistics with the interval %s seconds", globalStatsIntervalSecs);
TimerProvider timer = session.getProvider(TimerProvider.class); TimerProvider timer = session.getProvider(TimerProvider.class);
timer.schedule(new ScheduledTaskRunner(session.getKeycloakSessionFactory(), new HibernateStatsReporter(emf)), globalStatsIntervalSecs * 1000, "ReportHibernateGlobalStats"); timer.scheduleTask(new HibernateStatsReporter(emf), globalStatsIntervalSecs * 1000, "ReportHibernateGlobalStats");
} }

View file

@ -27,7 +27,7 @@ import org.hibernate.stat.QueryStatistics;
import org.hibernate.stat.Statistics; import org.hibernate.stat.Statistics;
import org.jboss.logging.Logger; import org.jboss.logging.Logger;
import org.keycloak.models.KeycloakSession; import org.keycloak.models.KeycloakSession;
import org.keycloak.services.scheduled.ScheduledTask; import org.keycloak.timer.ScheduledTask;
/** /**
* @author <a href="mailto:mposolda@redhat.com">Marek Posolda</a> * @author <a href="mailto:mposolda@redhat.com">Marek Posolda</a>

View file

@ -15,7 +15,7 @@
* limitations under the License. * limitations under the License.
*/ */
package org.keycloak.services.scheduled; package org.keycloak.timer;
import org.keycloak.models.KeycloakSession; import org.keycloak.models.KeycloakSession;

View file

@ -24,7 +24,9 @@ import org.keycloak.provider.Provider;
*/ */
public interface TimerProvider extends Provider { public interface TimerProvider extends Provider {
public void schedule(Runnable runnable, long interval, String taskName); public void schedule(Runnable runnable, long intervalMillis, String taskName);
public void scheduleTask(ScheduledTask scheduledTask, long intervalMillis, String taskName);
public void cancelTask(String taskName); public void cancelTask(String taskName);

View file

@ -20,6 +20,7 @@ package org.keycloak.services.scheduled;
import org.keycloak.events.EventStoreProvider; import org.keycloak.events.EventStoreProvider;
import org.keycloak.models.KeycloakSession; import org.keycloak.models.KeycloakSession;
import org.keycloak.models.RealmModel; import org.keycloak.models.RealmModel;
import org.keycloak.timer.ScheduledTask;
/** /**
* @author <a href="mailto:sthorger@redhat.com">Stian Thorgersen</a> * @author <a href="mailto:sthorger@redhat.com">Stian Thorgersen</a>

View file

@ -20,6 +20,7 @@ package org.keycloak.services.scheduled;
import org.keycloak.models.KeycloakSession; import org.keycloak.models.KeycloakSession;
import org.keycloak.models.RealmModel; import org.keycloak.models.RealmModel;
import org.keycloak.models.UserSessionProvider; import org.keycloak.models.UserSessionProvider;
import org.keycloak.timer.ScheduledTask;
/** /**
* @author <a href="mailto:sthorger@redhat.com">Stian Thorgersen</a> * @author <a href="mailto:sthorger@redhat.com">Stian Thorgersen</a>

View file

@ -23,6 +23,7 @@ import org.keycloak.cluster.ClusterProvider;
import org.keycloak.cluster.ExecutionResult; import org.keycloak.cluster.ExecutionResult;
import org.keycloak.models.KeycloakSession; import org.keycloak.models.KeycloakSession;
import org.keycloak.models.KeycloakSessionFactory; import org.keycloak.models.KeycloakSessionFactory;
import org.keycloak.timer.ScheduledTask;
/** /**
* Ensures that there are not concurrent executions of same task (either on this host or any other cluster host) * Ensures that there are not concurrent executions of same task (either on this host or any other cluster host)

View file

@ -17,13 +17,10 @@
package org.keycloak.services.scheduled; package org.keycloak.services.scheduled;
import java.util.concurrent.Callable;
import org.keycloak.cluster.ClusterProvider;
import org.keycloak.cluster.ExecutionResult;
import org.keycloak.models.KeycloakSession; import org.keycloak.models.KeycloakSession;
import org.keycloak.models.KeycloakSessionFactory; import org.keycloak.models.KeycloakSessionFactory;
import org.keycloak.services.ServicesLogger; import org.keycloak.services.ServicesLogger;
import org.keycloak.timer.ScheduledTask;
/** /**
* @author <a href="mailto:sthorger@redhat.com">Stian Thorgersen</a> * @author <a href="mailto:sthorger@redhat.com">Stian Thorgersen</a>

View file

@ -18,6 +18,9 @@
package org.keycloak.timer.basic; package org.keycloak.timer.basic;
import org.jboss.logging.Logger; import org.jboss.logging.Logger;
import org.keycloak.models.KeycloakSession;
import org.keycloak.services.scheduled.ScheduledTaskRunner;
import org.keycloak.timer.ScheduledTask;
import org.keycloak.timer.TimerProvider; import org.keycloak.timer.TimerProvider;
import java.util.Timer; import java.util.Timer;
@ -30,16 +33,18 @@ public class BasicTimerProvider implements TimerProvider {
private static final Logger logger = Logger.getLogger(BasicTimerProvider.class); private static final Logger logger = Logger.getLogger(BasicTimerProvider.class);
private final KeycloakSession session;
private final Timer timer; private final Timer timer;
private final BasicTimerProviderFactory factory; private final BasicTimerProviderFactory factory;
public BasicTimerProvider(Timer timer, BasicTimerProviderFactory factory) { public BasicTimerProvider(KeycloakSession session, Timer timer, BasicTimerProviderFactory factory) {
this.session = session;
this.timer = timer; this.timer = timer;
this.factory = factory; this.factory = factory;
} }
@Override @Override
public void schedule(final Runnable runnable, final long interval, String taskName) { public void schedule(final Runnable runnable, final long intervalMillis, String taskName) {
TimerTask task = new TimerTask() { TimerTask task = new TimerTask() {
@Override @Override
public void run() { public void run() {
@ -53,8 +58,14 @@ public class BasicTimerProvider implements TimerProvider {
existingTask.cancel(); existingTask.cancel();
} }
logger.debugf("Starting task '%s' with interval '%d'", taskName, interval); logger.debugf("Starting task '%s' with interval '%d'", taskName, intervalMillis);
timer.schedule(task, interval, interval); timer.schedule(task, intervalMillis, intervalMillis);
}
@Override
public void scheduleTask(ScheduledTask scheduledTask, long intervalMillis, String taskName) {
ScheduledTaskRunner scheduledTaskRunner = new ScheduledTaskRunner(session.getKeycloakSessionFactory(), scheduledTask);
this.schedule(scheduledTaskRunner, intervalMillis, taskName);
} }
@Override @Override

View file

@ -39,7 +39,7 @@ public class BasicTimerProviderFactory implements TimerProviderFactory {
@Override @Override
public TimerProvider create(KeycloakSession session) { public TimerProvider create(KeycloakSession session) {
return new BasicTimerProvider(timer, this); return new BasicTimerProvider(session, timer, this);
} }
@Override @Override