From c88628d4f7e08710f3e6773846a79eaea36ad926 Mon Sep 17 00:00:00 2001
From: Erik Jan de Wit <erikjan.dewit@gmail.com>
Date: Tue, 8 Mar 2022 10:53:25 +0100
Subject: [PATCH] Removed 'revocation' section when client is SAML (#2192)

---
 src/clients/AdvancedTab.tsx | 139 +++++++++++++++++++-----------------
 1 file changed, 72 insertions(+), 67 deletions(-)

diff --git a/src/clients/AdvancedTab.tsx b/src/clients/AdvancedTab.tsx
index 651f20dd36..6a59053a92 100644
--- a/src/clients/AdvancedTab.tsx
+++ b/src/clients/AdvancedTab.tsx
@@ -179,78 +179,83 @@ export const AdvancedTab = ({
   if (!publicClient) {
     sections.splice(1, 1);
   }
+  if (protocol !== openIdConnect) {
+    sections.splice(0, 1);
+  }
 
   return (
     <PageSection variant="light" className="pf-u-py-0">
       <ScrollForm sections={sections} borders>
-        <>
-          <Text className="pf-u-pb-lg">
-            <Trans i18nKey="clients-help:notBeforeIntro">
-              In order to successfully push setup url on
-              <Link to={toClient({ realm, clientId: id!, tab: "settings" })}>
-                {t("settings")}
-              </Link>
-              tab
-            </Trans>
-          </Text>
-          <FormAccess role="manage-clients" isHorizontal>
-            <FormGroup
-              label={t("notBefore")}
-              fieldId="kc-not-before"
-              labelIcon={
-                <HelpItem
-                  helpText="clients-help:notBefore"
-                  fieldLabelId="clients:notBefore"
-                />
-              }
-            >
-              <InputGroup>
-                <TextInput
-                  type="text"
-                  id="kc-not-before"
-                  name="notBefore"
-                  isReadOnly
-                  value={formatDate()}
-                />
-                <Button
-                  id="setToNow"
-                  variant="control"
-                  onClick={() => {
-                    setNotBefore(moment.now() / 1000, "notBeforeSetToNow");
-                  }}
-                >
-                  {t("setToNow")}
-                </Button>
-                <Button
-                  id="clear"
-                  variant="control"
-                  onClick={() => {
-                    setNotBefore(0, "notBeforeNowClear");
-                  }}
-                >
-                  {t("clear")}
-                </Button>
-              </InputGroup>
-            </FormGroup>
-            <ActionGroup>
-              {!adminUrl && (
-                <Tooltip
-                  reference={pushRevocationButtonRef}
-                  content={t("clients-help:notBeforeTooltip")}
-                />
-              )}
-              <Button
-                id="push"
-                variant="secondary"
-                onClick={push}
-                isAriaDisabled={!adminUrl}
-                ref={pushRevocationButtonRef}
+        {protocol === openIdConnect && (
+          <>
+            <Text className="pf-u-pb-lg">
+              <Trans i18nKey="clients-help:notBeforeIntro">
+                In order to successfully push setup url on
+                <Link to={toClient({ realm, clientId: id!, tab: "settings" })}>
+                  {t("settings")}
+                </Link>
+                tab
+              </Trans>
+            </Text>
+            <FormAccess role="manage-clients" isHorizontal>
+              <FormGroup
+                label={t("notBefore")}
+                fieldId="kc-not-before"
+                labelIcon={
+                  <HelpItem
+                    helpText="clients-help:notBefore"
+                    fieldLabelId="clients:notBefore"
+                  />
+                }
               >
-                {t("push")}
-              </Button>
-            </ActionGroup>
-          </FormAccess>
-        </>
+                <InputGroup>
+                  <TextInput
+                    type="text"
+                    id="kc-not-before"
+                    name="notBefore"
+                    isReadOnly
+                    value={formatDate()}
+                  />
+                  <Button
+                    id="setToNow"
+                    variant="control"
+                    onClick={() => {
+                      setNotBefore(moment.now() / 1000, "notBeforeSetToNow");
+                    }}
+                  >
+                    {t("setToNow")}
+                  </Button>
+                  <Button
+                    id="clear"
+                    variant="control"
+                    onClick={() => {
+                      setNotBefore(0, "notBeforeNowClear");
+                    }}
+                  >
+                    {t("clear")}
+                  </Button>
+                </InputGroup>
+              </FormGroup>
+              <ActionGroup>
+                {!adminUrl && (
+                  <Tooltip
+                    reference={pushRevocationButtonRef}
+                    content={t("clients-help:notBeforeTooltip")}
+                  />
+                )}
+                <Button
+                  id="push"
+                  variant="secondary"
+                  onClick={push}
+                  isAriaDisabled={!adminUrl}
+                  ref={pushRevocationButtonRef}
+                >
+                  {t("push")}
+                </Button>
+              </ActionGroup>
+            </FormAccess>
+          </>
+        )}
         {publicClient && (
           <>
             <FormAccess role="manage-clients" isHorizontal>