Merge pull request #533 from edewit/issue-459

changed all cancel buttons to type "link"
This commit is contained in:
mfrances17 2021-04-15 17:24:35 -04:00 committed by GitHub
commit c7b87ceeff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 15 additions and 19 deletions

View file

@ -80,7 +80,7 @@ export const DuplicateFlowModal = ({
<Button <Button
id="modal-cancel" id="modal-cancel"
key="cancel" key="cancel"
variant={ButtonVariant.secondary} variant={ButtonVariant.link}
onClick={() => { onClick={() => {
toggleDialog(); toggleDialog();
}} }}

View file

@ -41,11 +41,7 @@ export const ChangeTypeDialog = ({
> >
{t("common:continue")} {t("common:continue")}
</Button>, </Button>,
<Button <Button key="cancel" variant={ButtonVariant.link} onClick={onClose}>
key="cancel"
variant={ButtonVariant.secondary}
onClick={onClose}
>
{t("common:cancel")} {t("common:cancel")}
</Button>, </Button>,
]} ]}

View file

@ -93,7 +93,7 @@ export const AddMapperDialog = (props: AddMapperDialogProps) => {
<Button <Button
id="modal-cancel" id="modal-cancel"
key="cancel" key="cancel"
variant={ButtonVariant.secondary} variant={ButtonVariant.link}
onClick={() => { onClick={() => {
props.toggleDialog(); props.toggleDialog();
}} }}

View file

@ -26,7 +26,7 @@ exports[`<MapperDialog/> should have disabled add button when nothing is selecte
<Button <Button
id="modal-cancel" id="modal-cancel"
onClick={[Function]} onClick={[Function]}
variant="secondary" variant="link"
> >
cancel cancel
</Button>, </Button>,
@ -1052,8 +1052,8 @@ exports[`<MapperDialog/> should have disabled add button when nothing is selecte
</button> </button>
<button <button
aria-disabled="false" aria-disabled="false"
class="pf-c-button pf-m-secondary" class="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-secondary-1" data-ouia-component-id="OUIA-Generated-Button-link-1"
data-ouia-component-type="PF4/Button" data-ouia-component-type="PF4/Button"
data-ouia-safe="true" data-ouia-safe="true"
id="modal-cancel" id="modal-cancel"
@ -1081,7 +1081,7 @@ exports[`<MapperDialog/> should have disabled add button when nothing is selecte
<Button <Button
id="modal-cancel" id="modal-cancel"
onClick={[Function]} onClick={[Function]}
variant="secondary" variant="link"
> >
cancel cancel
</Button>, </Button>,
@ -20303,13 +20303,13 @@ exports[`<MapperDialog/> should have disabled add button when nothing is selecte
id="modal-cancel" id="modal-cancel"
key="cancel" key="cancel"
onClick={[Function]} onClick={[Function]}
variant="secondary" variant="link"
> >
<button <button
aria-disabled={false} aria-disabled={false}
aria-label={null} aria-label={null}
className="pf-c-button pf-m-secondary" className="pf-c-button pf-m-link"
data-ouia-component-id="OUIA-Generated-Button-secondary-1" data-ouia-component-id="OUIA-Generated-Button-link-1"
data-ouia-component-type="PF4/Button" data-ouia-component-type="PF4/Button"
data-ouia-safe={true} data-ouia-safe={true}
disabled={false} disabled={false}

View file

@ -71,7 +71,7 @@ export const AddHostDialog = ({
<Button <Button
id="add-node-cancel" id="add-node-cancel"
key="cancel" key="cancel"
variant={ButtonVariant.secondary} variant={ButtonVariant.link}
onClick={() => onClose()} onClick={() => onClose()}
> >
{t("common:cancel")} {t("common:cancel")}

View file

@ -79,7 +79,7 @@ export const AddScopeDialog = ({
<Button <Button
id="modal-cancel" id="modal-cancel"
key="cancel" key="cancel"
variant={ButtonVariant.secondary} variant={ButtonVariant.link}
onClick={() => { onClick={() => {
setRows([]); setRows([]);
toggleDialog(); toggleDialog();

View file

@ -77,7 +77,7 @@ export const GroupsModal = ({
<Button <Button
id="modal-cancel" id="modal-cancel"
key="cancel" key="cancel"
variant={ButtonVariant.secondary} variant={ButtonVariant.link}
onClick={() => { onClick={() => {
handleModalToggle(); handleModalToggle();
}} }}

View file

@ -82,7 +82,7 @@ export const MemberModal = ({ groupId, onClose }: MemberModalProps) => {
<Button <Button
data-testid="cancel" data-testid="cancel"
key="cancel" key="cancel"
variant="secondary" variant="link"
onClick={onClose} onClick={onClose}
> >
{t("common:cancel")} {t("common:cancel")}

View file

@ -92,7 +92,7 @@ export const MoveGroupDialog = ({
<Button <Button
data-testid="moveCancel" data-testid="moveCancel"
key="cancel" key="cancel"
variant="secondary" variant="link"
onClick={onClose} onClick={onClose}
> >
{t("common:cancel")} {t("common:cancel")}