From bf92bd16b05ca333b9cffd1600b307fbdfc943bd Mon Sep 17 00:00:00 2001 From: mposolda Date: Mon, 23 Mar 2020 18:46:38 +0100 Subject: [PATCH] KEYCLOAK-13383 WebAuthnRegisterAndLoginTest fails with -Dproduct with auth-server-eap --- .../webauthn/WebAuthnFeatureTest.java | 71 +++++++++++++++++++ .../WebAuthnRegisterAndLoginTest.java | 17 ----- 2 files changed, 71 insertions(+), 17 deletions(-) create mode 100644 testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/webauthn/WebAuthnFeatureTest.java diff --git a/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/webauthn/WebAuthnFeatureTest.java b/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/webauthn/WebAuthnFeatureTest.java new file mode 100644 index 0000000000..08e78941de --- /dev/null +++ b/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/webauthn/WebAuthnFeatureTest.java @@ -0,0 +1,71 @@ +/* + * Copyright 2019 Red Hat, Inc. and/or its affiliates + * and other contributors as indicated by the @author tags. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.keycloak.testsuite.webauthn; + +import java.util.List; +import java.util.Set; + +import org.junit.Assert; +import org.junit.Assume; +import org.junit.BeforeClass; +import org.junit.Test; +import org.keycloak.authentication.AuthenticatorSpi; +import org.keycloak.authentication.authenticators.browser.WebAuthnAuthenticatorFactory; +import org.keycloak.common.Profile; +import org.keycloak.representations.idm.RealmRepresentation; +import org.keycloak.representations.info.ServerInfoRepresentation; +import org.keycloak.testsuite.AbstractTestRealmKeycloakTest; +import org.keycloak.testsuite.arquillian.annotation.DisableFeature; +import org.keycloak.testsuite.arquillian.annotation.EnableFeature; + +import static org.keycloak.testsuite.arquillian.AuthServerTestEnricher.AUTH_SERVER_SSL_REQUIRED; + +@EnableFeature(value = Profile.Feature.WEB_AUTHN, skipRestart = true, onlyForProduct = true) +public class WebAuthnFeatureTest extends AbstractTestRealmKeycloakTest { + + @Override + public void configureTestRealm(RealmRepresentation testRealm) { + } + + @BeforeClass + public static void enabled() { + Assume.assumeTrue(AUTH_SERVER_SSL_REQUIRED); + } + + @Test + public void testWebAuthnEnabled() { + testWebAuthnAvailability(true); + } + + // This class should not use "WebAuthnAssume". Otherwise this test won't re-enable the WebAuthn feature and will later fail when executed with + // the "product" profile + @Test + @DisableFeature(value = Profile.Feature.WEB_AUTHN, skipRestart = true) + public void testWebAuthnDisabled() { + testWebAuthnAvailability(false); + } + + private void testWebAuthnAvailability(boolean expectedAvailability) { + ServerInfoRepresentation serverInfo = adminClient.serverInfo().getInfo(); + Set authenticatorProviderIds = serverInfo.getProviders().get(AuthenticatorSpi.SPI_NAME).getProviders().keySet(); + Assert.assertEquals(expectedAvailability, authenticatorProviderIds.contains(WebAuthnAuthenticatorFactory.PROVIDER_ID)); + } + + +} diff --git a/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/webauthn/WebAuthnRegisterAndLoginTest.java b/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/webauthn/WebAuthnRegisterAndLoginTest.java index eaf5e54b68..2a05526404 100644 --- a/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/webauthn/WebAuthnRegisterAndLoginTest.java +++ b/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/webauthn/WebAuthnRegisterAndLoginTest.java @@ -291,23 +291,6 @@ public class WebAuthnRegisterAndLoginTest extends AbstractTestRealmKeycloakTest } } - @Test - public void testWebAuthnEnabled() { - testWebAuthnAvailability(true); - } - - @Test - @DisableFeature(value = Profile.Feature.WEB_AUTHN, skipRestart = true) - public void testWebAuthnDisabled() { - testWebAuthnAvailability(false); - } - - private void testWebAuthnAvailability(boolean expectedAvailability) { - ServerInfoRepresentation serverInfo = adminClient.serverInfo().getInfo(); - Set authenticatorProviderIds = serverInfo.getProviders().get(AuthenticatorSpi.SPI_NAME).getProviders().keySet(); - Assert.assertEquals(expectedAvailability, authenticatorProviderIds.contains(WebAuthnAuthenticatorFactory.PROVIDER_ID)); - } - private void assertUserRegistered(String userId, String username, String email) { UserRepresentation user = getUser(userId); Assert.assertNotNull(user);