Fixed remaining a11y violations for account console (#22673)

* fixed critical a11y violation on Application page

* fixed moderate  a11y violation on Application page

* fixed serious a11y violation on Signin page

* fixed aria-label

* updated label

* Add Dutch translation

---------

Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Co-authored-by: Jon Koops <jonkoops@gmail.com>
This commit is contained in:
agagancarczyk 2023-08-28 16:06:26 +01:00 committed by GitHub
parent c78359bc07
commit bf0d16c4ff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 111 additions and 111 deletions

View file

@ -6,7 +6,7 @@
"accountUpdatedMessage": "Your account has been updated.",
"add": "Add",
"application": "Application",
"applicationDetails": "Application details",
"applicationDetails": "Application details for {{clientId}}",
"applications": "Applications",
"applicationsIntroMessage": "View applications your account has access to",
"applicationType": "Application type",

View file

@ -6,7 +6,7 @@
"accountUpdatedMessage": "Uw account is bijgewerkt.",
"add": "Toevoegen",
"application": "Applicatie",
"applicationDetails": "Applicatiegegevens",
"applicationDetails": "Applicatiegegevens voor {{clientId}}",
"applications": "Applicaties",
"applicationsIntroMessage": "Bekijk applicaties waartoe uw account toegang heeft",
"applicationType": "Applicatietype",

View file

@ -112,7 +112,6 @@ const SigningIn = () => {
return (
<Page title={t("signingIn")} description={t("signingInDescription")}>
<DataList aria-label="user credential" className="pf-u-mb-xl">
{credentials.map((container) => (
<PageSection
key={container.category}
@ -152,9 +151,7 @@ const SigningIn = () => {
<DataList aria-label="credential list" className="pf-u-mb-xl">
{container.userCredentialMetadatas.length === 0 && (
<EmptyRow
message={t("notSetUp", [
t(container.displayName as TFuncKey),
])}
message={t("notSetUp", [t(container.displayName as TFuncKey)])}
/>
)}
@ -221,7 +218,6 @@ const SigningIn = () => {
</DataList>
</PageSection>
))}
</DataList>
</Page>
);
};

View file

@ -81,7 +81,7 @@ const Applications = () => {
<span style={{ visibility: "hidden", height: 55 }}>
<DataListToggle
id="applications-list-header-invisible-toggle"
aria-controls="hidden"
aria-controls="applications-list-content"
/>
</span>
<DataListItemCells
@ -122,6 +122,7 @@ const Applications = () => {
onClick={() => toggleOpen(application.clientId)}
isExpanded={application.open}
id={`toggle-${application.clientId}`}
aria-controls={`content-${application.clientId}`}
/>
<DataListItemCells
className="pf-u-align-items-center"
@ -154,8 +155,11 @@ const Applications = () => {
</DataListItemRow>
<DataListContent
id={`content-${application.clientId}`}
className="pf-u-pl-4xl"
aria-label={t("applicationDetails")}
aria-label={t("applicationDetails", {
clientId: application.clientId,
})}
isHidden={!application.open}
>
<DescriptionList>