From 9dce57417c297942dd10dc8686868f8e11485e0f Mon Sep 17 00:00:00 2001
From: mfrances <mfrances@redhat.com>
Date: Thu, 4 Mar 2021 11:02:33 -0500
Subject: [PATCH] enable save only on dirty

---
 src/user-federation/UserFederationKerberosSettings.tsx | 8 +++++++-
 src/user-federation/UserFederationLdapSettings.tsx     | 8 +++++++-
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/src/user-federation/UserFederationKerberosSettings.tsx b/src/user-federation/UserFederationKerberosSettings.tsx
index 078831f7ef..37d4a00d27 100644
--- a/src/user-federation/UserFederationKerberosSettings.tsx
+++ b/src/user-federation/UserFederationKerberosSettings.tsx
@@ -103,6 +103,7 @@ export const UserFederationKerberosSettings = () => {
   }, []);
 
   const setupForm = (component: ComponentRepresentation) => {
+    form.reset();
     Object.entries(component).map((entry) => {
       form.setValue(
         "config.allowPasswordAuthentication",
@@ -177,7 +178,12 @@ export const UserFederationKerberosSettings = () => {
         <SettingsCache form={form} showSectionHeading />
         <Form onSubmit={form.handleSubmit(save)}>
           <ActionGroup>
-            <Button variant="primary" type="submit" data-testid="kerberos-save">
+            <Button
+              isDisabled={!form.formState.isDirty}
+              variant="primary"
+              type="submit"
+              data-testid="kerberos-save"
+            >
               {t("common:save")}
             </Button>
             <Button
diff --git a/src/user-federation/UserFederationLdapSettings.tsx b/src/user-federation/UserFederationLdapSettings.tsx
index d93a1a4e8b..45bc47396a 100644
--- a/src/user-federation/UserFederationLdapSettings.tsx
+++ b/src/user-federation/UserFederationLdapSettings.tsx
@@ -137,6 +137,7 @@ export const UserFederationLdapSettings = () => {
   }, []);
 
   const setupForm = (component: ComponentRepresentation) => {
+    form.reset();
     Object.entries(component).map((entry) => {
       if (entry[0] === "config") {
         convertToFormValues(entry[1], "config", form.setValue);
@@ -240,7 +241,12 @@ export const UserFederationLdapSettings = () => {
         </ScrollForm>
         <Form onSubmit={form.handleSubmit(save)}>
           <ActionGroup>
-            <Button variant="primary" type="submit" data-testid="ldap-save">
+            <Button
+              isDisabled={!form.formState.isDirty}
+              variant="primary"
+              type="submit"
+              data-testid="ldap-save"
+            >
               {t("common:save")}
             </Button>
             <Button