libre.sh/keycloak-scim
3
0
Fork 0
Code Issues 15 Pull requests Releases 1 Packages Activity Actions

Fixing NPE when querying resources by type

Browse source 
Closes #11137
This commit is contained in:
Pedro Igor 2022-04-06 07:37:21 -03:00
parent 5d271c1634
commit b4770c30fd
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
server-spi-private/src/main/java/org/keycloak/authorization/store/PolicyStore.java
View file

@ -126,7 +126,7 @@ public interface PolicyStore {
default List<Policy> findByResourceType(ResourceServer resourceServer, String resourceType) { default List<Policy> findByResourceType(ResourceServer resourceServer, String resourceType) {
List<Policy> result = new LinkedList<>(); List<Policy> result = new LinkedList<>();
findByResourceType((ResourceServer) null, resourceType, result::add); findByResourceType(resourceServer, resourceType, result::add);
return result; return result;
} }

15
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/client/authorization/ResourceManagementTest.java
View file

@ -70,6 +70,21 @@ public class ResourceManagementTest extends AbstractAuthorizationTest {
assertEquals(1, attributes.get("b").size()); assertEquals(1, attributes.get("b").size());
} }
@Test
public void testCreateWithResourceType() {
ResourceRepresentation newResource = new ResourceRepresentation();
newResource.setName("test");
newResource.setDisplayName("display");
newResource.setType("some-type");
newResource = doCreateResource(newResource);
ResourceResource resource = getClientResource().authorization().resources().resource(newResource.getId());
assertTrue(resource.permissions().isEmpty());
}
@Test @Test
public void failCreateWithSameName() { public void failCreateWithSameName() {
ResourceRepresentation newResource = createResource(); ResourceRepresentation newResource = createResource();