libre.sh/keycloak-scim
4
0
Fork 0
Code Issues 15 Pull requests Releases 1 Activity Actions

[KEYCLOAK-11219] log an explicit error message when state is null

Browse source
This commit is contained in:
Cédric Couralet 2019-08-28 13:19:45 +02:00 committed by Marek Posolda
parent 71e6fc2b30
commit aadd5331bc
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
services/src/main/java/org/keycloak/broker/oidc/OIDCIdentityProvider.java
View file

@ -102,6 +102,14 @@ public class OIDCIdentityProvider extends AbstractOAuth2IdentityProvider<OIDCIde
@GET @GET
@Path("logout_response") @Path("logout_response")
public Response logoutResponse(@QueryParam("state") String state) { public Response logoutResponse(@QueryParam("state") String state) {
if (state == null){
logger.error("no state parameter returned");
EventBuilder event = new EventBuilder(realm, session, clientConnection);
event.event(EventType.LOGOUT);
event.error(Errors.USER_SESSION_NOT_FOUND);
return ErrorPage.error(session, null, Response.Status.BAD_REQUEST, Messages.IDENTITY_PROVIDER_UNEXPECTED_ERROR);
}
UserSessionModel userSession = session.sessions().getUserSession(realm, state); UserSessionModel userSession = session.sessions().getUserSession(realm, state);
if (userSession == null) { if (userSession == null) {
logger.error("no valid user session"); logger.error("no valid user session");