libre.sh/keycloak-scim
3
0
Fork 0
Code Issues 15 Pull requests Releases 1 Packages Activity Actions

Fixed moderate and critical a11y issues for realm settings (#21267)

Browse source 
* Fixed moderate and critical a11y issues for realm settings

* improved with patternfly colour

---------

Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>
This commit is contained in:
agagancarczyk 2023-06-29 12:59:52 +01:00 committed by GitHub
parent ff40c3d092
commit a8bea49451
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 18 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
js/apps/admin-ui/cypress/support/pages/admin-ui/manage/realm_settings/RealmSettingsPage.ts
View file

@ -826,7 +826,7 @@ export default class RealmSettingsPage extends CommonPage {
shouldNotHaveExecutorsConfigured() {
cy.get(this.clientProfileTwo).click();
cy.get('h6[class*="kc-emptyExecutors"]').should(
cy.get('h2[class*="kc-emptyExecutors"]').should(
"have.text",
"No executors configured"
);
@ -840,7 +840,7 @@ export default class RealmSettingsPage extends CommonPage {
.contains("secure-ciba-signed-authn-req")
.click();
cy.get(this.addExecutorCancelBtn).click();
cy.get('h6[class*="kc-emptyExecutors"]').should(
cy.get('h2[class*="kc-emptyExecutors"]').should(
"have.text",
"No executors configured"
);
@ -950,7 +950,7 @@ export default class RealmSettingsPage extends CommonPage {
);
cy.findByTestId(this.modalConfirm).contains("Delete");
cy.findByTestId(this.modalConfirm).click();
cy.get('h6[class*="kc-emptyExecutors"]').should(
cy.get('h2[class*="kc-emptyExecutors"]').should(
"have.text",
"No executors configured"
);
@ -1047,7 +1047,7 @@ export default class RealmSettingsPage extends CommonPage {
shouldNotHaveConditionsConfigured() {
cy.get(this.clientPolicy).click();
cy.get('h6[class*="kc-emptyConditions"]').should(
cy.get('h2[class*="kc-emptyConditions"]').should(
"have.text",
"No conditions configured"
);
@ -1061,7 +1061,7 @@ export default class RealmSettingsPage extends CommonPage {
.contains("any-client")
.click();
cy.findByTestId(this.addConditionCancelBtn).click();
cy.get('h6[class*="kc-emptyConditions"]').should(
cy.get('h2[class*="kc-emptyConditions"]').should(
"have.text",
"No conditions configured"
);
@ -1159,7 +1159,7 @@ export default class RealmSettingsPage extends CommonPage {
);
cy.findByTestId(this.modalConfirm).contains("Delete");
cy.findByTestId(this.modalConfirm).click({ force: true });
cy.get('h6[class*="kc-emptyConditions"]').should(
cy.get('h2[class*="kc-emptyConditions"]').should(
"have.text",
"No conditions configured"
);

2
js/apps/admin-ui/src/realm-settings/ClientProfileForm.tsx
View file

@ -423,7 +423,7 @@ export default function ClientProfileForm() {
<Divider />
<Text
className="kc-emptyExecutors"
component={TextVariants.h6}
component={TextVariants.h2}
>
{t("realm-settings:emptyExecutors")}
</Text>

1
js/apps/admin-ui/src/realm-settings/EmailTab.tsx
View file

@ -344,6 +344,7 @@ export const RealmSettingsEmailTab = ({
) : (
<Alert
variant="warning"
component="h2"
isInline
title={t("testConnectionHint.withoutEmail", {
userName: currentUser.username,

6
js/apps/admin-ui/src/realm-settings/NewClientPolicyForm.tsx
View file

@ -601,6 +601,7 @@ export default function NewClientPolicyForm() {
/>
<Button
variant="link"
aria-label="remove-condition"
isInline
icon={
<TrashIcon
@ -631,7 +632,7 @@ export default function NewClientPolicyForm() {
<Divider />
<Text
className="kc-emptyConditions"
component={TextVariants.h6}
component={TextVariants.h2}
>
{t("realm-settings:emptyConditions")}
</Text>
@ -707,6 +708,7 @@ export default function NewClientPolicyForm() {
/>
<Button
variant="link"
aria-label="remove-client-profile"
isInline
icon={
<TrashIcon
@ -736,7 +738,7 @@ export default function NewClientPolicyForm() {
<Divider />
<Text
className="kc-emptyClientProfiles"
component={TextVariants.h6}
component={TextVariants.h2}
>
{t("realm-settings:emptyProfiles")}
</Text>

1
js/apps/admin-ui/src/realm-settings/RealmSettingsTabs.tsx
View file

@ -268,6 +268,7 @@ export const RealmSettingsTabs = ({
<RoutableTabs
isBox
mountOnEnter
aria-label="realm-settings-tabs"
defaultLocation={toRealmSettings({
realm: realmName,
tab: "general",

10
js/apps/admin-ui/src/realm-settings/realm-settings-section.css
View file

@ -192,15 +192,15 @@ article.pf-c-card.pf-m-flat.kc-email-connection
}
.kc-emptyExecutors {
color: #8d9195;
color: var(--pf-global--Color--200);
}
.kc-emptyConditions {
color: #8d9195;
color: var(--pf-global--Color--200);
}
.kc-emptyClientProfiles {
color: #8d9195;
color: var(--pf-global--Color--200);
}
.kc-action-dropdown {
@ -277,7 +277,7 @@ input#kc-scopes {
}
.kc-emptyValidators {
color: #8d9195;
color: var(--pf-global--Color--200);
margin-left: 25px;
}
@ -296,4 +296,4 @@ input#kc-scopes {
}
.kc--attributes-validations--action-cell {
text-align: right;
}
}