Add href to brand of Masthead (#20597)

This commit is contained in:
Jon Koops 2023-05-26 12:57:25 +02:00 committed by GitHub
parent 9dabbe951e
commit a58a9a89d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 10 deletions

View file

@ -6,14 +6,14 @@ import {
} from "keycloak-masthead";
import { Suspense, useMemo } from "react";
import { useTranslation } from "react-i18next";
import { Outlet } from "react-router-dom";
import { Outlet, useHref } from "react-router-dom";
import { AlertProvider } from "ui-shared";
import { ExternalLinkSquareAltIcon } from "@patternfly/react-icons";
import { environment } from "../environment";
import { keycloak } from "../keycloak";
import { joinPath } from "../utils/joinPath";
import { PageNav } from "./PageNav";
import { ExternalLinkSquareAltIcon } from "@patternfly/react-icons";
import style from "./Root.module.css";
@ -37,6 +37,7 @@ const ReferrerLink = () => {
export const Root = () => {
const { t } = useTranslation();
const indexHref = useHref("/");
const translations = useMemo<Translations>(
() => ({
@ -57,6 +58,7 @@ export const Root = () => {
features={{ hasManageAccount: false }}
showNavToggle
brand={{
href: indexHref,
src: joinPath(environment.resourceUrl, "logo.svg"),
alt: t("logo"),
className: style.brand,

View file

@ -19,7 +19,7 @@ import { loggedInUserName } from "./util";
import { DefaultAvatar } from "./DefaultAvatar";
type BrandLogo = BrandProps & {
onClick?: () => void;
href: string;
};
type KeycloakMastheadProps = PageHeaderProps & {
@ -37,7 +37,7 @@ type KeycloakMastheadProps = PageHeaderProps & {
};
const KeycloakMasthead = ({
brand: { onClick: onBrandLogoClick, ...brandProps },
brand: { href: brandHref, ...brandProps },
avatar,
features: {
hasLogout = true,
@ -74,12 +74,8 @@ const KeycloakMasthead = ({
return (
<PageHeader
{...rest}
logo={
<div onClick={onBrandLogoClick}>
<Brand {...brandProps} />
</div>
}
logoComponent="div"
logo={<Brand {...brandProps} />}
logoProps={{ href: brandHref }}
headerTools={
<PageHeaderTools>
<PageHeaderToolsGroup>