libre.sh/keycloak-scim
2
0
Fork 0
Code Issues 14 Pull requests Releases Packages Activity Actions 6

converts attribute names (#3134)

Browse source 
* converts attribute names

fixes: #3092

* revert changes previosly failing test & unskip fixed one

Co-authored-by: Ivan Khomyn <ikhomyn@redhat.com>
This commit is contained in:
Erik Jan de Wit 2022-08-19 13:57:25 +02:00 committed by GitHub
parent e6686bf43f
commit 9d9e774790
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
cypress/e2e/clients_saml_test.spec.ts
View file

@ -79,13 +79,6 @@ describe("Clients SAML tests", () => {
it("should doesn't disable signature when cancel", () => { it("should doesn't disable signature when cancel", () => {
cy.findByTestId("clientSignature").click({ force: true }); cy.findByTestId("clientSignature").click({ force: true });
cy.findByTestId("generate").click();
masthead.checkNotificationMessage(
"New key pair and certificate generated successfully"
);
modalUtils.confirmModal();
cy.findByTestId("clientSignature").click({ force: true });
modalUtils modalUtils
.checkModalTitle('Disable "Client signature required"') .checkModalTitle('Disable "Client signature required"')
.cancelModal(); .cancelModal();
@ -93,8 +86,7 @@ describe("Clients SAML tests", () => {
cy.findAllByTestId("certificate").should("have.length", 1); cy.findAllByTestId("certificate").should("have.length", 1);
}); });
// https://github.com/keycloak/keycloak-admin-ui/issues/3092 it("should disable client signature", () => {
it.skip("should disable client signature", () => {
cy.intercept( cy.intercept(
"admin/realms/master/clients/*/certificates/saml.signing" "admin/realms/master/clients/*/certificates/saml.signing"
).as("load"); ).as("load");

5
src/clients/keys/SamlKeys.tsx
View file

@ -27,6 +27,7 @@ import { Certificate } from "./Certificate";
import { useConfirmDialog } from "../../components/confirm-dialog/ConfirmDialog"; import { useConfirmDialog } from "../../components/confirm-dialog/ConfirmDialog";
import { useAlerts } from "../../components/alert/Alerts"; import { useAlerts } from "../../components/alert/Alerts";
import { SamlImportKeyDialog } from "./SamlImportKeyDialog"; import { SamlImportKeyDialog } from "./SamlImportKeyDialog";
import { convertAttributeNameToForm } from "../../util";
type SamlKeysProps = { type SamlKeysProps = {
clientId: string; clientId: string;
@ -38,12 +39,12 @@ export type KeyTypes = typeof KEYS[number];
const KEYS_MAPPING: { [key in KeyTypes]: { [index: string]: string } } = { const KEYS_MAPPING: { [key in KeyTypes]: { [index: string]: string } } = {
"saml.signing": { "saml.signing": {
name: "attributes.saml.client.signature", name: convertAttributeNameToForm("attributes.saml.client.signature"),
title: "signingKeysConfig", title: "signingKeysConfig",
key: "clientSignature", key: "clientSignature",
}, },
"saml.encryption": { "saml.encryption": {
name: "attributes.saml.encrypt", name: convertAttributeNameToForm("attributes.saml.encrypt"),
title: "encryptionKeysConfig", title: "encryptionKeysConfig",
key: "encryptAssertions", key: "encryptAssertions",
}, },