libre.sh/keycloak-scim
3
0
Fork 0
Code Issues 15 Pull requests Releases Packages Activity Actions

Handle DB exceptions for JTA TX

Browse source
This commit is contained in:
Martin Bartoš 2023-03-22 12:39:40 +01:00 committed by Václav Muzikář
parent 7af2459c7d
commit 9719e1d210
2 changed files with 36 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
model/jpa/src/main/java/org/keycloak/connections/jpa/PersistenceExceptionConverter.java
View file

@ -29,6 +29,8 @@ import java.lang.reflect.InvocationHandler;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.lang.reflect.Proxy;
import java.sql.SQLIntegrityConstraintViolationException;
import java.util.function.Predicate;
import java.util.regex.Pattern;
/**
@ -75,10 +77,23 @@ public class PersistenceExceptionConverter implements InvocationHandler {
}
}
// For JTA, the database operations are executed during the commit phase of a transaction, and DB exceptions can be propagated differently
public static ModelException convert(Throwable t) {
if (t.getCause() != null && t.getCause() instanceof ConstraintViolationException) {
throw new ModelDuplicateException(t);
} if (t instanceof EntityExistsException || t instanceof ConstraintViolationException) {
final Predicate<Throwable> checkDuplicationMessage = throwable -> {
final String message = throwable.getCause() != null ? throwable.getCause().getMessage() : throwable.getMessage();
return message.toLowerCase().contains("duplicate");
};
Predicate<Throwable> throwModelDuplicateEx = throwable ->
throwable instanceof EntityExistsException
|| throwable instanceof ConstraintViolationException
|| throwable instanceof SQLIntegrityConstraintViolationException;
throwModelDuplicateEx = throwModelDuplicateEx.or(checkDuplicationMessage);
if (t.getCause() != null && throwModelDuplicateEx.test(t.getCause())) {
throw new ModelDuplicateException(t.getCause());
} else if (throwModelDuplicateEx.test(t)) {
throw new ModelDuplicateException(t);
} else {
throw new ModelException(t);

21
model/jpa/src/main/java/org/keycloak/models/jpa/PersistenceExceptionConverter.java
View file

@ -27,6 +27,8 @@ import java.lang.reflect.InvocationHandler;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.lang.reflect.Proxy;
import java.sql.SQLIntegrityConstraintViolationException;
import java.util.function.Predicate;
/**
* @author <a href="mailto:sthorger@redhat.com">Stian Thorgersen</a>
@ -52,10 +54,23 @@ public class PersistenceExceptionConverter implements InvocationHandler {
}
}
// For JTA, the database operations are executed during the commit phase of a transaction, and DB exceptions can be propagated differently
public static ModelException convert(Throwable t) {
if (t.getCause() != null && t.getCause() instanceof ConstraintViolationException) {
throw new ModelDuplicateException(t);
} if (t instanceof EntityExistsException) {
final Predicate<Throwable> checkDuplicationMessage = throwable -> {
final String message = throwable.getCause() != null ? throwable.getCause().getMessage() : throwable.getMessage();
return message.toLowerCase().contains("duplicate");
};
Predicate<Throwable> throwModelDuplicateEx = throwable ->
throwable instanceof EntityExistsException
|| throwable instanceof ConstraintViolationException
|| throwable instanceof SQLIntegrityConstraintViolationException;
throwModelDuplicateEx = throwModelDuplicateEx.or(checkDuplicationMessage);
if (t.getCause() != null && throwModelDuplicateEx.test(t.getCause())) {
throw new ModelDuplicateException(t.getCause());
} else if (throwModelDuplicateEx.test(t)) {
throw new ModelDuplicateException(t);
} else {
throw new ModelException(t);