libre.sh/keycloak-scim
3
0
Fork 0
Code Issues 15 Pull requests Releases 1 Activity Actions

Merge pull request #4104 from sjvs/master

Browse source 
Fix three lgtm.com alerts: two possible NPEs, one possible int overflow
This commit is contained in:
Stian Thorgersen 2017-05-05 13:13:02 +02:00 committed by GitHub
commit 8da766e02e
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
model/jpa/src/main/java/org/keycloak/models/jpa/JpaUserCredentialStore.java
View file

@ -119,7 +119,7 @@ public class JpaUserCredentialStore implements UserCredentialStore {
entity.setUser(userRef); entity.setUser(userRef);
em.persist(entity); em.persist(entity);
MultivaluedHashMap<String, String> config = cred.getConfig(); MultivaluedHashMap<String, String> config = cred.getConfig();
if (config != null || !config.isEmpty()) { if (config != null && !config.isEmpty()) {
for (String key : config.keySet()) { for (String key : config.keySet()) {
List<String> values = config.getList(key); List<String> values = config.getList(key);

2
saml-core/src/main/java/org/keycloak/saml/processing/core/saml/v2/util/XMLTimeUtil.java
View file

@ -130,7 +130,7 @@ public class XMLTimeUtil {
* @return * @return
*/ */
public static long inMilis(int valueInMins) { public static long inMilis(int valueInMins) {
return valueInMins * 60 * 1000; return (long) valueInMins * 60 * 1000;
} }
/** /**

2
services/src/main/java/org/keycloak/services/resources/admin/RealmAdminResource.java
View file

@ -541,7 +541,7 @@ public class RealmAdminResource {
query.client(client); query.client(client);
} }
if (types != null & !types.isEmpty()) { if (types != null && !types.isEmpty()) {
EventType[] t = new EventType[types.size()]; EventType[] t = new EventType[types.size()];
for (int i = 0; i < t.length; i++) { for (int i = 0; i < t.length; i++) {
t[i] = EventType.valueOf(types.get(i)); t[i] = EventType.valueOf(types.get(i));