diff --git a/cypress/support/pages/admin_console/manage/realm_settings/RealmSettingsPage.ts b/cypress/support/pages/admin_console/manage/realm_settings/RealmSettingsPage.ts index 6364fa4653..56e1994b50 100644 --- a/cypress/support/pages/admin_console/manage/realm_settings/RealmSettingsPage.ts +++ b/cypress/support/pages/admin_console/manage/realm_settings/RealmSettingsPage.ts @@ -1,3 +1,5 @@ +import ListingPage from "../../ListingPage"; + const expect = chai.expect; export default class RealmSettingsPage { generalSaveBtn = "general-tab-save"; @@ -182,6 +184,7 @@ export default class RealmSettingsPage { private addExecutorDrpDwnOption = "executorType-select"; private addExecutorCancelBtn = "addExecutor-cancelBtn"; private addExecutorSaveBtn = "addExecutor-saveBtn"; + private listingPage = new ListingPage(); selectLoginThemeType(themeType: string) { cy.get(this.selectLoginTheme).click(); @@ -548,8 +551,8 @@ export default class RealmSettingsPage { } shouldDeleteClientProfileDialog() { - cy.get(this.moreDrpDwn).last().click(); - cy.get(this.moreDrpDwnItems).click(); + this.listingPage.searchItem("Test", false); + this.listingPage.clickRowDetails("Test").clickDetailMenu("Delete"); cy.findByTestId("modalConfirm").contains("Delete").click(); cy.get(this.alertMessage).should("be.visible", "Client profile deleted"); cy.get("table").should("not.have.text", "Test"); @@ -829,8 +832,8 @@ export default class RealmSettingsPage { } shouldDisplayDeleteClientProfileDialog() { - cy.get(this.moreDrpDwn).last().click(); - cy.get(this.moreDrpDwnItems).click(); + this.listingPage.searchItem("Test", false); + this.listingPage.clickRowDetails("Test").clickDetailMenu("Delete"); cy.get(this.deleteDialogTitle).contains("Delete profile?"); cy.get(this.deleteDialogBodyText).contains( "This action will permanently delete the profile Test. This cannot be undone." @@ -841,8 +844,8 @@ export default class RealmSettingsPage { } shouldDeleteClientPolicyDialog() { - cy.get(this.moreDrpDwn).last().click(); - cy.get(this.moreDrpDwnItems).click(); + this.listingPage.searchItem("Test", false); + this.listingPage.clickRowDetails("Test").clickDetailMenu("Delete"); cy.findByTestId("modalConfirm").contains("Delete").click(); cy.get(this.alertMessage).should("be.visible", "Client profile deleted"); cy.get("table").should("not.have.text", "Test"); diff --git a/src/client-scopes/add/components/MultivaluedStringComponent.tsx b/src/client-scopes/add/components/MultivaluedStringComponent.tsx deleted file mode 100644 index 9561638613..0000000000 --- a/src/client-scopes/add/components/MultivaluedStringComponent.tsx +++ /dev/null @@ -1,46 +0,0 @@ -import React from "react"; -import { useTranslation } from "react-i18next"; -import { FormGroup } from "@patternfly/react-core"; -import { camelCase } from "lodash"; - -import { HelpItem } from "../../../components/help-enabler/HelpItem"; -import type { ComponentProps } from "./components"; -import { MultiLineInput } from "../../../components/multi-line-input/MultiLineInput"; -import { convertToHyphens } from "../../../util"; - -export const MultiValuedStringComponent = ({ - name, - label, - helpText, -}: ComponentProps) => { - const { t } = useTranslation("realm-settings"); - - const convertToString = (s: string) => - camelCase(convertToHyphens(s).replaceAll("-", " ")); - - return ( - - } - fieldId={name!} - > - - - ); -}; diff --git a/src/client-scopes/details/MappingDetails.tsx b/src/client-scopes/details/MappingDetails.tsx index f76f25115c..a18057b5d5 100644 --- a/src/client-scopes/details/MappingDetails.tsx +++ b/src/client-scopes/details/MappingDetails.tsx @@ -25,9 +25,9 @@ import { useServerInfo } from "../../context/server-info/ServerInfoProvider"; import { convertFormValuesToObject, convertToFormValues } from "../../util"; import { FormAccess } from "../../components/form-access/FormAccess"; import { useRealm } from "../../context/realm-context/RealmContext"; -import { COMPONENTS, isValidComponentType } from "../add/components/components"; import { MapperParams, MapperRoute } from "../routes/Mapper"; import { toClientScope } from "../routes/ClientScope"; +import { DynamicComponents } from "../../components/dynamic/DynamicComponents"; import "./mapping-details.css"; @@ -242,17 +242,7 @@ export default function MappingDetails() { /> - {mapping?.properties.map((property) => { - const componentType = property.type!; - if (isValidComponentType(componentType)) { - const Component = COMPONENTS[componentType]; - return ; - } else { - console.warn( - `There is no editor registered for ${componentType}` - ); - } - })} +