From 7e41aa9880563371cdd243adcff380e18a42b3a0 Mon Sep 17 00:00:00 2001
From: Hynek Mlnarik <hmlnarik@redhat.com>
Date: Mon, 4 Mar 2024 12:51:10 +0100
Subject: [PATCH] Show expiration only when explicitly requested

Fixes: #20792

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
---
 .../src/clients/advanced/AdvancedSettings.tsx       | 13 -------------
 .../admin-ui/src/clients/advanced/TokenLifespan.tsx |  2 +-
 2 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/js/apps/admin-ui/src/clients/advanced/AdvancedSettings.tsx b/js/apps/admin-ui/src/clients/advanced/AdvancedSettings.tsx
index d009859659..71f0424093 100644
--- a/js/apps/admin-ui/src/clients/advanced/AdvancedSettings.tsx
+++ b/js/apps/admin-ui/src/clients/advanced/AdvancedSettings.tsx
@@ -127,19 +127,6 @@ export const AdvancedSettings = ({
             units={["minute", "day", "hour"]}
           />
 
-          <TokenLifespan
-            id="clientOfflineSessionMax"
-            name={convertAttributeNameToForm(
-              "attributes.client.offline.session.max.lifespan",
-            )}
-            defaultValue={
-              realm?.offlineSessionMaxLifespanEnabled
-                ? realm.offlineSessionMaxLifespan
-                : undefined
-            }
-            units={["minute", "day", "hour"]}
-          />
-
           <FormGroup
             label={t("oAuthMutual")}
             fieldId="oAuthMutual"
diff --git a/js/apps/admin-ui/src/clients/advanced/TokenLifespan.tsx b/js/apps/admin-ui/src/clients/advanced/TokenLifespan.tsx
index 49aa616b75..b69ae587ba 100644
--- a/js/apps/admin-ui/src/clients/advanced/TokenLifespan.tsx
+++ b/js/apps/admin-ui/src/clients/advanced/TokenLifespan.tsx
@@ -74,7 +74,7 @@ export const TokenLifespan = ({
                 <SelectOption value={60}>{t(expires)}</SelectOption>
               </Select>
             </SplitItem>
-            <SplitItem>
+            <SplitItem hidden={!isExpireSet(field.value)}>
               <TimeSelector
                 validated={
                   isExpireSet(field.value) && field.value! < 1