libre.sh/keycloak-scim
3
0
Fork 0
Code Issues 15 Pull requests Releases Packages Activity Actions

[KEYCLOAK-1211] Fixed Active Directory users authenticating without providing a password

Browse source
This commit is contained in:
Tilen Faganel 2015-04-15 16:59:55 +02:00
parent 5ef1ddb9f1
commit 770d2d8a4c
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/src/main/java/org/keycloak/services/managers/AuthenticationManager.java
View file

@ -551,7 +551,7 @@ public class AuthenticationManager {
credentials.add(UserCredentialModel.totp(totp)); credentials.add(UserCredentialModel.totp(totp));
} }
if (password == null && passwordToken == null) { if ((password == null || password.isEmpty()) && (passwordToken == null || passwordToken.isEmpty())) {
logger.debug("Password not provided"); logger.debug("Password not provided");
return AuthenticationStatus.MISSING_PASSWORD; return AuthenticationStatus.MISSING_PASSWORD;
} }

8
testsuite/integration/src/test/java/org/keycloak/testsuite/federation/FederationProvidersIntegrationTest.java
View file

@ -202,6 +202,14 @@ public class FederationProvidersIntegrationTest {
Assert.assertNotNull(oauth.getCurrentQuery().get(OAuth2Constants.CODE)); Assert.assertNotNull(oauth.getCurrentQuery().get(OAuth2Constants.CODE));
} }
@Test
public void loginLdapWithoutPassword() {
loginPage.open();
loginPage.login("john@email.org", "");
Assert.assertEquals("Invalid username or password.", loginPage.getError());
}
@Test @Test
public void passwordChangeLdap() throws Exception { public void passwordChangeLdap() throws Exception {
changePasswordPage.open(); changePasswordPage.open();