libre.sh/keycloak-scim
3
0
Fork 0
Code Issues 15 Pull requests Releases Packages Activity Actions

Normalize default authentication flow descriptions to start with an uppercase letter (#31277)

Browse source 
Closes #31291

Signed-off-by: Stefano Azzalini <stefano.azzalini@luminator.com>
This commit is contained in:
Stefano Azzalini 2024-07-16 13:49:35 +02:00 committed by GitHub
parent 39cc7013b0
commit 6d67c1f9cc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
server-spi-private/src/main/java/org/keycloak/models/utils/DefaultAuthenticationFlows.java
View file

@ -78,7 +78,7 @@ public class DefaultAuthenticationFlows {
public static void registrationFlow(RealmModel realm, boolean migrate) { public static void registrationFlow(RealmModel realm, boolean migrate) {
AuthenticationFlowModel registrationFlow = new AuthenticationFlowModel(); AuthenticationFlowModel registrationFlow = new AuthenticationFlowModel();
registrationFlow.setAlias(REGISTRATION_FLOW); registrationFlow.setAlias(REGISTRATION_FLOW);
registrationFlow.setDescription("registration flow"); registrationFlow.setDescription("Registration flow");
registrationFlow.setProviderId("basic-flow"); registrationFlow.setProviderId("basic-flow");
registrationFlow.setTopLevel(true); registrationFlow.setTopLevel(true);
registrationFlow.setBuiltIn(true); registrationFlow.setBuiltIn(true);
@ -87,7 +87,7 @@ public class DefaultAuthenticationFlows {
AuthenticationFlowModel registrationFormFlow = new AuthenticationFlowModel(); AuthenticationFlowModel registrationFormFlow = new AuthenticationFlowModel();
registrationFormFlow.setAlias(REGISTRATION_FORM_FLOW); registrationFormFlow.setAlias(REGISTRATION_FORM_FLOW);
registrationFormFlow.setDescription("registration form"); registrationFormFlow.setDescription("Registration form");
registrationFormFlow.setProviderId("form-flow"); registrationFormFlow.setProviderId("form-flow");
registrationFormFlow.setTopLevel(false); registrationFormFlow.setTopLevel(false);
registrationFormFlow.setBuiltIn(true); registrationFormFlow.setBuiltIn(true);
@ -292,7 +292,7 @@ public class DefaultAuthenticationFlows {
public static void browserFlow(RealmModel realm, boolean migrate) { public static void browserFlow(RealmModel realm, boolean migrate) {
AuthenticationFlowModel browser = new AuthenticationFlowModel(); AuthenticationFlowModel browser = new AuthenticationFlowModel();
browser.setAlias(BROWSER_FLOW); browser.setAlias(BROWSER_FLOW);
browser.setDescription("browser based authentication"); browser.setDescription("Browser based authentication");
browser.setProviderId("basic-flow"); browser.setProviderId("basic-flow");
browser.setTopLevel(true); browser.setTopLevel(true);
browser.setBuiltIn(true); browser.setBuiltIn(true);

4
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/authentication/InitialFlowsTest.java
View file

@ -122,7 +122,7 @@ public class InitialFlowsTest extends AbstractAuthenticationTest {
LinkedList<FlowExecutions> expected = new LinkedList<>(); LinkedList<FlowExecutions> expected = new LinkedList<>();
String[] kerberosAuthExpectedChoices = KerberosUtils.isKerberosSupportExpected() ? new String[]{REQUIRED, ALTERNATIVE, DISABLED} : new String[]{DISABLED}; String[] kerberosAuthExpectedChoices = KerberosUtils.isKerberosSupportExpected() ? new String[]{REQUIRED, ALTERNATIVE, DISABLED} : new String[]{DISABLED};
AuthenticationFlowRepresentation flow = newFlow("browser", "browser based authentication", "basic-flow", true, true); AuthenticationFlowRepresentation flow = newFlow("browser", "Browser based authentication", "basic-flow", true, true);
addExecExport(flow, null, false, "auth-cookie", false, null, ALTERNATIVE, 10); addExecExport(flow, null, false, "auth-cookie", false, null, ALTERNATIVE, 10);
addExecExport(flow, null, false, "auth-spnego", false, null, DISABLED, 20); addExecExport(flow, null, false, "auth-spnego", false, null, DISABLED, 20);
addExecExport(flow, null, false, "identity-provider-redirector", false, null, ALTERNATIVE, 25); addExecExport(flow, null, false, "identity-provider-redirector", false, null, ALTERNATIVE, 25);
@ -192,7 +192,7 @@ public class InitialFlowsTest extends AbstractAuthenticationTest {
addExecInfo(execs, "OTP Form", "auth-otp-form", false, 5, 1, REQUIRED, null, new String[]{REQUIRED, ALTERNATIVE, DISABLED}, 20); addExecInfo(execs, "OTP Form", "auth-otp-form", false, 5, 1, REQUIRED, null, new String[]{REQUIRED, ALTERNATIVE, DISABLED}, 20);
expected.add(new FlowExecutions(flow, execs)); expected.add(new FlowExecutions(flow, execs));
flow = newFlow("registration", "registration flow", "basic-flow", true, true); flow = newFlow("registration", "Registration flow", "basic-flow", true, true);
addExecExport(flow, "registration form", false, "registration-page-form", true, null, REQUIRED, 10); addExecExport(flow, "registration form", false, "registration-page-form", true, null, REQUIRED, 10);
execs = new LinkedList<>(); execs = new LinkedList<>();