Port common authorization policy fields to new form controls (#27571)

Signed-off-by: Jon Koops <jonkoops@gmail.com>

js/apps/admin-ui/src/clients/authorization/policy/NameDescription.tsx

@@ -1,76 +1,29 @@
 import { useTranslation } from "react-i18next";
-import { useFormContext } from "react-hook-form";
+import { TextAreaControl, TextControl } from "ui-shared";
-import { FormGroup, ValidatedOptions } from "@patternfly/react-core";
-
-import { HelpItem } from "ui-shared";
-import { KeycloakTextInput } from "../../../components/keycloak-text-input/KeycloakTextInput";
-import { KeycloakTextArea } from "../../../components/keycloak-text-area/KeycloakTextArea";
 
 type NameDescriptionProps = {
-  prefix: string;
   isDisabled: boolean;
 };
 
-export const NameDescription = ({
+export const NameDescription = ({ isDisabled }: NameDescriptionProps) => {
-  prefix,
-  isDisabled,
-}: NameDescriptionProps) => {
   const { t } = useTranslation();
-  const {
-    register,
-    formState: { errors },
-  } = useFormContext();
 
   return (
     <>
-      <FormGroup
+      <TextControl
+        name="name"
         label={t("name")}
-        fieldId="kc-name"
+        rules={{ required: t("required") }}
-        helperTextInvalid={t("required")}
+        isDisabled={isDisabled}
-        validated={
+      />
-          errors.name ? ValidatedOptions.error : ValidatedOptions.default
+      <TextAreaControl
-        }
+        name="description"
-        isRequired
-        labelIcon={
-          <HelpItem helpText={t(`${prefix}-nameHelp`)} fieldLabelId="name" />
-        }
-      >
-        <KeycloakTextInput
-          isDisabled={isDisabled}
-          id="kc-name"
-          data-testid="name"
-          validated={
-            errors.name ? ValidatedOptions.error : ValidatedOptions.default
-          }
-          {...register("name", { required: true })}
-        />
-      </FormGroup>
-      <FormGroup
         label={t("description")}
-        fieldId="kc-description"
+        rules={{
-        labelIcon={
+          maxLength: { message: t("maxLength", { length: 255 }), value: 255 },
-          <HelpItem
+        }}
-            helpText={t(`${prefix}-descriptionHelp`)}
+        isDisabled={isDisabled}
-            fieldLabelId="description"
+      />
-          />
-        }
-        validated={
-          errors.description ? ValidatedOptions.error : ValidatedOptions.default
-        }
-        helperTextInvalid={t("maxLength", { length: 255 })}
-      >
-        <KeycloakTextArea
-          isDisabled={isDisabled}
-          id="kc-description"
-          data-testid="description"
-          validated={
-            errors.description
-              ? ValidatedOptions.error
-              : ValidatedOptions.default
-          }
-          {...register("description", { maxLength: 255 })}
-        />
-      </FormGroup>
     </>
   );
 };

js/apps/admin-ui/src/clients/authorization/policy/PolicyDetails.tsx

@@ -201,7 +201,7 @@ export default function PolicyDetails() {
           role="anyone" // if you get this far it means you have access
         >
           <FormProvider {...form}>
-            <NameDescription isDisabled={isDisabled} prefix="policy" />
+            <NameDescription isDisabled={isDisabled} />
             <ComponentType />
             <LogicSelector isDisabled={isDisabled} />
           </FormProvider>