libre.sh/keycloak-scim
2
0
Fork 0
Code Issues 14 Pull requests Releases Packages Activity Actions 6

Fix user-facing typos in error messages (#29326)

Browse source 
Update resource file and tests accordingly

Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
This commit is contained in:
Dimitri Papadopoulos Orfanos 2024-05-16 09:55:41 +02:00 committed by GitHub
parent b4e7d9b1aa
commit 64a145e960
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
19 changed files with 24 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
common/src/main/java/org/keycloak/common/profile/PropertiesFileProfileConfigResolver.java
View file

@ -24,7 +24,7 @@ public class PropertiesFileProfileConfigResolver extends PropertiesProfileConfig
}
}
} catch (IOException e) {
throw new ProfileException("Failed to load profile propeties file", e);
throw new ProfileException("Failed to load profile properties file", e);
}
return properties;
}

2
federation/ldap/src/main/java/org/keycloak/storage/ldap/mappers/LDAPTransaction.java
View file

@ -51,7 +51,7 @@ public class LDAPTransaction extends AbstractKeycloakTransaction {
logger.trace("Transaction commit! Updating LDAP attributes for object " + ldapUser.getDn() + ", attributes: " + ldapUser.getAttributes());
}
if (ldapUser.isWaitingForExecutionOnMandatoryAttributesComplete()) {
throw new ModelValidationException("LDAPObject cannot be commited because some mandatory attributes are not set: "
throw new ModelValidationException("LDAPObject cannot be committed because some mandatory attributes are not set: "
+ ldapUser.getMandatoryAttributeNamesRemaining());
}

2
federation/sssd/src/main/java/org/freedesktop/dbus/ArrayFrob.java
View file

@ -169,7 +169,7 @@ public final class ArrayFrob {
throw new IllegalArgumentException(_ex);
}
throw new IllegalArgumentException(String.format("Not An Expected Convertion type from %s to %s", _o.getClass(), _c));
throw new IllegalArgumentException(String.format("Not An Expected Conversion type from %s to %s", _o.getClass(), _c));
}
public static Object[] type(Object[] _old, Class<Object> _c) {

2
federation/sssd/src/main/java/org/freedesktop/dbus/connections/GlobalHandler.java
View file

@ -40,7 +40,7 @@ public class GlobalHandler implements org.freedesktop.dbus.interfaces.Peer, org.
}
}
if (null == intro) {
throw new UnknownObject("Introspecting on non-existant object");
throw new UnknownObject("Introspecting on non-existent object");
} else {
return "<!DOCTYPE node PUBLIC \"-//freedesktop//DTD D-BUS Object Introspection 1.0//EN\" "
+ "\"http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd\">\n" + intro;

2
federation/sssd/src/main/resources/en_US.properties
View file

@ -54,7 +54,7 @@ notReplyWithSpecifiedTime="No reply within specified time"
missingTransport="No transport present"
notDBusInterface="Not A DBus Interface"
notDBusSignal="Not A DBus Signal"
convertionTypeNotExpected="Not An Expected Convertion type from {0} to {1}"
convertionTypeNotExpected="Not An Expected Conversion type from {0} to {1}"
notConnected="Not Connected"
notPrimitiveType="Not a primitive type"
invalidDBusCode="Not a valid D-Bus type code: "

2
integration/client-cli/admin-cli/src/main/java/org/keycloak/client/admin/cli/commands/CreateCmd.java
View file

@ -122,7 +122,7 @@ public class CreateCmd extends AbstractRequestCmd {
out.println(" -a, --admin-root URL URL of Admin REST endpoint root if not default - e.g. http://localhost:8080/admin");
out.println();
out.println();
out.println("Nested attributes are supported by using '.' to separate components of a KEY. Optionaly, the KEY components ");
out.println("Nested attributes are supported by using '.' to separate components of a KEY. Optionally, the KEY components ");
out.println("can be quoted with double quotes - e.g. my_client.attributes.\"external.user.id\". If VALUE starts with [ and ");
out.println("ends with ] the attribute will be set as a JSON array. If VALUE starts with { and ends with } the attribute ");
out.println("will be set as a JSON object. If KEY ends with an array index - e.g. clients[3]=VALUE - then the specified item");

2
integration/client-cli/admin-cli/src/main/java/org/keycloak/client/admin/cli/commands/UpdateCmd.java
View file

@ -131,7 +131,7 @@ public class UpdateCmd extends AbstractRequestCmd {
out.println(" -a, --admin-root URL URL of Admin REST endpoint root if not default - e.g. http://localhost:8080/admin");
out.println();
out.println();
out.println("Nested attributes are supported by using '.' to separate components of a KEY. Optionaly, the KEY components ");
out.println("Nested attributes are supported by using '.' to separate components of a KEY. Optionally, the KEY components ");
out.println("can be quoted with double quotes - e.g. my_client.attributes.\"external.user.id\". If VALUE starts with [ and ");
out.println("ends with ] the attribute will be set as a JSON array. If VALUE starts with { and ends with } the attribute ");
out.println("will be set as a JSON object. If KEY ends with an array index - e.g. clients[3]=VALUE - then the specified item");

2
integration/client-cli/admin-cli/src/main/java/org/keycloak/client/registration/cli/commands/CreateCmd.java
View file

@ -173,7 +173,7 @@ public class CreateCmd extends AbstractAuthOptionsCmd {
printOut("Response from server: " + readFully(response));
}
} catch (UnrecognizedPropertyException e) {
throw new RuntimeException("Failed to process HTTP reponse - " + e.getMessage(), e);
throw new RuntimeException("Failed to process HTTP response - " + e.getMessage(), e);
} catch (IOException e) {
throw new RuntimeException("Failed to process HTTP response", e);
}

2
integration/client-cli/admin-cli/src/main/java/org/keycloak/client/registration/cli/commands/UpdateCmd.java
View file

@ -350,7 +350,7 @@ public class UpdateCmd extends AbstractAuthOptionsCmd {
out.println(" -c, --compressed Don't pretty print the output");
out.println();
out.println();
out.println("Nested attributes are supported by using '.' to separate components of a KEY. Optionaly, the KEY components ");
out.println("Nested attributes are supported by using '.' to separate components of a KEY. Optionally, the KEY components ");
out.println("can be quoted with double quotes - e.g. my_client.attributes.\"external.user.id\". If VALUE starts with [ and ");
out.println("ends with ] the attribute will be set as a JSON array. If VALUE starts with { and ends with } the attribute ");
out.println("will be set as a JSON object. If KEY ends with an array index - e.g. clients[3]=VALUE - then the specified item");

2
integration/client-cli/admin-cli/src/main/java/org/keycloak/client/registration/cli/commands/UpdateTokenCmd.java
View file

@ -129,7 +129,7 @@ public class UpdateTokenCmd extends AbstractAuthOptionsCmd {
out.println("Usage: " + CMD + " update-token CLIENT [ARGUMENTS]");
out.println();
out.println("Command to reissue, and set a new registration access token if an old one is lost or becomes invalid.");
out.println("It requires an authenticated session using an account with administrator priviliges.");
out.println("It requires an authenticated session using an account with administrator privileges.");
out.println();
out.println("Arguments:");
out.println();

2
model/infinispan/src/main/java/org/keycloak/models/sessions/infinispan/initializer/InfinispanCacheInitializer.java
View file

@ -133,7 +133,7 @@ public class InfinispanCacheInitializer extends BaseCacheInitializer {
}
if (errors >= maxErrors) {
throw new RuntimeException("Maximum count of worker errors occured. Limit was " + maxErrors + ". See server.log for details");
throw new RuntimeException("Maximum count of worker errors occurred. Limit was " + maxErrors + ". See server.log for details");
}
if (!anyFailure) {

2
quarkus/config-api/src/main/java/org/keycloak/config/LoggingOptions.java
View file

@ -204,7 +204,7 @@ public class LoggingOptions {
public static final Option<Boolean> LOG_GELF_INCLUDE_STACK_TRACE = new OptionBuilder<>("log-gelf-include-stack-trace", Boolean.class)
.category(OptionCategory.LOGGING)
.description("If set to true, occuring stack traces are included in the 'StackTrace' field in the GELF output.")
.description("If set to true, occurring stack traces are included in the 'StackTrace' field in the GELF output.")
.defaultValue(Boolean.TRUE)
.deprecated()
.build();

4
quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testExportHelpAll.approved.txt vendored
View file

@ -153,7 +153,7 @@ Logging:
DEPRECATED. Include message parameters from the log event. Default: true.
Available only when GELF is activated.
--log-gelf-include-stack-trace <true|false>
DEPRECATED. If set to true, occuring stack traces are included in the
DEPRECATED. If set to true, occurring stack traces are included in the
'StackTrace' field in the GELF output. Default: true. Available only when
GELF is activated.
--log-gelf-level <level>
@ -217,4 +217,4 @@ Export:
--users-per-file <number>
Set the number of users per file. It is used only if 'users' is set to
'different_files'. Increasing this number leads to exponentially increasing
export times. Default: 50.
export times. Default: 50.

4
quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testImportHelpAll.approved.txt vendored
View file

@ -153,7 +153,7 @@ Logging:
DEPRECATED. Include message parameters from the log event. Default: true.
Available only when GELF is activated.
--log-gelf-include-stack-trace <true|false>
DEPRECATED. If set to true, occuring stack traces are included in the
DEPRECATED. If set to true, occurring stack traces are included in the
'StackTrace' field in the GELF output. Default: true. Available only when
GELF is activated.
--log-gelf-level <level>
@ -211,4 +211,4 @@ Import:
--file <file> Set the path to a file that will be read.
--override <true|false>
Set if existing data should be overwritten. If set to false, data will be
ignored. Default: true.
ignored. Default: true.

4
quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testStartDevHelpAll.approved.txt vendored
View file

@ -366,7 +366,7 @@ Logging:
DEPRECATED. Include message parameters from the log event. Default: true.
Available only when GELF is activated.
--log-gelf-include-stack-trace <true|false>
DEPRECATED. If set to true, occuring stack traces are included in the
DEPRECATED. If set to true, occurring stack traces are included in the
'StackTrace' field in the GELF output. Default: true. Available only when
GELF is activated.
--log-gelf-level <level>
@ -430,4 +430,4 @@ Security:
Do NOT start the server using this command when deploying to production.
Use 'kc.sh start-dev --help-all' to list all available options, including build
options.
options.

4
quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testStartHelpAll.approved.txt vendored
View file

@ -367,7 +367,7 @@ Logging:
DEPRECATED. Include message parameters from the log event. Default: true.
Available only when GELF is activated.
--log-gelf-include-stack-trace <true|false>
DEPRECATED. If set to true, occuring stack traces are included in the
DEPRECATED. If set to true, occurring stack traces are included in the
'StackTrace' field in the GELF output. Default: true. Available only when
GELF is activated.
--log-gelf-level <level>
@ -435,4 +435,4 @@ By default, this command tries to update the server configuration by running a
$ kc.sh start '--optimized'
By doing that, the server should start faster based on any previous
configuration you have set when manually running the 'build' command.
configuration you have set when manually running the 'build' command.

4
quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testStartOptimizedHelpAll.approved.txt vendored
View file

@ -318,7 +318,7 @@ Logging:
DEPRECATED. Include message parameters from the log event. Default: true.
Available only when GELF is activated.
--log-gelf-include-stack-trace <true|false>
DEPRECATED. If set to true, occuring stack traces are included in the
DEPRECATED. If set to true, occurring stack traces are included in the
'StackTrace' field in the GELF output. Default: true. Available only when
GELF is activated.
--log-gelf-level <level>
@ -377,4 +377,4 @@ By default, this command tries to update the server configuration by running a
$ kc.sh start '--optimized'
By doing that, the server should start faster based on any previous
configuration you have set when manually running the 'build' command.
configuration you have set when manually running the 'build' command.

2
saml-core/src/main/java/org/keycloak/saml/common/DefaultPicketLinkLogger.java
View file

@ -2366,7 +2366,7 @@ public class DefaultPicketLinkLogger implements PicketLinkLogger {
@Override
public RuntimeException maximumNumberOfClientsReachedforPool(String max) {
return new RuntimeException("Pool reached miximum number of clients within the pool (" + max + ")");
return new RuntimeException("Pool reached maximum number of clients within the pool (" + max + ")");
}
@Override

2
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/adapter/servlet/SAMLServletSessionTimeoutTest.java
View file

@ -148,7 +148,7 @@ public class SAMLServletSessionTimeoutTest extends AbstractSAMLServletAdapterTes
AuthnStatementType authType = (AuthnStatementType) statements.stream()
.filter(statement -> statement instanceof AuthnStatementType)
.findFirst().orElseThrow(() -> new RuntimeException("SamlReponse doesn't contain AuthStatement"));
.findFirst().orElseThrow(() -> new RuntimeException("SamlResponse doesn't contain AuthStatement"));
assertThat(authType.getSessionNotOnOrAfter(), notNullValue());
XMLGregorianCalendar expectedSessionTimeout = XMLTimeUtil.add(authType.getAuthnInstant(), SESSION_LENGTH_IN_SECONDS * 1000);