From 6427a15d1bc01444018494766c44efdb3028bb45 Mon Sep 17 00:00:00 2001
From: Erik Jan de Wit <edewit@redhat.com>
Date: Thu, 17 Feb 2022 15:42:35 +0100
Subject: [PATCH] set default for allowCreate and readonly for select (#2034)

fixes: #1939
---
 src/identity-providers/add/AddSamlConnect.tsx     | 2 +-
 src/identity-providers/add/DescriptorSettings.tsx | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/identity-providers/add/AddSamlConnect.tsx b/src/identity-providers/add/AddSamlConnect.tsx
index 2e95d214d9..be6e11741b 100644
--- a/src/identity-providers/add/AddSamlConnect.tsx
+++ b/src/identity-providers/add/AddSamlConnect.tsx
@@ -30,7 +30,7 @@ export default function AddSamlConnect() {
   const id = "saml";
 
   const form = useForm<DiscoveryIdentityProvider>({
-    defaultValues: { alias: id },
+    defaultValues: { alias: id, config: { allowCreate: "true" } },
   });
   const {
     handleSubmit,
diff --git a/src/identity-providers/add/DescriptorSettings.tsx b/src/identity-providers/add/DescriptorSettings.tsx
index 27bed81d04..6aee5f3537 100644
--- a/src/identity-providers/add/DescriptorSettings.tsx
+++ b/src/identity-providers/add/DescriptorSettings.tsx
@@ -156,6 +156,7 @@ const Fields = ({ readOnly }: DescriptorSettingsProps) => {
               }}
               selections={value}
               variant={SelectVariant.single}
+              isDisabled={readOnly}
             >
               <SelectOption
                 data-testid="persistent-option"
@@ -236,6 +237,7 @@ const Fields = ({ readOnly }: DescriptorSettingsProps) => {
               }}
               selections={value}
               variant={SelectVariant.single}
+              isDisabled={readOnly}
             >
               <SelectOption
                 data-testid="subjectNameId-option"
@@ -340,6 +342,7 @@ const Fields = ({ readOnly }: DescriptorSettingsProps) => {
                   }}
                   selections={value}
                   variant={SelectVariant.single}
+                  isDisabled={readOnly}
                 >
                   <SelectOption value="RSA_SHA1" />
                   <SelectOption value="RSA_SHA256" isPlaceholder />
@@ -378,6 +381,7 @@ const Fields = ({ readOnly }: DescriptorSettingsProps) => {
                   }}
                   selections={value}
                   variant={SelectVariant.single}
+                  isDisabled={readOnly}
                 >
                   <SelectOption value="NONE" />
                   <SelectOption value={t("keyID")} isPlaceholder />