From 50548491f5e5f4f29b2ba86453b75bdf12cb3040 Mon Sep 17 00:00:00 2001
From: mfrances17 <39063664+mfrances17@users.noreply.github.com>
Date: Wed, 10 Nov 2021 04:56:39 -0500
Subject: [PATCH] add missing field and change default (#1512)

---
 src/user-federation/help.ts                   |  2 ++
 .../ldap/mappers/LdapMapperUserAttribute.tsx  | 21 ++++++++++++++++++-
 src/user-federation/messages.ts               |  1 +
 3 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/src/user-federation/help.ts b/src/user-federation/help.ts
index fe2fa1ce80..4941dcdea2 100644
--- a/src/user-federation/help.ts
+++ b/src/user-federation/help.ts
@@ -147,6 +147,8 @@ export default {
       "If on, then during reading of the LDAP attribute value will always used instead of the value from Keycloak DB.",
     isMandatoryInLdapHelp:
       "If true, attribute is mandatory in LDAP. Hence if there is no value in Keycloak DB, the empty value will be set to be propagated to LDAP.",
+    attributeDefaultValueHelp:
+      "If there is no value in Keycloak DB and attribute is mandatory in LDAP, this value will be propagated to LDAP.",
     isBinaryAttributeHelp: "Should be true for binary LDAP attributes.",
 
     derFormattedHelp:
diff --git a/src/user-federation/ldap/mappers/LdapMapperUserAttribute.tsx b/src/user-federation/ldap/mappers/LdapMapperUserAttribute.tsx
index e1a5b4300b..ddc59e23e5 100644
--- a/src/user-federation/ldap/mappers/LdapMapperUserAttribute.tsx
+++ b/src/user-federation/ldap/mappers/LdapMapperUserAttribute.tsx
@@ -74,7 +74,7 @@ export const LdapMapperUserAttribute = ({
       >
         <Controller
           name="config.read-only"
-          defaultValue={["false"]}
+          defaultValue={["true"]}
           control={form.control}
           render={({ onChange, value }) => (
             <Switch
@@ -144,6 +144,25 @@ export const LdapMapperUserAttribute = ({
           )}
         ></Controller>
       </FormGroup>
+      <FormGroup
+        label={t("attributeDefaultValue")}
+        labelIcon={
+          <HelpItem
+            helpText={helpText("attributeDefaultValueHelp")}
+            forLabel={t("attributeDefaultValue")}
+            forID="kc-attribute-default-value"
+          />
+        }
+        fieldId="kc-attribute-default-value"
+      >
+        <TextInput
+          type="text"
+          id="kc-attribute-default-value"
+          data-testid="mapper-attributeDefaultValue-fld"
+          name="config.attribute-default-value[0]"
+          ref={form.register}
+        />
+      </FormGroup>
       <FormGroup
         label={t("isBinaryAttribute")}
         labelIcon={
diff --git a/src/user-federation/messages.ts b/src/user-federation/messages.ts
index 904d445174..7f9e866796 100644
--- a/src/user-federation/messages.ts
+++ b/src/user-federation/messages.ts
@@ -188,6 +188,7 @@ export default {
     readOnly: "Read only",
     alwaysReadValueFromLdap: "Always read value from LDAP",
     isMandatoryInLdap: "Is mandatory in LDAP",
+    attributeDefaultValue: "Attribute default value",
     isBinaryAttribute: "Is binary attribute",
     derFormatted: "DER formatted",