From 4ec40a52a681598df035b8b41b297d98f2fabaf4 Mon Sep 17 00:00:00 2001
From: agagancarczyk <agagancarczyk@gmail.com>
Date: Thu, 23 Jun 2022 11:50:24 +0100
Subject: [PATCH] Critical accessibility fixes for User federation page - Issue
 #2848 (#2867)

* added form labels

* fixed labels

* fix

Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>
---
 public/resources/en/user-federation.json                  | 7 ++++++-
 src/user-federation/ManagePriorityDialog.tsx              | 2 +-
 src/user-federation/kerberos/KerberosSettingsRequired.tsx | 7 +++++++
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/public/resources/en/user-federation.json b/public/resources/en/user-federation.json
index 646673cfe7..7c13b5c2b0 100644
--- a/public/resources/en/user-federation.json
+++ b/public/resources/en/user-federation.json
@@ -164,5 +164,10 @@
   "userModelAttributeName": "User model attribute name",
   "attributeValue": "Attribute value",
   "selectRole": "Select role",
-  "group": "Group"
+  "group": "Group",
+  "providerId": "Provider ID",
+  "providerType": "Provider Type",
+  "parentId": "Parent ID",
+  "kerberosPrincipal": "Kerberos Principal",
+  "kerberosKeyTab": "Kerberos Key Tab"
 }
diff --git a/src/user-federation/ManagePriorityDialog.tsx b/src/user-federation/ManagePriorityDialog.tsx
index 3ba855b7ce..6cf7623f28 100644
--- a/src/user-federation/ManagePriorityDialog.tsx
+++ b/src/user-federation/ManagePriorityDialog.tsx
@@ -113,7 +113,7 @@ export const ManagePriorityDialog = ({
         {sortBy(components, "config.priority").map((component) => (
           <DataListItem
             aria-labelledby={component.name}
-            id={component.name}
+            id={`${component.name}-item`}
             key={component.name}
           >
             <DataListItemRow>
diff --git a/src/user-federation/kerberos/KerberosSettingsRequired.tsx b/src/user-federation/kerberos/KerberosSettingsRequired.tsx
index 7eda8dadce..a7ac01a3d0 100644
--- a/src/user-federation/kerberos/KerberosSettingsRequired.tsx
+++ b/src/user-federation/kerberos/KerberosSettingsRequired.tsx
@@ -81,6 +81,7 @@ export const KerberosSettingsRequired = ({
             name="providerId"
             defaultValue="kerberos"
             ref={form.register}
+            aria-label={t("providerId")}
           />
           <KeycloakTextInput
             hidden
@@ -89,6 +90,7 @@ export const KerberosSettingsRequired = ({
             name="providerType"
             defaultValue="org.keycloak.storage.UserStorageProvider"
             ref={form.register}
+            aria-label={t("providerType")}
           />
           <KeycloakTextInput
             hidden
@@ -97,6 +99,7 @@ export const KerberosSettingsRequired = ({
             name="parentId"
             defaultValue={realm}
             ref={form.register}
+            aria-label={t("parentId")}
           />
 
           <KeycloakTextInput
@@ -112,6 +115,7 @@ export const KerberosSettingsRequired = ({
             })}
             data-testid="kerberos-name"
             validated={form.errors.name ? "error" : "default"}
+            aria-label={t("consoleDisplayName")}
           />
         </FormGroup>
 
@@ -142,6 +146,7 @@ export const KerberosSettingsRequired = ({
               },
             })}
             data-testid="kerberos-realm"
+            aria-label={t("kerberosRealm")}
             validated={
               form.errors.config?.kerberosRealm?.[0] ? "error" : "default"
             }
@@ -175,6 +180,7 @@ export const KerberosSettingsRequired = ({
               },
             })}
             data-testid="kerberos-principal"
+            aria-label={t("kerberosPrincipal")}
             validated={
               form.errors.config?.serverPrincipal?.[0] ? "error" : "default"
             }
@@ -206,6 +212,7 @@ export const KerberosSettingsRequired = ({
               },
             })}
             data-testid="kerberos-keytab"
+            aria-label={t("kerberosKeyTab")}
             validated={form.errors.config?.keyTab?.[0] ? "error" : "default"}
           />
         </FormGroup>