Merge pull request #190 from matzew/clean-up

Clean up
This commit is contained in:
Bill Burke 2014-02-05 10:34:01 -05:00
commit 48b3b9a7fc
8 changed files with 6 additions and 64 deletions

View file

@ -27,7 +27,7 @@ import org.jboss.dmr.ModelNode;
*
* @author Stan Silvert ssilvert@redhat.com (C) 2014 Red Hat Inc.
*/
public class CredentialRemoveHandler extends AbstractRemoveStepHandler {
public final class CredentialRemoveHandler extends AbstractRemoveStepHandler {
public static CredentialRemoveHandler INSTANCE = new CredentialRemoveHandler();

View file

@ -38,7 +38,7 @@ import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.ADD
*
* @author Stan Silvert ssilvert@redhat.com (C) 2013 Red Hat Inc.
*/
public class KeycloakAdapterConfigService implements Service<KeycloakAdapterConfigService> {
public final class KeycloakAdapterConfigService implements Service<KeycloakAdapterConfigService> {
private static final String CREDENTIALS_JSON_NAME = "credentials";
// Right now this is used as a service, but I'm not sure it really needs to be implemented that way.

View file

@ -34,7 +34,7 @@ import org.jboss.msc.service.ServiceController;
*
* @author Stan Silvert ssilvert@redhat.com (C) 2013 Red Hat Inc.
*/
public class RealmAddHandler extends AbstractAddStepHandler {
public final class RealmAddHandler extends AbstractAddStepHandler {
public static RealmAddHandler INSTANCE = new RealmAddHandler();

View file

@ -27,7 +27,7 @@ import org.jboss.dmr.ModelNode;
*
* @author Stan Silvert ssilvert@redhat.com (C) 2013 Red Hat Inc.
*/
public class RealmRemoveHandler extends AbstractRemoveStepHandler {
public final class RealmRemoveHandler extends AbstractRemoveStepHandler {
public static RealmRemoveHandler INSTANCE = new RealmRemoveHandler();

View file

@ -34,7 +34,7 @@ import org.jboss.msc.service.ServiceController;
*
* @author Stan Silvert ssilvert@redhat.com (C) 2013 Red Hat Inc.
*/
public class SecureDeploymentAddHandler extends AbstractAddStepHandler {
public final class SecureDeploymentAddHandler extends AbstractAddStepHandler {
public static SecureDeploymentAddHandler INSTANCE = new SecureDeploymentAddHandler();

View file

@ -27,7 +27,7 @@ import org.jboss.dmr.ModelNode;
*
* @author Stan Silvert ssilvert@redhat.com (C) 2013 Red Hat Inc.
*/
public class SecureDeploymentRemoveHandler extends AbstractRemoveStepHandler {
public final class SecureDeploymentRemoveHandler extends AbstractRemoveStepHandler {
public static SecureDeploymentRemoveHandler INSTANCE = new SecureDeploymentRemoveHandler();

View file

@ -16,17 +16,9 @@
*/
package org.keycloak.subsystem.logging;
import java.util.List;
import org.jboss.logging.BasicLogger;
import org.jboss.logging.annotations.LogMessage;
import org.jboss.logging.Logger;
import org.jboss.logging.annotations.Message;
import org.jboss.logging.annotations.MessageLogger;
import org.jboss.vfs.VirtualFile;
import static org.jboss.logging.Logger.Level.ERROR;
import static org.jboss.logging.Logger.Level.INFO;
import static org.jboss.logging.Logger.Level.WARN;
/**
* This interface to be fleshed out later when error messages are fully externalized.
@ -41,27 +33,4 @@ public interface KeycloakLogger extends BasicLogger {
*/
KeycloakLogger ROOT_LOGGER = Logger.getMessageLogger(KeycloakLogger.class, "org.jboss.keycloak");
/* @LogMessage(level = ERROR)
@Message(id = 12600, value = "Could not load JSF managed bean class: %s")
void managedBeanLoadFail(String managedBean);
@LogMessage(level = ERROR)
@Message(id = 12601, value = "JSF managed bean class %s has no default constructor")
void managedBeanNoDefaultConstructor(String managedBean);
@LogMessage(level = ERROR)
@Message(id = 12602, value = "Failed to parse %s, managed beans defined in this file will not be available")
void managedBeansConfigParseFailed(VirtualFile facesConfig);
@LogMessage(level = WARN)
@Message(id = 12603, value = "Unknown JSF version '%s'. Default version '%s' will be used instead.")
void unknownJSFVersion(String version, String defaultVersion);
@LogMessage(level = WARN)
@Message(id = 12604, value = "JSF version slot '%s' is missing from module %s")
void missingJSFModule(String version, String module);
@LogMessage(level = INFO)
@Message(id = 12605, value = "Activated the following JSF Implementations: %s")
void activatedJSFImplementations(List target); */
}

View file

@ -16,11 +16,6 @@
*/
package org.keycloak.subsystem.logging;
import org.jboss.as.server.deployment.DeploymentUnitProcessingException;
import org.jboss.jandex.AnnotationTarget;
import org.jboss.jandex.DotName;
import org.jboss.logging.annotations.Cause;
import org.jboss.logging.annotations.Message;
import org.jboss.logging.annotations.MessageBundle;
import org.jboss.logging.Messages;
@ -36,26 +31,4 @@ public interface KeycloakMessages {
* The messages
*/
KeycloakMessages MESSAGES = Messages.getBundle(KeycloakMessages.class);
/*
@Message(id = 12650, value = "Failed to load annotated class: %s")
String classLoadingFailed(DotName clazz);
@Message(id = 12651, value = "Annotation %s in class %s is only allowed on classes")
String invalidAnnotationLocation(Object annotation, AnnotationTarget classInfo);
@Message(id = 12652, value = "Instance creation failed")
RuntimeException instanceCreationFailed(@Cause Throwable t);
@Message(id = 12653, value = "Instance destruction failed")
RuntimeException instanceDestructionFailed(@Cause Throwable t);
@Message(id = 12654, value = "Thread local injection container not set")
IllegalStateException noThreadLocalInjectionContainer();
@Message(id = 12655, value = "@ManagedBean is only allowed at class level %s")
String invalidManagedBeanAnnotation(AnnotationTarget target);
@Message(id = 12656, value = "Default JSF implementation slot '%s' is invalid")
DeploymentUnitProcessingException invalidDefaultJSFImpl(String defaultJsfVersion);
*/
}