libre.sh/keycloak-scim
3
0
Fork 0
Code Issues 15 Pull requests Releases 1 Packages Activity Actions

Critical accessibility fixes for Identity providers page (#2871)

Browse source 
* added labels and fixed Ids

* fixed id

* changed id

* fixed id

* removed aria-label

Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>
This commit is contained in:
agagancarczyk 2022-06-27 16:09:47 +01:00 committed by GitHub
parent 8dd40ccc15
commit 489f7ba98b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/identity-providers/ManageOrderDialog.tsx
View file

@ -114,7 +114,7 @@ export const ManageOrderDialog = ({
{sortBy(providers, "config.guiOrder").map((provider) => ( {sortBy(providers, "config.guiOrder").map((provider) => (
<DataListItem <DataListItem
aria-labelledby={provider.alias} aria-labelledby={provider.alias}
id={provider.alias} id={`${provider.alias}-item`}
key={provider.alias} key={provider.alias}
> >
<DataListItemRow> <DataListItemRow>

4
src/identity-providers/add/DescriptorSettings.tsx
View file

@ -58,7 +58,7 @@ const Fields = ({ readOnly }: DescriptorSettingsProps) => {
<div className="pf-c-form pf-m-horizontal"> <div className="pf-c-form pf-m-horizontal">
<FormGroup <FormGroup
label={t("serviceProviderEntityId")} label={t("serviceProviderEntityId")}
fieldId="kc-service-provider-entity-id" fieldId="kc-saml-service-provider-entity-id"
labelIcon={ labelIcon={
<HelpItem <HelpItem
helpText="identity-providers-help:serviceProviderEntityId" helpText="identity-providers-help:serviceProviderEntityId"
@ -70,7 +70,7 @@ const Fields = ({ readOnly }: DescriptorSettingsProps) => {
type="text" type="text"
name="config.entityId" name="config.entityId"
data-testid="serviceProviderEntityId" data-testid="serviceProviderEntityId"
id="kc-service-provider-entity-id" id="kc-saml-service-provider-entity-id"
ref={register()} ref={register()}
/> />
</FormGroup> </FormGroup>

2
src/identity-providers/component/DisplayOrder.tsx
View file

@ -27,7 +27,7 @@ export const DisplayOrder = () => {
defaultValue="" defaultValue=""
render={({ onChange, value }) => ( render={({ onChange, value }) => (
<TextInput <TextInput
id="displayOrder" id="kc-display-order"
type="number" type="number"
value={value} value={value}
data-testid="displayOrder" data-testid="displayOrder"