wip: realm_test fix/improvement attempt (#2446)

* test fix attempt

* test fix attempt 2

* test fix attempt 3

* test fix attempt 4

* test fix attempt 4

* cleanup

* fix for client test

* fix attempt 5

Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>

cypress/integration/realm_test.spec.ts

@@ -66,6 +66,7 @@ describe("Realms test", () => {
 
     it("should create Test Disabled realm", () => {
       sidebarPage.goToCreateRealm();
+      sidebarPage.waitForPageLoad();
       createRealmPage.fillRealmName("Test Disabled").createRealm();
       createRealmPage.disableRealm();
 

cypress/support/pages/admin_console/CreateRealmPage.ts

@@ -1,8 +1,6 @@
 export default class CreateRealmPage {
-  private browseBtn = "#kc-realm-filename-browse-button";
   private clearBtn = ".pf-c-file-upload__file-select button:last-child";
   private modalClearBtn = "clear-button";
-  private realmFileNameInput = "#kc-realm-filename";
   private realmNameInput = "#kc-realm-name";
   private enabledSwitch =
     '[for="kc-realm-enabled-switch"] span.pf-c-switch__toggle';

cypress/support/pages/admin_console/ListingPage.ts

@@ -34,7 +34,6 @@ export default class ListingPage {
   private emptyListImg =
     '[role="tabpanel"]:not([hidden]) [data-testid="empty-state"]';
   public emptyState = "empty-state";
-  private progressBar = '[role="progressbar"]';
   private itemRowDrpDwn = ".pf-c-dropdown__toggle";
   private itemRowSelect = ".pf-c-select__toggle:nth-child(1)";
   private itemRowSelectItem = ".pf-c-select__menu-item";

cypress/support/pages/admin_console/Masthead.ts

@@ -1,5 +1,4 @@
 export default class Masthead {
-  private menuBtn = "#nav-toggle";
   private logoBtn = "#masthead-logo";
   private helpBtn = "#help";
   private closeAlertMessageBtn = ".pf-c-alert__action button";

cypress/support/pages/admin_console/manage/clients/ClientRolesTab.ts

@@ -1,7 +1,6 @@
 export default class ClientRolesTab {
   private createRoleBtn = "create-role";
   private createRoleEmptyStateBtn = "no-roles-for-this-client-empty-action";
-  private actionsDropdown = `[aria-label="Actions"]`;
   private hideInheritedRolesChkBox = "#kc-hide-inherited-roles-checkbox";
 
   private rolesTab = "rolesTab";

cypress/support/pages/admin_console/manage/clients/CreateClientPage.ts

@@ -1,6 +1,5 @@
 export default class CreateClientPage {
   private clientTypeDrpDwn = ".pf-c-select__toggle";
-  private clientTypeError = ".pf-c-select + div";
   private clientTypeList = ".pf-c-select__toggle + ul";
   private clientIdInput = "#kc-client-id";
   private clientIdError = "#kc-client-id + div";
@@ -44,8 +43,6 @@ export default class CreateClientPage {
   private frontChannelLogoutSwitchInput = "#frontchannelLogout";
   private frontChannelLogoutInput = "#frontchannelLogoutUrl";
   private backChannelLogoutInput = "#backchannelLogoutUrl";
-  private backChannelLogoutRequiredSwitch =
-    '[for="backchannelLogoutSessionRequired"] > .pf-c-switch__toggle';
   private backChannelLogoutRequiredSwitchInput =
     "#backchannelLogoutSessionRequired";
   private backChannelLogoutRevoqueSwitch =

cypress/support/pages/admin_console/manage/identity_providers/AddMapperPage.ts

@@ -6,13 +6,10 @@ export default class AddMapperPage {
   private addMapperButton = "#add-mapper-button";
 
   private mapperNameInput = "#kc-name";
-  private mapperRoleInput = "mapper-role-input";
   private attribute = "user.attribute";
   private attributeName = "attribute.name";
   private attributeFriendlyName = "attribute.friendly.name";
-  private attributeValue = "attribute-value";
   private claimInput = "claim";
-  private claimValueInput = "claim-value-input";
   private socialProfileJSONfieldPath = "jsonField";
   private userAttribute = "attribute";
   private userAttributeName = "userAttribute";
@@ -26,7 +23,6 @@ export default class AddMapperPage {
   private attributesValueInput = 'input[name="config.attributes[0].value"]';
   private template = "template";
   private target = "#target";
-  private targetDropdown = "#target-dropdown";
 
   goToMappersTab() {
     cy.findByTestId(this.mappersTab).click();

cypress/support/pages/admin_console/manage/identity_providers/CreateProviderPage.ts

@@ -1,6 +1,5 @@
 export default class CreateProviderPage {
   private github = "github";
-  private addProviderDropdown = "addProviderDropdown";
   private clientIdField = "clientId";
   private clientIdError = "#kc-client-secret-helper";
   private clientSecretField = "clientSecret";

cypress/support/pages/admin_console/manage/realm_roles/AssociatedRolesPage.ts

@@ -2,7 +2,6 @@ export default class AssociatedRolesPage {
   private actionDropdown = "action-dropdown";
   private addRolesDropdownItem = "add-roles";
   private addRoleToolbarButton = "add-role-button";
-  private checkbox = "[type=checkbox]";
   private addAssociatedRolesModalButton = "add-associated-roles-button";
   private compositeRoleBadge = "composite-role-badge";
   private filterTypeDropdown = "filter-type-dropdown";

cypress/support/pages/admin_console/manage/realm_settings/RealmSettingsPage.ts

@@ -169,8 +169,6 @@ export default class RealmSettingsPage {
   private saveNewClientPolicyBtn = "saveCreatePolicy";
   private cancelNewClientPolicyBtn = "cancelCreatePolicy";
   private alertMessage = ".pf-c-alert__title";
-  private moreDrpDwn = ".pf-c-dropdown__toggle.pf-m-plain";
-  private moreDrpDwnItems = ".pf-c-dropdown__menu-item";
   private modalDialogTitle = ".pf-c-modal-box__title-text";
   private modalDialogBodyText = ".pf-c-modal-box__body";
   private deleteDialogCancelBtn = "#modal-cancel";
@@ -178,7 +176,6 @@ export default class RealmSettingsPage {
   private jsonEditorSavePoliciesBtn = "jsonEditor-policies-saveBtn";
   private jsonEditorReloadBtn = "jsonEditor-reloadBtn";
   private jsonEditor = ".monaco-scrollable-element.editor-scrollable.vs";
-  private createClientDrpDwn = ".pf-c-dropdown.pf-m-align-right";
   private clientPolicyDrpDwn = '[data-testid="action-dropdown"] button';
   private deleteclientPolicyDrpDwn = "deleteClientPolicyDropdown";
   private clientProfileOne =
@@ -204,7 +201,6 @@ export default class RealmSettingsPage {
   private addConditionDrpDwnOption = "conditionType-select";
   private addConditionCancelBtn = "addCondition-cancelBtn";
   private addConditionSaveBtn = "addCondition-saveBtn";
-  private conditionTypeLink = "condition-type-link";
   private clientRolesConditionLink = "client-roles-condition-link";
   private clientScopesConditionLink = "client-scopes-condition-link";
   private eventListenersFormLabel = ".pf-c-form__label-text";
@@ -222,7 +218,6 @@ export default class RealmSettingsPage {
   private deleteClientRolesConditionBtn = "delete-client-roles-condition";
   private deleteClientScopesConditionBtn = "delete-client-scopes-condition";
   private realmDisplayName = "#kc-display-name";
-  private displayNameHTML = "#kc-html-display-name";
   private frontEndURL = "#kc-frontend-url";
   private requireSSL = "#kc-require-ssl";