Update CONTRIBUTING.md

This commit is contained in:
Stian Thorgersen 2019-02-21 12:28:06 +01:00 committed by GitHub
parent 7adde410ac
commit 3a4e768555
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -63,12 +63,6 @@ Do not format or refactor code that is not directly related to your contribution
increase our effort in reviewing your PR. If you have a strong need to refactor code then submit a separate PR for the increase our effort in reviewing your PR. If you have a strong need to refactor code then submit a separate PR for the
refactoring. refactoring.
### Documentation
We require contributions to include relevant documentation. Alongside your PR for code changes, prepare a PR to the [Keycloak Documentation](https://github.com/keycloak/keycloak-documentation).
In the description of your PR include a link to the PR to [Keycloak Documentation](https://github.com/keycloak/keycloak-documentation).
### Testing ### Testing
Details for implementing tests are provided in the [writing tests](docs/tests-development.md) guide. Details for implementing tests are provided in the [writing tests](docs/tests-development.md) guide.
@ -76,6 +70,12 @@ Details for implementing tests are provided in the [writing tests](docs/tests-de
Do not add mock frameworks or other testing frameworks that are not already part of the testsuite. Please write tests Do not add mock frameworks or other testing frameworks that are not already part of the testsuite. Please write tests
in the same way as we have written our tests. in the same way as we have written our tests.
### Documentation
We require contributions to include relevant documentation. Alongside your PR for code changes, prepare a PR to the [Keycloak Documentation](https://github.com/keycloak/keycloak-documentation).
In the description of your PR include a link to the PR to [Keycloak Documentation](https://github.com/keycloak/keycloak-documentation).
### Submitting your PR ### Submitting your PR
When preparing your PR make sure you have a single commit and your branch is rebased on the master branch from the When preparing your PR make sure you have a single commit and your branch is rebased on the master branch from the