libre.sh/keycloak-scim
3
0
Fork 0
Code Issues 15 Pull requests Releases Packages Activity Actions

Allow users with 'view-users' permission to see the 'credentials' tab (#19587)

Browse source 
Closes #17174
This commit is contained in:
eatikrh 2023-04-07 07:13:43 -05:00 committed by GitHub
parent 2c663c2fcc
commit 396e2ba931
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
js/apps/admin-ui/src/user/EditUser.tsx
View file

@ -233,7 +233,7 @@ const EditUserForm = ({ user, bruteForced, refresh }: EditUserFormProps) => {
</Tab> </Tab>
<Tab <Tab
data-testid="credentials" data-testid="credentials"
isHidden={!user.access?.manage} isHidden={!user.access?.view}
title={<TabTitleText>{t("common:credentials")}</TabTitleText>} title={<TabTitleText>{t("common:credentials")}</TabTitleText>}
{...credentialsTab} {...credentialsTab}
> >

2
services/src/main/java/org/keycloak/services/resources/admin/UserResource.java
View file

@ -651,7 +651,7 @@ public class UserResource {
@NoCache @NoCache
@Produces(MediaType.APPLICATION_JSON) @Produces(MediaType.APPLICATION_JSON)
public Stream<CredentialRepresentation> credentials(){ public Stream<CredentialRepresentation> credentials(){
auth.users().requireManage(user); auth.users().requireView(user);
return user.credentialManager().getStoredCredentialsStream() return user.credentialManager().getStoredCredentialsStream()
.map(ModelToRepresentation::toRepresentation) .map(ModelToRepresentation::toRepresentation)
.peek(credentialRepresentation -> credentialRepresentation.setSecretData(null)); .peek(credentialRepresentation -> credentialRepresentation.setSecretData(null));