libre.sh/keycloak-scim
3
0
Fork 0
Code Issues 15 Pull requests Releases Packages Activity Actions

Flaky Test ResetPasswordTest.resetPasswordLoggedUser:188->openResetPasswordUrlAndDoFlow:252

Browse source 
Closes #34023

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
This commit is contained in:
Douglas Palmer 2024-10-16 16:49:50 -07:00 committed by Marek Posolda
parent 6c65ad83fb
commit 2dd754533d
2 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/pages/LogoutSessionsPage.java
View file

@ -47,11 +47,11 @@ public abstract class LogoutSessionsPage extends LanguageComboboxAwarePage {
public void checkLogoutSessions() { public void checkLogoutSessions() {
Assert.assertFalse("Logout sessions is checked", isLogoutSessionsChecked()); Assert.assertFalse("Logout sessions is checked", isLogoutSessionsChecked());
logoutSessionsCheckbox.click(); UIUtils.switchCheckbox(logoutSessionsCheckbox, true);
} }
public void uncheckLogoutSessions() { public void uncheckLogoutSessions() {
Assert.assertTrue("Logout sessions is not checked", isLogoutSessionsChecked()); Assert.assertTrue("Logout sessions is not checked", isLogoutSessionsChecked());
logoutSessionsCheckbox.click(); UIUtils.switchCheckbox(logoutSessionsCheckbox, false);
} }
} }

22
testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/util/UIUtils.java
View file

@ -2,7 +2,6 @@ package org.keycloak.testsuite.util;
import org.apache.commons.lang3.StringUtils; import org.apache.commons.lang3.StringUtils;
import org.junit.Assert; import org.junit.Assert;
import org.keycloak.common.util.Retry;
import org.keycloak.testsuite.page.AbstractPatternFlyAlert; import org.keycloak.testsuite.page.AbstractPatternFlyAlert;
import org.openqa.selenium.By; import org.openqa.selenium.By;
import org.openqa.selenium.JavascriptExecutor; import org.openqa.selenium.JavascriptExecutor;
@ -82,15 +81,20 @@ public final class UIUtils {
* @param element The element to click * @param element The element to click
*/ */
public static void clickLink(WebElement element) { public static void clickLink(WebElement element) {
clickElement(element, Keys.ENTER);
}
private static void clickElement(WebElement element, CharSequence key) {
WebDriver driver = getCurrentDriver(); WebDriver driver = getCurrentDriver();
waitUntilElement(element).is().clickable(); waitUntilElement(element).is().clickable();
performOperationWithPageReload(BrowserDriverUtil.isDriverChrome(driver) performOperationWithPageReload(BrowserDriverUtil.isDriverChrome(driver)
? () -> element.sendKeys(Keys.ENTER) ? () -> element.sendKeys(key)
: element::click); : element::click);
} }
/** /**
* The method executes click in the element. This method always uses click and * The method executes click in the element. This method always uses click and
* is not emulated by key pressing in chrome. * is not emulated by key pressing in chrome.
@ -113,15 +117,11 @@ public final class UIUtils {
* @param enable If true, the checkbox should be switched to enabled (checked). If false, the checkbox should be switched to disabled (unchecked) * @param enable If true, the checkbox should be switched to enabled (checked). If false, the checkbox should be switched to disabled (unchecked)
*/ */
public static void switchCheckbox(WebElement checkbox, boolean enable) { public static void switchCheckbox(WebElement checkbox, boolean enable) {
int maxAttempts = 4; boolean current = checkbox.isSelected();
if (current != enable) {
Retry.execute(() -> { clickElement(checkbox, Keys.SPACE);
boolean current = checkbox.isSelected(); Assert.assertNotEquals("Checkbox " + checkbox + " is still in the state " + current + " after click.", current, checkbox.isSelected());
if (current != enable) { }
UIUtils.click(checkbox);
Assert.assertNotEquals("Checkbox " + checkbox + " is still in the state " + current + " after click.", current, checkbox.isSelected());
}
}, maxAttempts, 0);
} }
/** /**