KEYCLOAK-15184: Use static inner class where possible

adapters/oidc/adapter-core/src/main/java/org/keycloak/adapters/authorization/PolicyEnforcer.java

@@ -232,7 +232,7 @@ public class PolicyEnforcer {
         return paths;
     }
 
-    public class PathConfigMatcher extends PathMatcher<PathConfig> {
+    public static class PathConfigMatcher extends PathMatcher<PathConfig> {
 
         private final Map<String, PathConfig> paths;
         private final PathCache pathCache;

adapters/oidc/jetty/jetty-core/src/main/java/org/keycloak/adapters/jetty/core/AbstractKeycloakJettyAuthenticator.java

@@ -136,7 +136,7 @@ public abstract class AbstractKeycloakJettyAuthenticator extends LoginAuthentica
         return new DefaultUserIdentity(theSubject, principal, theRoles);
     }
 
-    private class DummyLoginService implements LoginService {
+    private static class DummyLoginService implements LoginService {
         @Override
         public String getName() {
             return null;

adapters/saml/jetty/jetty-core/src/main/java/org/keycloak/adapters/saml/jetty/AbstractSamlAuthenticator.java

@@ -149,7 +149,7 @@ public abstract class AbstractSamlAuthenticator extends LoginAuthenticator {
 
     }
 
-    private class DummyLoginService implements LoginService {
+    private static class DummyLoginService implements LoginService {
         @Override
         public String getName() {
             return null;

federation/ldap/src/main/java/org/keycloak/storage/ldap/LDAPIdentityStoreRegistry.java

@@ -104,7 +104,7 @@ public class LDAPIdentityStoreRegistry {
     }
 
 
-    private class LDAPIdentityStoreContext {
+    private static class LDAPIdentityStoreContext {
 
         private LDAPIdentityStoreContext(LDAPConfig config, LDAPIdentityStore store) {
             this.config = config;

model/infinispan/src/main/java/org/keycloak/keys/infinispan/InfinispanPublicKeyStorageProviderFactory.java

@@ -146,7 +146,7 @@ public class InfinispanPublicKeyStorageProviderFactory implements PublicKeyStora
         }
     }
 
-    private class SessionAndKeyHolder {
+    private static class SessionAndKeyHolder {
         private final KeycloakSession session;
         private final ArrayList<String> cacheKeys;
 

model/infinispan/src/main/java/org/keycloak/models/sessions/infinispan/events/SessionEventsSenderTransaction.java

@@ -61,7 +61,7 @@ public class SessionEventsSenderTransaction extends AbstractKeycloakTransaction
     }
 
 
-    private class DCEventContext {
+    private static class DCEventContext {
         private final ClusterProvider.DCNotify dcNotify;
         private final SessionClusterEvent event;
 

model/infinispan/src/main/java/org/keycloak/models/sessions/infinispan/remotestore/RemoteCacheInvoker.java

@@ -179,7 +179,7 @@ public class RemoteCacheInvoker {
     }
 
 
-    private class RemoteCacheContext {
+    private static class RemoteCacheContext {
 
         private final RemoteCache remoteCache;
         private final MaxIdleTimeLoader maxIdleTimeLoader;

saml-core-api/src/main/java/org/keycloak/dom/saml/v2/assertion/AuthnContextType.java

@@ -160,7 +160,7 @@ public class AuthnContextType implements Serializable {
      * ref="saml:AuthnContextDecl"/>
      * <element ref="saml:AuthnContextDeclRef"/> </choice> </sequence>
      */
-    public class AuthnContextTypeSequence implements Serializable {
+    public static class AuthnContextTypeSequence implements Serializable {
 
         private AuthnContextClassRefType classRef;
 

saml-core/src/main/java/org/keycloak/rotation/CompositeKeyLocator.java

@@ -110,7 +110,7 @@ public class CompositeKeyLocator implements KeyLocator, Iterable<Key> {
         return Collections.unmodifiableCollection(res);
     }
 
-    private class JointKeyIterator implements Iterable<Key> {
+    private static class JointKeyIterator implements Iterable<Key> {
 
         // based on http://stackoverflow.com/a/34126154/6930869
         private final Iterator<Iterable<Key>> iterablesIterator;

saml-core/src/main/java/org/keycloak/saml/common/util/TransformerUtil.java

@@ -435,7 +435,7 @@ public class TransformerUtil {
             return null;
         }
 
-        private class CustomHolder {
+        private static class CustomHolder {
             public Document doc;
 
             public boolean encounteredTextNode = false;

saml-core/src/main/java/org/keycloak/saml/processing/api/saml/v2/response/SAML2Response.java

@@ -117,7 +117,7 @@ public class SAML2Response {
         String authContextDeclRef = JBossSAMLURIConstants.AC_PASSWORD_PROTECTED_TRANSPORT.get();
         act.addAuthenticatingAuthority(URI.create(authContextDeclRef));
 
-        AuthnContextType.AuthnContextTypeSequence sequence = act.new AuthnContextTypeSequence();
+        AuthnContextType.AuthnContextTypeSequence sequence = new AuthnContextType.AuthnContextTypeSequence();
         sequence.setClassRef(new AuthnContextClassRefType(JBossSAMLURIConstants.AC_PASSWORD.getUri()));
         act.setSequence(sequence);
 

saml-core/src/main/java/org/keycloak/saml/processing/core/parsers/saml/assertion/SAMLAuthnContextParser.java

@@ -58,7 +58,7 @@ public class SAMLAuthnContextParser extends AbstractStaxSamlAssertionParser<Auth
             case AUTHN_CONTEXT_DECL:
                 Element dom = StaxParserUtil.getDOMElement(xmlEventReader);
                 AuthnContextDeclType authnContextDecl = new AuthnContextDeclType(dom);
-                authnContextSequence = target.getSequence() != null ? target.getSequence() : target.new AuthnContextTypeSequence();
+                authnContextSequence = target.getSequence() != null ? target.getSequence() : new AuthnContextType.AuthnContextTypeSequence();
                 authnContextSequence.setAuthnContextDecl(authnContextDecl);
                 target.setSequence(authnContextSequence);
                 break;
@@ -75,7 +75,7 @@ public class SAMLAuthnContextParser extends AbstractStaxSamlAssertionParser<Auth
                 text = StaxParserUtil.getElementText(xmlEventReader);
                 AuthnContextClassRefType authnContextClassRef = new AuthnContextClassRefType(URI.create(text));
 
-                authnContextSequence = target.getSequence() != null ? target.getSequence() : target.new AuthnContextTypeSequence();
+                authnContextSequence = target.getSequence() != null ? target.getSequence() : new AuthnContextType.AuthnContextTypeSequence();
                 authnContextSequence.setClassRef(authnContextClassRef);
 
                 target.setSequence(authnContextSequence);

saml-core/src/main/java/org/keycloak/saml/processing/core/saml/v2/util/StatementUtil.java

@@ -64,7 +64,7 @@ public class StatementUtil {
         AuthnContextType authnContext = new AuthnContextType();
         AuthnContextClassRefType authnContextClassRef = new AuthnContextClassRefType(URI.create(authnContextClassRefValue));
 
-        AuthnContextType.AuthnContextTypeSequence sequence = (authnContext).new AuthnContextTypeSequence();
+        AuthnContextType.AuthnContextTypeSequence sequence = new AuthnContextType.AuthnContextTypeSequence();
         sequence.setClassRef(authnContextClassRef);
         authnContext.setSequence(sequence);
 

server-spi-private/src/main/java/org/keycloak/models/utils/TimeBasedOTP.java

@@ -97,7 +97,7 @@ public class TimeBasedOTP extends HmacOTP {
         this.clock.setCalendar(calendar);
     }
 
-    private class Clock {
+    private static class Clock {
 
         private final int interval;
         private Calendar calendar;

services/src/main/java/org/keycloak/authorization/admin/PolicyEvaluationService.java

@@ -308,7 +308,7 @@ public class PolicyEvaluationService {
         return new CloseableKeycloakIdentity(accessToken, keycloakSession, userSession);
     }
 
-    public class EvaluationDecisionCollector extends DecisionPermissionCollector {
+    public static class EvaluationDecisionCollector extends DecisionPermissionCollector {
 
         public EvaluationDecisionCollector(AuthorizationProvider authorizationProvider, ResourceServer resourceServer, AuthorizationRequest request) {
             super(authorizationProvider, resourceServer, request);

services/src/main/java/org/keycloak/authorization/protection/introspect/RPTIntrospectionProvider.java

@@ -102,8 +102,8 @@ public class RPTIntrospectionProvider extends AccessTokenIntrospectionProvider {
 
     //todo: we need to avoid creating this class when processing responses. The only reason for that is that
     // UMA defines "resource_id" and "resource_scopes" claims but we use "rsid" and "scopes".
-    // To avoid breaking backward compatiblity we are just responding with all these claims.
+    // To avoid breaking backward compatibility we are just responding with all these claims.
-    public class UmaPermissionRepresentation extends Permission {
+    public static class UmaPermissionRepresentation extends Permission {
 
         public UmaPermissionRepresentation(Permission permission) {
             setResourceId(permission.getResourceId());

services/src/main/java/org/keycloak/email/freemarker/FreeMarkerEmailTemplateProvider.java

@@ -270,7 +270,7 @@ public class FreeMarkerEmailTemplateProvider implements EmailTemplateProvider {
         return sb.toString();
     }
 
-    protected class EmailTemplate {
+    protected static class EmailTemplate {
 
         private String subject;
         private String textBody;

services/src/main/java/org/keycloak/forms/account/freemarker/model/AccountFederatedIdentityBean.java

@@ -93,7 +93,7 @@ public class AccountFederatedIdentityBean {
         return removeLinkPossible;
     }
 
-    public class FederatedIdentityEntry implements OrderedModel {
+    public static class FederatedIdentityEntry implements OrderedModel {
 
         private FederatedIdentityModel federatedIdentityModel;
         private final String providerId;

services/src/main/java/org/keycloak/keys/DefaultKeyManager.java

@@ -268,7 +268,7 @@ public class DefaultKeyManager implements KeyManager {
         return providers;
     }
 
-    private class ProviderComparator implements Comparator<ComponentModel> {
+    private static class ProviderComparator implements Comparator<ComponentModel> {
 
         @Override
         public int compare(ComponentModel o1, ComponentModel o2) {

services/src/main/java/org/keycloak/protocol/oidc/TokenManager.java

@@ -1025,7 +1025,7 @@ public class TokenManager {
 
     }
 
-    public class RefreshResult {
+    public static class RefreshResult {
 
         private final AccessTokenResponse response;
         private final boolean offlineToken;

services/src/main/java/org/keycloak/protocol/oidc/endpoints/TokenEndpoint.java

@@ -1351,7 +1351,7 @@ public class TokenEndpoint {
         return codeVerifierEncoded;
     }
 
-    private class TokenExchangeSamlProtocol extends SamlProtocol {
+    private static class TokenExchangeSamlProtocol extends SamlProtocol {
         final SamlClient samlClient;
 
         TokenExchangeSamlProtocol(SamlClient samlClient) {

services/src/main/java/org/keycloak/services/managers/UserStorageSyncManager.java

@@ -75,7 +75,7 @@ public class UserStorageSyncManager {
         });
     }
 
-    private class Holder {
+    private static class Holder {
         ExecutionResult<SynchronizationResult> result;
     }
 

services/src/main/java/org/keycloak/theme/FreeMarkerUtil.java

@@ -85,7 +85,7 @@ public class FreeMarkerUtil {
         return cfg.getTemplate(templateName, "UTF-8");
     }
 
-    class ThemeTemplateLoader extends URLTemplateLoader {
+    static class ThemeTemplateLoader extends URLTemplateLoader {
 
         private Theme theme;
 

services/src/main/java/org/keycloak/truststore/FileTruststoreProviderFactory.java

@@ -127,7 +127,7 @@ public class FileTruststoreProviderFactory implements TruststoreProviderFactory
 
 
 
-    private class TruststoreCertificatesLoader {
+    private static class TruststoreCertificatesLoader {
 
         private Map<X500Principal, X509Certificate> trustedRootCerts = new HashMap<>();
         private Map<X500Principal, X509Certificate> intermediateCerts = new HashMap<>();

services/src/main/java/org/keycloak/validation/DefaultClientValidationProvider.java

@@ -91,7 +91,7 @@ public class DefaultClientValidationProvider implements ClientValidationProvider
         }
     }
 
-    class ValidationException extends Exception {
+    static class ValidationException extends Exception {
 
         public ValidationException(String message) {
             super(message, null, false, false);

testsuite/integration-arquillian/servers/auth-server/services/testsuite-providers/src/main/java/org/keycloak/testsuite/authorization/TestPolicyProviderFactory.java

@@ -89,7 +89,7 @@ public class TestPolicyProviderFactory implements PolicyProviderFactory {
         return "test";
     }
 
-    private class TestPolicyProvider implements PolicyProvider {
+    private static class TestPolicyProvider implements PolicyProvider {
 
         private final AuthorizationProvider authorization;
 

testsuite/integration-arquillian/servers/auth-server/services/testsuite-providers/src/main/java/org/keycloak/testsuite/federation/BackwardsCompatibilityUserStorage.java

@@ -378,7 +378,7 @@ public class BackwardsCompatibilityUserStorage implements UserLookupProvider, Us
     }
 
 
-    class MyUser {
+    static class MyUser {
 
         private String username;
         private CredentialModel hashedPassword;

testsuite/integration-arquillian/servers/auth-server/undertow/src/main/java/org/keycloak/testsuite/arquillian/undertow/lb/SimpleUndertowLoadBalancer.java

@@ -315,7 +315,7 @@ public class SimpleUndertowLoadBalancer {
     private static final AttachmentKey<Integer> REMAINING_RETRY_ATTEMPTS = AttachmentKey.create(Integer.class);
 
 
-    private class ProxyCallbackDelegate implements ProxyCallback<ProxyConnection> {
+    private static class ProxyCallbackDelegate implements ProxyCallback<ProxyConnection> {
 
         private final ProxyClient proxyClient;
         private final ProxyCallback<ProxyConnection> delegate;

testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/arquillian/TestClassProvider.java

@@ -43,7 +43,7 @@ public class TestClassProvider {
         server.stop();
     }
 
-    public class ClassPathResourceManager implements ResourceManager {
+    public static class ClassPathResourceManager implements ResourceManager {
 
         @Override
         public Resource getResource(String className) {

testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/auth/page/login/LoginForm.java

@@ -157,7 +157,7 @@ public class LoginForm extends Form {
         return getTextFromElement(rememberMeLabel);
     }
 
-    public class TotpSetupForm extends Form {
+    public static class TotpSetupForm extends Form {
         @FindBy(id = "totp")
         private WebElement totpInputField;
 

testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/console/page/AdminConsoleRealm.java

@@ -62,7 +62,7 @@ public class AdminConsoleRealm extends AdminConsoleRealmsRoot {
 //        return realmsResource().realm(getConsoleRealm());
 //    }
 
-    public class ConfigureMenu {
+    public static class ConfigureMenu {
 
         @FindBy(partialLinkText = "Realm Settings")
         private WebElement realmSettingsLink;
@@ -111,7 +111,7 @@ public class AdminConsoleRealm extends AdminConsoleRealmsRoot {
         return manageMenu;
     }
 
-    public class ManageMenu {
+    public static class ManageMenu {
 
         @FindBy(partialLinkText = "Users")
         private WebElement usersLink;

testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/console/page/events/AdminEvents.java

@@ -42,7 +42,7 @@ public class AdminEvents extends Events {
         return table;
     }
 
-    public class AdminEventsTable extends DataTable {
+    public static class AdminEventsTable extends DataTable {
 
         @FindBy(xpath = "//button[text()[contains(.,'Filter')]]")
         private WebElement filterButton;

testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/console/page/events/Config.java

@@ -45,7 +45,7 @@ public class Config extends Events {
         return form;
     }
 
-    public class ConfigForm extends Form {
+    public static class ConfigForm extends Form {
         @FindBy(id = "s2id_autogen1")
         private WebElement eventListenersInput;
 

testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/console/page/events/LoginEvents.java

@@ -42,7 +42,7 @@ public class LoginEvents extends Events {
         return table;
     }
 
-    public class LoginEventsTable extends DataTable {
+    public static class LoginEventsTable extends DataTable {
 
         @FindBy(xpath = "//button[text()[contains(.,'Filter')]]")
         private WebElement filterButton;

testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/drone/KeycloakWebDriverConfigurator.java

@@ -101,7 +101,7 @@ public class KeycloakWebDriverConfigurator {
         }
     }
 
-    public class KcBrowserCapabilities implements BrowserCapabilities {
+    public static class KcBrowserCapabilities implements BrowserCapabilities {
         private Capabilities capabilitiesToAdd;
         private BrowserCapabilities origBrowserCapabilities;
 

testsuite/utils/src/main/java/org/keycloak/testsuite/KerberosEmbeddedServer.java

@@ -263,7 +263,7 @@ public class KerberosEmbeddedServer extends LDAPEmbeddedServer {
      *
      * @author Dominik Pospisil <dpospisi@redhat.com>
      */
-    class NoReplayKdcServer extends KdcServer {
+    static class NoReplayKdcServer extends KdcServer {
 
         NoReplayKdcServer(KerberosConfig kdcConfig) {
             super(kdcConfig);

testsuite/utils/src/main/java/org/keycloak/testsuite/util/cli/LoadPersistentSessionsCommand.java

@@ -100,7 +100,7 @@ public class LoadPersistentSessionsCommand extends AbstractCommand {
     }
 
 
-    private class MyWorker implements Runnable {
+    private static class MyWorker implements Runnable {
 
         private final int workerId;
         private final int lastCreatedOn;

util/embedded-ldap/src/main/java/org/keycloak/util/ldap/RangedAttributeInterceptor.java

@@ -50,7 +50,7 @@ import org.apache.directory.server.core.api.interceptor.context.SearchOperationC
  */
 public class RangedAttributeInterceptor extends BaseInterceptor {
 
-    private class RangedEntryFilteringCursor implements EntryFilteringCursor {
+    private static class RangedEntryFilteringCursor implements EntryFilteringCursor {
 
         private final EntryFilteringCursor c;
         private final String name;