diff --git a/saml-core/src/main/java/org/keycloak/saml/common/util/DocumentUtil.java b/saml-core/src/main/java/org/keycloak/saml/common/util/DocumentUtil.java index d9dd4e04e2..b5f2232a47 100755 --- a/saml-core/src/main/java/org/keycloak/saml/common/util/DocumentUtil.java +++ b/saml-core/src/main/java/org/keycloak/saml/common/util/DocumentUtil.java @@ -97,10 +97,9 @@ public class DocumentUtil { * @throws ParserConfigurationException */ public static Document createDocument() throws ConfigurationException { - DocumentBuilderFactory factory = getDocumentBuilderFactory(); DocumentBuilder builder; try { - builder = factory.newDocumentBuilder(); + builder = getDocumentBuilder(); } catch (ParserConfigurationException e) { throw new ConfigurationException(e); } @@ -118,8 +117,7 @@ public class DocumentUtil { */ public static Document createDocumentWithBaseNamespace(String baseNamespace, String localPart) throws ProcessingException { try { - DocumentBuilderFactory factory = getDocumentBuilderFactory(); - DocumentBuilder builder = factory.newDocumentBuilder(); + DocumentBuilder builder = getDocumentBuilder(); return builder.getDOMImplementation().createDocument(baseNamespace, localPart, null); } catch (DOMException e) { throw logger.processingError(e); @@ -157,8 +155,7 @@ public class DocumentUtil { */ public static Document getDocument(Reader reader) throws ConfigurationException, ProcessingException, ParsingException { try { - DocumentBuilderFactory factory = getDocumentBuilderFactory(); - DocumentBuilder builder = factory.newDocumentBuilder(); + DocumentBuilder builder = getDocumentBuilder(); return builder.parse(new InputSource(reader)); } catch (ParserConfigurationException e) { throw logger.configurationError(e); @@ -181,9 +178,8 @@ public class DocumentUtil { * @throws SAXException */ public static Document getDocument(File file) throws ConfigurationException, ProcessingException, ParsingException { - DocumentBuilderFactory factory = getDocumentBuilderFactory(); try { - DocumentBuilder builder = factory.newDocumentBuilder(); + DocumentBuilder builder = getDocumentBuilder(); return builder.parse(file); } catch (ParserConfigurationException e) { throw logger.configurationError(e); @@ -206,9 +202,8 @@ public class DocumentUtil { * @throws SAXException */ public static Document getDocument(InputStream is) throws ConfigurationException, ProcessingException, ParsingException { - DocumentBuilderFactory factory = getDocumentBuilderFactory(); try { - DocumentBuilder builder = factory.newDocumentBuilder(); + DocumentBuilder builder = getDocumentBuilder(); return builder.parse(is); } catch (ParserConfigurationException e) { throw logger.configurationError(e); @@ -502,6 +497,25 @@ public class DocumentUtil { } } + private static final ThreadLocal XML_DOCUMENT_BUILDER = new ThreadLocal() { + @Override + protected DocumentBuilder initialValue() { + DocumentBuilderFactory factory = getDocumentBuilderFactory(); + try { + return factory.newDocumentBuilder(); + } catch (ParserConfigurationException ex) { + throw new RuntimeException(ex); + } + } + + }; + + private static DocumentBuilder getDocumentBuilder() throws ParserConfigurationException { + DocumentBuilder res = XML_DOCUMENT_BUILDER.get(); + res.reset(); + return res; + } + /** *

Creates a namespace aware {@link DocumentBuilderFactory}. The returned instance is cached and shared between * different threads.