libre.sh/keycloak-scim
3
0
Fork 0
Code Issues 15 Pull requests Releases Packages Activity Actions

Merge pull request #644 from edewit/cypress-client-scope

Browse source 
makes client scope test more reliable
This commit is contained in:
mfrances17 2021-05-27 09:49:30 -04:00 committed by GitHub
commit 1e2de8d570
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cypress/integration/client_scopes_test.spec.ts
View file

@ -50,6 +50,7 @@ describe("Client Scopes test", function () {
masthead.checkNotificationMessage("Client scope created"); masthead.checkNotificationMessage("Client scope created");
sidebarPage.goToClientScopes(); sidebarPage.goToClientScopes();
cy.get(".pf-c-spinner__tail-ball").should("not.exist");
// Delete // Delete
listingPage.itemExist(itemId).deleteItem(itemId); listingPage.itemExist(itemId).deleteItem(itemId);
@ -59,8 +60,7 @@ describe("Client Scopes test", function () {
masthead.checkNotificationMessage("The client scope has been deleted"); masthead.checkNotificationMessage("The client scope has been deleted");
listingPage // It is not refreshing after delete listingPage.itemExist(itemId, false);
.itemExist(itemId, false);
}); });
}); });

33
cypress/support/pages/admin_console/ListingPage.ts
View file

@ -1,26 +1,15 @@
export default class ListingPage { export default class ListingPage {
searchInput: string; private searchInput = '.pf-c-toolbar__item [type="search"]:visible';
itemsRows: string; private itemsRows = "table";
itemRowDrpDwn: string; private itemRowDrpDwn = ".pf-c-dropdown__toggle";
exportBtn: string; public exportBtn = '[role="menuitem"]:nth-child(1)';
deleteBtn: string; public deleteBtn = '[role="menuitem"]:nth-child(2)';
searchBtn: string; private searchBtn =
createBtn: string; ".pf-c-page__main .pf-c-toolbar__content-section button.pf-m-control:visible";
importBtn: string; private createBtn =
".pf-c-page__main .pf-c-toolbar__content-section button.pf-m-primary:visible";
constructor() { private importBtn =
this.searchInput = '.pf-c-toolbar__item [type="search"]:visible'; ".pf-c-page__main .pf-c-toolbar__content-section button.pf-m-link";
this.itemsRows = "table";
this.itemRowDrpDwn = ".pf-c-dropdown > button";
this.exportBtn = '[role="menuitem"]:nth-child(1)';
this.deleteBtn = '[role="menuitem"]:nth-child(2)';
this.searchBtn =
".pf-c-page__main .pf-c-toolbar__content-section button.pf-m-control:visible";
this.createBtn =
".pf-c-page__main .pf-c-toolbar__content-section button.pf-m-primary:visible";
this.importBtn =
".pf-c-page__main .pf-c-toolbar__content-section button.pf-m-link";
}
goToCreateItem() { goToCreateItem() {
cy.get(this.createBtn).click(); cy.get(this.createBtn).click();

9
src/client-scopes/ClientScopesSection.tsx
View file

@ -83,7 +83,14 @@ export const ClientScopesSection = () => {
onConfirm: async () => { onConfirm: async () => {
try { try {
for (const scope of selectedScopes) { for (const scope of selectedScopes) {
await removeScope(adminClient, scope); try {
await removeScope(adminClient, scope);
} catch (error) {
console.warn(
"could not remove scope",
error.response?.data?.errorMessage || error
);
}
await adminClient.clientScopes.del({ id: scope.id! }); await adminClient.clientScopes.del({ id: scope.id! });
} }
addAlert(t("deletedSuccess"), AlertVariant.success); addAlert(t("deletedSuccess"), AlertVariant.success);