Enable 'no-empty-function' ESlint rule (#917)

.eslintrc.js

@@ -18,6 +18,16 @@ module.exports = {
   },
   rules: {
     "no-unused-vars": "off",
-    "@typescript-eslint/no-unused-vars": ["error"],
+    "@typescript-eslint/no-unused-vars": "error",
+    "@typescript-eslint/no-empty-function": "error",
   },
+  overrides: [
+    {
+      files: ["*.test.*"],
+      rules: {
+        // For tests it can make sense to pass empty functions as mocks.
+        "@typescript-eslint/no-empty-function": "off",
+      },
+    },
+  ],
 };

src/client-scopes/ClientScopesSection.tsx

@@ -221,7 +221,6 @@ export const ClientScopesSection = () => {
           actions={[
             {
               title: t("common:export"),
-              onRowClick: () => {},
             },
             {
               title: t("common:delete"),

src/clients/add/NewClientForm.tsx

@@ -54,11 +54,11 @@ export const NewClientForm = () => {
     }
   };
 
-  const forward = async (onNext: () => void) => {
+  const forward = async (onNext?: () => void) => {
     if (await methods.trigger()) {
       setClient({ ...client, ...methods.getValues() });
       setShowCapabilityConfig(true);
-      onNext();
+      onNext?.();
     }
   };
 
@@ -71,7 +71,7 @@ export const NewClientForm = () => {
     if (newStep.id === "generalSettings") {
       back();
     } else {
-      forward(() => {});
+      forward();
     }
   };
 

src/clients/scopes/ClientScopes.tsx

@@ -279,7 +279,6 @@ export const ClientScopes = ({ clientId, protocol }: ClientScopesProps) => {
             </ToolbarItem>
             <ToolbarItem>
               <Dropdown
-                onSelect={() => {}}
                 toggle={
                   <KebabToggle onToggle={() => setKebabOpen(!kebabOpen)} />
                 }

src/components/group/GroupPath.tsx

@@ -24,13 +24,13 @@ const truncatePath = (path?: string) => {
 
 export const GroupPath = ({
   group: { path },
-  onMouseEnter: onMouseEnterProp = () => {},
+  onMouseEnter: onMouseEnterProp,
   ...props
 }: GroupPathProps) => {
   const [tooltip, setTooltip] = React.useState("");
   const onMouseEnter = (event: any) => {
     setTooltip(path!);
-    onMouseEnterProp(event);
+    onMouseEnterProp?.(event);
   };
   const text = (
     <span onMouseEnter={onMouseEnter} {...props}>

src/identity-providers/IdentityProvidersSection.tsx

@@ -196,7 +196,6 @@ export const IdentityProvidersSection = () => {
                 <ToolbarItem>
                   <Dropdown
                     data-testid="addProviderDropdown"
-                    onSelect={() => {}}
                     toggle={
                       <DropdownToggle
                         onToggle={() => setAddProviderOpen(!addProviderOpen)}

src/realm-settings/KeysListTab.tsx

@@ -117,7 +117,7 @@ export const KeysListTab = ({ realmComponents }: KeysListTabProps) => {
     messageKey: publicKey,
     continueButtonLabel: "common:close",
     continueButtonVariant: ButtonVariant.primary,
-    onConfirm: async () => {},
+    onConfirm: () => Promise.resolve(),
   });
 
   const [toggleCertificateDialog, CertificateDialog] = useConfirmDialog({
@@ -125,7 +125,7 @@ export const KeysListTab = ({ realmComponents }: KeysListTabProps) => {
     messageKey: certificate,
     continueButtonLabel: "common:close",
     continueButtonVariant: ButtonVariant.primary,
-    onConfirm: async () => {},
+    onConfirm: () => Promise.resolve(),
   });
 
   const goToCreate = () => history.push(`${url}/add-role`);

src/user-federation/UserFederationLdapWizard.tsx

@@ -144,11 +144,8 @@ export const UserFederationLdapWizard = () => {
           else if (activeStep.id === "ldapAdvancedSettingsStep") {
             return (
               <>
-                <Button
-                  onClick={() => {}} //TODO: close the wizard and finish
-                >
-                  {t("common:finish")}
-                </Button>
+                {/* TODO: close the wizard and finish */}
+                <Button>{t("common:finish")}</Button>
                 <Button variant="secondary" onClick={onBack}>
                   {t("common:back")}
                 </Button>
@@ -165,10 +162,8 @@ export const UserFederationLdapWizard = () => {
               <Button variant="secondary" onClick={onBack}>
                 Back
               </Button>
-              <Button
-                variant="link"
-                onClick={() => {}} //TODO: validate last step and finish
-              >
+              {/* TODO: validate last step and finish */}
+              <Button variant="link">
                 {t("common:skipCustomizationAndFinish")}
               </Button>
               <Button variant="link" onClick={onClose}>

src/user/UserConsents.tsx

@@ -144,7 +144,6 @@ export const UserConsents = () => {
             icon={CubesIcon}
             message={t("users:noConsents")}
             instructions={t("users:noConsentsText")}
-            onPrimaryAction={() => {}}
           />
         }
       />